gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
27,431 Commits 1 Branch 0 Tags
Commit Graph

27431 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
antirez
f5fa2985f8 Mark PFDEBUG as write command in the commands table. 
It is safer since it is able to have side effects.
 2014-04-14 15:57:50 +02:00
antirez
9df77fc0c4 Mark PFDEBUG as write command in the commands table. 
It is safer since it is able to have side effects.
 2014-04-14 15:57:50 +02:00
antirez
4a43c113c5 Correctly replicate PFDEBUG GETREG. 
Even if it is a debugging command, make sure that when it forces a
change in encoding, the command is propagated.
 2014-04-14 15:57:19 +02:00
antirez
3bc35f9ce9 Correctly replicate PFDEBUG GETREG. 
Even if it is a debugging command, make sure that when it forces a
change in encoding, the command is propagated.
 2014-04-14 15:57:19 +02:00
antirez
1e7f95441f Added assertion in hllSparseAdd() when promotion to dense occurs. 
If we converted to dense, a register must be updated in the dense
representation.
 2014-04-14 15:55:21 +02:00
antirez
ba0afb4566 Added assertion in hllSparseAdd() when promotion to dense occurs. 
If we converted to dense, a register must be updated in the dense
representation.
 2014-04-14 15:55:21 +02:00
antirez
f009069d7c hllSparseAdd(): speed optimization. 
Mostly by reordering opcodes check conditional by frequency of opcodes
in larger sparse-encoded HLLs.
 2014-04-14 15:42:05 +02:00
antirez
e9cd51c7eb hllSparseAdd(): speed optimization. 
Mostly by reordering opcodes check conditional by frequency of opcodes
in larger sparse-encoded HLLs.
 2014-04-14 15:42:05 +02:00
antirez
d2174e6c9b Detect corrupted sparse HLLs in hllSparseSum(). 2014-04-14 15:20:26 +02:00
antirez
681bf7468b Detect corrupted sparse HLLs in hllSparseSum(). 2014-04-14 15:20:26 +02:00
antirez
a84b91d052 hllSparseAdd(): faster code removing conditional. 
Bottleneck found profiling. Big run time improvement found when testing
after the change.
 2014-04-14 12:58:46 +02:00
antirez
db40da0a47 hllSparseAdd(): faster code removing conditional. 
Bottleneck found profiling. Big run time improvement found when testing
after the change.
 2014-04-14 12:58:46 +02:00
antirez
6c0f0eb21f Comment typo in hllSparseAdd(). first -> fits. 2014-04-14 12:12:53 +02:00
antirez
4e0a99ba51 Comment typo in hllSparseAdd(). first -> fits. 2014-04-14 12:12:53 +02:00
antirez
8670ab5e11 Merge adjacent VAL opcodes in hllSparseAdd(). 
As more values are added splitting ZERO or XZERO opcodes, try to merge
adjacent VAL opcodes if they have the same value.
 2014-04-14 12:11:39 +02:00
antirez
5532b5308a Merge adjacent VAL opcodes in hllSparseAdd(). 
As more values are added splitting ZERO or XZERO opcodes, try to merge
adjacent VAL opcodes if they have the same value.
 2014-04-14 12:11:39 +02:00
antirez
cba3a04160 More robust HLL_SPARSE macros protecting 'p' with parens. 
Now the macros will work with arguments such as "ptr+1".
 2014-04-14 11:49:53 +02:00
antirez
837ca39081 More robust HLL_SPARSE macros protecting 'p' with parens. 
Now the macros will work with arguments such as "ptr+1".
 2014-04-14 11:49:53 +02:00
antirez
d15cd39717 hllSparseAdd() opcode seek stop condition fixed. 2014-04-14 11:04:11 +02:00
antirez
142d133c8a hllSparseAdd() opcode seek stop condition fixed. 2014-04-14 11:04:11 +02:00
antirez
c9ee98b388 Fixed error message generation in PFDEBUG GETREG. 
Bulk length for registers was emitted too early, so if there was a bug
the reply looked like a long array with just one element, blocking the
client as result.
 2014-04-14 10:25:19 +02:00
antirez
1ee18db922 Fixed error message generation in PFDEBUG GETREG. 
Bulk length for registers was emitted too early, so if there was a bug
the reply looked like a long array with just one element, blocking the
client as result.
 2014-04-14 10:25:19 +02:00
antirez
70a3bcf3a3 Fixed memmove() count in hllSparseAdd(). 2014-04-14 09:40:07 +02:00
antirez
82c31f750d Fixed memmove() count in hllSparseAdd(). 2014-04-14 09:40:07 +02:00
antirez
ac3655f2a1 hllSparseAdd(): more correct dense conversion conditional. 
We want to promote if the total string size exceeds the resulting size
after the upgrade.
 2014-04-14 09:36:32 +02:00
antirez
3b20003503 hllSparseAdd(): more correct dense conversion conditional. 
We want to promote if the total string size exceeds the resulting size
after the upgrade.
 2014-04-14 09:36:32 +02:00
antirez
4fb59e800d hllSparseToDense(): sanity check added. 
The function checks if all the HLL_REGISTERS were processed during the
convertion from sparse to dense encoding, returning REDIS_OK or
REDIS_ERR to signal a corruption problem.

A bug in PFDEBUG GETREG was fixed: when the object is converted to the
dense representation we need to reassign the new pointer to the header
structure pointer.
 2014-04-14 09:27:01 +02:00
antirez
b7571b7453 hllSparseToDense(): sanity check added. 
The function checks if all the HLL_REGISTERS were processed during the
convertion from sparse to dense encoding, returning REDIS_OK or
REDIS_ERR to signal a corruption problem.

A bug in PFDEBUG GETREG was fixed: when the object is converted to the
dense representation we need to reassign the new pointer to the header
structure pointer.
 2014-04-14 09:27:01 +02:00
antirez
2800054f34 PFDEBUG DECODE added. 
Provides a human readable description of the opcodes composing a
run-length encoded HLL (sparse encoding).
The command is only useful for debugging / development tasks.
 2014-04-14 09:00:53 +02:00
antirez
f9dc3cb04d PFDEBUG DECODE added. 
Provides a human readable description of the opcodes composing a
run-length encoded HLL (sparse encoding).
The command is only useful for debugging / development tasks.
 2014-04-14 09:00:53 +02:00
antirez
62106ad517 PFDEBUG added, PFGETREG removed. 
PFDEBUG will be the interface to do debugging tasks with a key
containing an HLL object.
 2014-04-13 23:01:21 +02:00
antirez
261da523e8 PFDEBUG added, PFGETREG removed. 
PFDEBUG will be the interface to do debugging tasks with a key
containing an HLL object.
 2014-04-13 23:01:21 +02:00
antirez
5349296f29 hllSparseToDense API changed to take ref to object. 
The new API takes directly the object doing everything needed to
turn it into a dense representation, including setting the new
representation as object->ptr.
 2014-04-13 22:59:27 +02:00
antirez
e8e717e145 hllSparseToDense API changed to take ref to object. 
The new API takes directly the object doing everything needed to
turn it into a dense representation, including setting the new
representation as object->ptr.
 2014-04-13 22:59:27 +02:00
antirez
fd412fcb55 hllSparseAdd() sanity check for span != 0 added. 2014-04-13 10:19:12 +02:00
antirez
2067644a8c hllSparseAdd() sanity check for span != 0 added. 2014-04-13 10:19:12 +02:00
antirez
2b4f24e746 Fix hllSparseAdd() new sequence replacement when next is NULL. 
sdsIncrLen() must be called anyway even if we are replacing the last
oppcode of the sparse representation.
 2014-04-12 23:55:44 +02:00
antirez
80140fa006 Fix hllSparseAdd() new sequence replacement when next is NULL. 
sdsIncrLen() must be called anyway even if we are replacing the last
oppcode of the sparse representation.
 2014-04-12 23:55:44 +02:00
antirez
c66e5e83a8 Fix seqlen computation in hllSparseAdd(). 2014-04-12 23:52:36 +02:00
antirez
3c3c16561a Fix seqlen computation in hllSparseAdd(). 2014-04-12 23:52:36 +02:00
antirez
5c770c87ee Abstract hllSparseAdd() / hllDenseAdd() via hllAdd(). 2014-04-12 23:42:56 +02:00
antirez
a9e057e095 Abstract hllSparseAdd() / hllDenseAdd() via hllAdd(). 2014-04-12 23:42:56 +02:00
antirez
30476ea26f hllSparseSum(): multiply 1 * runlen for zero entries. 2014-04-12 16:47:50 +02:00
antirez
0b7d08efb9 hllSparseSum(): multiply 1 * runlen for zero entries. 2014-04-12 16:47:50 +02:00
antirez
2c3256769c Macro HLL_SPARSE_XZERO_LEN fixed. 2014-04-12 16:46:08 +02:00
antirez
d9314079ca Macro HLL_SPARSE_XZERO_LEN fixed. 2014-04-12 16:46:08 +02:00
antirez
231325f260 Fix HLL sparse object creation #2. 
Two vars initialized to wrong values in createHLLObject().
 2014-04-12 16:37:50 +02:00
antirez
f5c03044a6 Fix HLL sparse object creation #2. 
Two vars initialized to wrong values in createHLLObject().
 2014-04-12 16:37:50 +02:00
antirez
179e37b6b0 Increment pointer while iterating sparse HLL object. 2014-04-12 11:02:14 +02:00
antirez
b5659cb0a6 Increment pointer while iterating sparse HLL object. 2014-04-12 11:02:14 +02:00