gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
10,373 Commits 1 Branch 0 Tags
Commit Graph

7468 Commits

Author SHA1 Message Date
antirez
ed3fd6c524 Fix #7306 less aggressively. 
Citing from the issue:

btw I suggest we change this fix to something else:
* We revert the fix.
* We add a call that disconnects chained replicas in the place where we trim the replica (that is a master i this case) offset.
This way we can avoid disconnections when there is no trimming of the backlog.

Note that we now want to disconnect replicas asynchronously in
disconnectSlaves(), because it's in general safer now that we can call
it from freeClient(). Otherwise for instance the command:

    CLIENT KILL TYPE master

May crash: clientCommand() starts running the linked of of clients,
looking for clients to kill. However it finds the master, kills it
calling freeClient(), but this in turn calls replicationCacheMaster()
that may also call disconnectSlaves() now. So the linked list iterator
of the clientCommand() will no longer be valid.
 2020-05-25 12:08:01 +02:00
Maxime de Roucy
c0f60008cb acl: @replication command group 
containing mandatory commands for replication (used by masteruser user)


Former-commit-id: 123bc125cfe7b30fdeef833759a33ccc854b5c51
 2020-05-25 02:35:22 -04:00
John Sully
4bb5c35548 Fix issue #170. Intermittent crash destroying fastlock due to implicit type conversion in assert 
Former-commit-id: ecbe168b5421687899a621c995e44f43faec2b71
 2020-05-25 02:13:57 -04:00
John Sully
9a357ec4b5 Fix infinite logs of Error in rreplay 
Former-commit-id: 00cef78858cd05fc067fa5002f2995653452c63f
 2020-05-24 20:05:22 -04:00
John Sully
845027c291 Enable TLS connections 
Former-commit-id: d05da0fabdfeb7eadce6546c7c1d85739b2794d7
 2020-05-24 19:57:16 -04:00
John Sully
d176ae50ec don't keep feeding data to clients pending close 
Former-commit-id: 4db3f2a443a6f71d1486781005ee37546e89d6e1
 2020-05-24 12:46:11 -04:00
John Sully
5c35593937 Quiet TSAN during exit 
Former-commit-id: fd710d590a6297b74e06ce6832dd75bfca0a266f
 2020-05-24 12:45:10 -04:00
John Sully
7630b63f06 Hold the AE lock until we process the repl backlog after a command 
Former-commit-id: 4893eedacbf5f9210d02361ed07b9beee0c9f655
 2020-05-24 11:19:23 -04:00
John Sully
0d8c7c7182 Add standardized way to post client dependent functions 
Former-commit-id: fb50163b47cf660911dc7f67809c15ba1394613a
 2020-05-24 02:46:39 -04:00
John Sully
65e4f82982 remove unnecessary cplusplus guard 
Former-commit-id: 3b8463f9d20162369cffd9ed347865c5c8049f40
 2020-05-24 02:45:55 -04:00
John Sully
0dd0ea7eda race in connection state when setting a handler on a different thread 
Former-commit-id: 42c7677690c434168135992429f7521239475ef8
 2020-05-24 02:45:11 -04:00
John Sully
d3bd1ab56b Fix ASAN races 
Former-commit-id: 8665f250314c4e3de32f3b31a2c0158908ef982b
 2020-05-24 01:58:33 -04:00
John Sully
4136a1084b Incorrect locking in replication error paths 
Former-commit-id: 1c6b57314747787958ad215826296627f9050f59
 2020-05-24 01:57:49 -04:00
John Sully
2ea5bf4f55 Incorrect memory order on weak ordered architectures 
Former-commit-id: 90162da1a6c025d148a0d1761ae4d5fbc9bfc0ef
 2020-05-24 01:57:18 -04:00
John Sully
dde860c60b If we request shutdown from a client on a different thread than a blocking lua script we fail to actually shutdown until the script completes 
Former-commit-id: 1ca6c1dd56131bc28fe9f831e2b9cab7adb846a3
 2020-05-24 01:56:23 -04:00
John Sully
aaff167eb9 race calculating client overhead 
Former-commit-id: 2d27c8ecdb5242284301f135b1d542f9ead5b8f2
 2020-05-24 01:53:43 -04:00
John Sully
3813d5835e During RDB load we can only handle clients on the main thread as our workers are not yet created. This change also unifies the accept logic across the socket types 
Former-commit-id: 59cda9cfb96eca55c4b445309970bd95277ebc5c
 2020-05-23 16:03:24 -04:00
John Sully
3c0e1a1baf Diskless replication handler needs to run on the main thread 
Former-commit-id: 091af6400348b7716f7fe0bc845bf7f16d922815
 2020-05-23 15:15:42 -04:00
ShooterIT
646cc81c96 Fix reply bytes calculation error 
Fix #7275.


Former-commit-id: a12210c87561fed5522c9a6e8db6d8606cabe3bf
 2020-05-23 13:02:55 -04:00
John Sully
36032618b2 Merge tag '6.0.3' into unstable 
Redis 6.0.3


Former-commit-id: 43649fc5b4425fb05e2c1aa48da7c07bc83ce24d
 2020-05-22 16:53:10 -04:00
John Sully
fa0be83fd9 Merge tag '6.0.2' into unstable 
Redis 6.0.2


Former-commit-id: a010e4a4b2cc2bcad1cb14604b7ebc596c35b05e
 2020-05-22 16:45:18 -04:00
John Sully
c03e9a3e2c Merge commit 'e834acb91c89d083d0075e320dea6ad7188f2d0d' into unstable 
Former-commit-id: 817a11ff110772893eda0675912bbb0cfc1fca74
 2020-05-22 15:56:35 -04:00
John Sully
bd3deb6c67 Merge commit '05b332e550e7ce32e364dde6cdd8820e8665eb21' into unstable 
Former-commit-id: c52e1fc78c369843e49a22765bed2c53e99d9709
 2020-05-22 15:42:50 -04:00
John Sully
5a7ce664d0 Merge commit '78cbd3039858407837632bc37abb36e36ec60ce5' into unstable 
Former-commit-id: d74871da40dea11bd1a226fbecb0974ff5f8ec8c
 2020-05-22 15:36:44 -04:00
Madelyn Olson
8802cbbcde EAGAIN for tls during diskless load 2020-05-22 12:37:59 +02:00
Qu Chen
5d59bbb6d9 Disconnect chained replicas when the replica performs PSYNC with the master always to avoid replication offset mismatch between master and chained replicas. 2020-05-22 12:37:59 +02:00
hwware
08c70f7dce using moreargs variable 2020-05-22 12:37:59 +02:00
hwware
5c70dab9fc fix server crash for STRALGO command 2020-05-22 12:37:49 +02:00
ShooterIT
e60f63a718 Replace addDeferredMultiBulkLength with addReplyDeferredLen in comment 2020-05-22 12:37:49 +02:00
ShooterIT
9d1265240f Fix reply bytes calculation error 
Fix #7275.
 2020-05-22 12:37:49 +02:00
zhaozhao.zz
830c674845 Tracking: flag CLIENT_TRACKING_BROKEN_REDIR when redir broken 2020-05-22 12:37:49 +02:00
Oran Agra
56d63f4d7d fix a rare active defrag edge case bug leading to stagnation 
There's a rare case which leads to stagnation in the defragger, causing
it to keep scanning the keyspace and do nothing (not moving any
allocation), this happens when all the allocator slabs of a certain bin
have the same % utilization, but the slab from which new allocations are
made have a lower utilization.

this commit fixes it by removing the current slab from the overall
average utilization of the bin, and also eliminate any precision loss in
the utilization calculation and move the decision about the defrag to
reside inside jemalloc.

and also add a test that consistently reproduce this issue.
 2020-05-22 12:37:49 +02:00
Oran Agra
4f8e19f877 improve DEBUG MALLCTL to be able to write to write only fields. 
also support:
  debug mallctl-str thread.tcache.flush VOID
 2020-05-22 12:37:49 +02:00
hujie
6bb5b6d942 fix clear USER_FLAG_ALLCOMMANDS flag in acl 
in ACLSetUserCommandBit, when the command bit overflows, no operation
is performed, so no need clear the USER_FLAG_ALLCOMMANDS flag.

in ACLSetUser, when adding subcommand, we don't need to call
ACLGetCommandID ahead since subcommand may be empty.
 2020-05-22 12:37:49 +02:00
ShooterIT
2478a83ce7 Redis Benchmark: generate random test data 
The function of generating random data is designed by antirez. See #7196.
 2020-05-22 12:37:49 +02:00
hwware
3ffb3ac7ea Redis-Benchmark: avoid potentical memmory leaking 2020-05-22 12:37:49 +02:00
ShooterIT
e113af7448 Use dictSize to get the size of dict in dict.c 2020-05-22 12:37:49 +02:00
Madelyn Olson
1d84b89fb6 Converge hash validation for adding and removing 2020-05-22 12:37:49 +02:00
Benjamin Sergeant
5d88c23555 do not handle --cluster-yes for cluster fix mode 2020-05-22 12:37:49 +02:00
Benjamin Sergeant
dc2f7e0ad7 fix typo ... 2020-05-22 12:37:49 +02:00
Benjamin Sergeant
902e82efd2 Redis-cli 6.0.1 --cluster-yes doesn't work (fix #7246) 
This make it so that all prompts for all redis-cli --cluster commands are automatically answered with a yes.
 2020-05-22 12:37:49 +02:00
John Sully
2fa3fb9573 Merge tag '6.0.1' into unstable 
Redis 6.0.1.


Former-commit-id: c505df8830123904da026be2aacbd92a95a5e37c
 2020-05-21 23:41:36 -04:00
John Sully
6402c28d5c Missing noexcept 
Former-commit-id: f214ada545f810f8a9095753984b75c438cd6464
 2020-05-21 23:25:50 -04:00
John Sully
62261642cc build failure on macos 
Former-commit-id: c10aa3b8b0811da9931745695c5de06fdfa99fe3
 2020-05-21 23:24:34 -04:00
John Sully
193d7c76cb Fix bad merge in CI.yml 
Former-commit-id: 6311d709c39b3bacaeab77b18033010f1b548f81
 2020-05-21 22:09:06 -04:00
John Sully
e245fdbb89 Merge commit '97e58ee026675e70fbd8843f7a86e98f53a3c791' into unstable 
Former-commit-id: 8ab77465dbb3c0b1f859f24cdbb461937516eb6a
 2020-05-21 19:37:42 -04:00
John Sully
cc8d7c1afd Merge commit '3b373fbb0b05ee862dfef32199cfb63459019cd9' into unstable 
Former-commit-id: 201bf73ef772914c56ac680bb9c7fb6a98b218b2
 2020-05-21 18:57:28 -04:00
John Sully
ccedb2fa73 Merge commit 'd7b07d3ded06b4cd843baffd3a6d33dd96efd401' into unstable 
Former-commit-id: 49784c8122e827bd9de86bbae4d88c313400e86e
 2020-05-21 18:48:49 -04:00
John Sully
8377df8330 Merge commit '87924d673138531cbaf606015ea7b6a9e3ae2465' into unstable 
Former-commit-id: 3e03f308b564cd94f4a6407c80792d080e0f83c5
 2020-05-21 17:55:09 -04:00
John Sully
327d543f2c Merge commit 'c5d805f87771581d3f6b29861ed2062c0ae2a688' into unstable 
Former-commit-id: 95cecb0229af0278cf614ffd746ba829ae7c897c
 2020-05-21 17:45:15 -04:00