Oran Agra
e0cc3c99d2
Additional config.c refactory and bugfixes
...
- add capability for each config to have a callback to check if value is valid and return error string
will enable converting many of the remaining custom configs into generic ones (reducing the x4 repetition for set,get,config,rewrite)
- add capability for each config to to run some update code after config is changed (only for CONFIG SET)
will also enable converting many of the remaining custom configs into generic ones
- add capability to move default values from server.h and server.c to config.c
will reduce many excess lines in server.h and server.c (plus, no need to rebuild the entire code base when a default change 8-))
other behavior changes:
- fix bug in bool config get (always returning 'yes')
- fix a bug in modifying jemalloc-bg-thread at runtime (didn't call set_jemalloc_bg_thread, due to bad merge conflict resolution (my fault))
- side effect when a failed attempt to enable activedefrag at runtime, we now respond with -ERR and not with -DISABLED
2019-11-26 16:52:28 +02:00
John Sully
27f7c2af00
Ensure size() count is accurate, and fix find_threadsafe which didn't check children
...
Former-commit-id: ffa44b636afd4fe907c79fe7deebac3d1e091ee9
2019-11-25 17:50:40 -05:00
Salvatore Sanfilippo
a1b654819c
Merge pull request #6598 from oranagra/module-hook-test
...
try to fix an unstable test (module hook for loading progress)
2019-11-25 17:54:21 +01:00
Salvatore Sanfilippo
a40669893e
Merge pull request #6609 from daidaotong/macrofix
...
Add macro in bio.h
2019-11-25 10:04:28 +01:00
Salvatore Sanfilippo
6203ed0474
Merge pull request #6593 from daidaotong/movecommandfix
...
fix move command: WATCH/MULTI/EXEC mechanism breaks
2019-11-25 10:02:43 +01:00
Salvatore Sanfilippo
d39afb687d
Merge pull request #6563 from devnexen/fbsd_build_fix2
...
Add missing header
2019-11-25 09:45:29 +01:00
John Sully
1efd066a96
Move snapshot code into its own file
...
Former-commit-id: 4afd0a6ce650cc93a73ea3e4bb632226087dde37
2019-11-24 17:59:02 -05:00
John Sully
4346bcd7dc
Restrict the snapshot API
...
Former-commit-id: cbafb88f267a9480cdbde6a88e9e1992e8a85971
2019-11-24 17:53:06 -05:00
John Sully
a1f29681aa
Get rid of key only iterate, the threadsafe is just as fast and key only users can ignore the robj
...
Former-commit-id: 29689a5ed6141c5b2019d41ccd4036e6ddd1a121
2019-11-24 15:45:17 -05:00
John Sully
1badb64289
Fix crash on shutdown
...
Former-commit-id: 6dc55cc0f838b3c82afb233985429b4e7fc5dfb1
2019-11-24 14:24:41 -05:00
John Sully
dc47a20da3
Fix multithreading data races
...
Former-commit-id: 80f6e5818fd575cb08a5f620c35eed1cd862eb57
2019-11-24 13:44:43 -05:00
John Sully
a7d378659f
Fix warning
...
Former-commit-id: 1318b87013c61f7149127eae8e30caf887a6db7b
2019-11-23 19:19:54 -05:00
John Sully
b0278f5609
Add support for nesting snapshots
...
Former-commit-id: 5e6c37f388233cc3f2d204ad17ac2897d3333a21
2019-11-23 19:02:50 -05:00
John Sully
417388bd7a
Remove pending async writes if we're freeing the client
...
Former-commit-id: 8b5caad51136f1ed29a9e4c01ed984f6e7ff9c4c
2019-11-23 19:01:40 -05:00
John Sully
df6d8170ae
Add support for removing pending writes for clients we're about to free
...
Former-commit-id: 67c1fd322e1a12b1b22707d67713d60c97c34cef
2019-11-23 19:00:27 -05:00
John Sully
252db8939b
Add support for nested snapshots
...
Former-commit-id: 43456c7807152062d59b2a90597b6204f637f5cd
2019-11-22 20:53:36 -05:00
antirez
ef5186d920
config.c: remove trailing spaces, trim comments to 80 cols.
2019-11-22 17:54:22 +01:00
Salvatore Sanfilippo
a5e4c95cfd
Merge pull request #6607 from madolson/dev-unstable-new-refactor
...
Refactored configs into types that can be generic
2019-11-22 17:42:42 +01:00
zhaozhao.zz
6b056d29f3
block: propagate BRPOPLPUSH as RPOPLPUSH when unblock
2019-11-22 16:38:49 +08:00
zhaozhao.zz
2c970532dc
Propagation: flag module client as CLIENT_MULTI if needed
...
in case of nested MULTI/EXEC
2019-11-22 16:20:30 +08:00
zhaozhao.zz
c73d70fb46
Propagation: propagate EXEC directly in lua script
2019-11-22 15:45:21 +08:00
zhaozhao.zz
37a10cef02
Propagation: wrap commands in also_propagate array with MULIT/EXEC
...
Random command like SPOP with count is replicated as
some SREM operations, and store them in also_propagate
array to propagate after the call, but this would break
atomicity.
To keep the command's atomicity, wrap also_propagate
array with MULTI/EXEC.
2019-11-22 15:42:49 +08:00
Madelyn Olson
e8f4010e27
Changed a tab to a space
2019-11-22 06:44:12 +00:00
Madelyn Olson
d50ae36e17
Fixed a bug with enum log printing
2019-11-22 06:28:50 +00:00
Madelyn Olson
818a4e0f70
Fixed some linux warnings
2019-11-22 05:49:52 +00:00
Madelyn Olson
519822bcf9
Added a flag for strings that are stored as NULL
2019-11-21 21:31:53 -08:00
zhaozhao.zz
73841e8c49
scripting: a little refactor about EVAL and redis.call()
...
Change server.lua_client's flag in a more explicit way.
2019-11-22 11:58:03 +08:00
zhaozhao.zz
097c4a6536
scripting: flag lua_client as CLIENT_MULTI after redis.replicate_commands() immediately
...
To avoid nested MULTI/EXEC, we check the lua_caller's flag,
if we are in the MULTI context we flag the lua_client as
CLIENT_MULTI, but it's not enough we shoud flag lua_client
as CLIENT_MULTI after redis.replicate_commands() immediately
or the first write command after redis.replicate_commands()
cannot know it's in an transaction, I know the missing CLIENT_MULTI
doesn't have any effect now, but it's a real bug and we should fix
it, in case someday we allow some dangerous command like BLPOP.
2019-11-22 11:51:18 +08:00
John Sully
fbc7821244
Fix crash when client running async keys disconnects before keys finishes
...
Former-commit-id: dd9233c49d82c89a9d92b7251a56f91c2ee98e77
2019-11-21 20:40:58 -05:00
John Sully
5e692ff15a
Merge branch 'unstable' into advanced_db
...
Former-commit-id: 00ad497fb3f409dbfcaa62fa9ea5d793263eb13d
2019-11-21 20:21:48 -05:00
John Sully
774cebc4db
Bump version
...
Former-commit-id: 7dd53182e071641ff32813e5ba4b0e3fabe72abc
2019-11-21 20:16:42 -05:00
John Sully
db872b2895
Merge branch 'unstable' into RELEASE_5
...
Former-commit-id: 53b95d830ae7d62ec0a9083a59c8eca1ce2bff69
2019-11-21 20:16:23 -05:00
John Sully
3668715ba3
Fix issue #83
...
Former-commit-id: 3028a890ef11cd99b2c7538de0f480d2466eb150
2019-11-21 20:05:16 -05:00
Salvatore Sanfilippo
b93945585a
Merge pull request #6530 from oranagra/rm_get_server_info
...
Add module api for looking into INFO fields
2019-11-21 10:07:23 +01:00
Salvatore Sanfilippo
64c2508ee3
Merge branch 'unstable' into rm_get_server_info
2019-11-21 10:06:15 +01:00
Salvatore Sanfilippo
f1f259de5b
Merge pull request #6547 from guybe7/module_api_streams
...
Support streams in general module API functions
2019-11-21 10:03:50 +01:00
antirez
da47d52c79
Recomment PR #6346 .
2019-11-21 10:01:49 +01:00
Salvatore Sanfilippo
fef1e63c70
Merge pull request #6346 from MeirShpilraien/expose_zmalloc_capabilities
...
Expose used memory to modules via redismodule api
2019-11-21 09:58:11 +01:00
Salvatore Sanfilippo
70469b76d6
Merge branch 'unstable' into expose_zmalloc_capabilities
2019-11-21 09:57:19 +01:00
Daniel Dai
bfd8c1fdd2
macro fix
...
macro fix
2019-11-20 20:39:04 -05:00
John Sully
88dcedc6e9
Add missing dependency to dockerfile
...
Former-commit-id: 39c6fbddb1dc6738c3ea7cbc2bd5d5bc7fb46ccf
2019-11-20 20:35:14 -05:00
John Sully
338d172733
Merge branch 'unstable' of https://github.com/JohnSully/KeyDB into unstable
...
Former-commit-id: 704cb4e9295800009ba4e918391e37d975e4e424
2019-11-20 19:44:43 -05:00
John Sully
633b7398e1
Fix issue #107 , active replicas do their own expires
...
Former-commit-id: 8e4f323439df29a5e8c0de9db7a848291721fd07
2019-11-20 19:44:31 -05:00
John Sully
f136492c45
Additional asserts ensuring the client is creating on the correct thread
...
Former-commit-id: 937702ea1dd0a4331dd7c66ee9f5c2c3f2354d10
2019-11-20 17:00:40 -05:00
John Sully
852206db90
Update issue templates
...
Former-commit-id: 3ea56ffb38efd4fbfbb096481668be69cc61b15f
2019-11-20 16:25:33 -05:00
John Sully
465b35ec52
Update issue templates
...
Former-commit-id: becd3fc5a34d9c7d665531290c017f13d1b03c16
2019-11-20 16:24:23 -05:00
Maxim Ivanov
c7b68d10ea
Prune leftover TODO comment
...
Is it sufficient... ? -- Yes it is. In standalone mode, we say READY=1
at the comment point; however in replicated mode, we delay sending
READY=1 until the replication sync completes.
2019-11-20 19:45:25 +02:00
Madelyn Olson
803d765d49
Refactored renaming types in config
2019-11-20 09:22:38 -08:00
Salvatore Sanfilippo
c697edf4f4
Merge pull request #6559 from oranagra/active_defrag_tunables
...
Adjustments for active defrag defaults
2019-11-20 10:08:08 +01:00
Salvatore Sanfilippo
808394b77d
Merge pull request #6603 from daidaotong/typofix
...
fix typo in scripting.acl
2019-11-20 10:06:33 +01:00