Dvir Volk
4991298fb0
Fix indentation and comment style in testmodule
2018-02-14 21:43:06 +02:00
Dvir Volk
f27a64232e
Use one static client for all keyspace notification callbacks
2018-02-14 21:40:10 +02:00
Dvir Volk
fbd0514a1f
Use one static client for all keyspace notification callbacks
2018-02-14 21:40:10 +02:00
Dvir Volk
3aab12414f
Remove the NOTIFY_MODULE flag and simplify the module notification flow if there aren't subscribers
2018-02-14 21:40:10 +02:00
Dvir Volk
c54aaca680
Remove the NOTIFY_MODULE flag and simplify the module notification flow if there aren't subscribers
2018-02-14 21:40:10 +02:00
Dvir Volk
a8e2e99a88
Document flags for notifications
2018-02-14 21:38:58 +02:00
Dvir Volk
fa3b63fe82
Document flags for notifications
2018-02-14 21:38:58 +02:00
Dvir Volk
d4d753dae4
removed some trailing whitespaces
2018-02-14 21:38:58 +02:00
Dvir Volk
8e5174caeb
removed some trailing whitespaces
2018-02-14 21:38:58 +02:00
Dvir Volk
5b7b12e38f
removed hellonotify.c
2018-02-14 21:38:58 +02:00
Dvir Volk
fa158da45d
removed hellonotify.c
2018-02-14 21:38:58 +02:00
Dvir Volk
896db12b41
fixed test
2018-02-14 21:38:58 +02:00
Dvir Volk
641fce93e7
fixed test
2018-02-14 21:38:58 +02:00
Dvir Volk
2136035e47
finished implementation of notifications. Tests unfinished
2018-02-14 21:38:58 +02:00
Dvir Volk
053941b983
finished implementation of notifications. Tests unfinished
2018-02-14 21:38:58 +02:00
Salvatore Sanfilippo
4f2d279dd7
Merge pull request #4685 from charsyam/refactoring/set_max_latency
...
Removing duplicated code to set max latency
2018-02-13 16:20:32 +01:00
Salvatore Sanfilippo
ca9192e2fa
Merge pull request #4685 from charsyam/refactoring/set_max_latency
...
Removing duplicated code to set max latency
2018-02-13 16:20:32 +01:00
charsyam
9d41436115
getting rid of duplicated code
2018-02-14 00:12:13 +09:00
charsyam
a7bb8bb27c
getting rid of duplicated code
2018-02-14 00:12:13 +09:00
antirez
ae29bcd8e2
More verbose logging when slave sends errors to master.
...
See #3832 .
2018-02-13 16:01:31 +01:00
antirez
bc0c7045f4
More verbose logging when slave sends errors to master.
...
See #3832 .
2018-02-13 16:01:31 +01:00
Salvatore Sanfilippo
756df19134
Merge pull request #3832 from oranagra/slave_reply_to_master_pr
...
when a slave responds with an error on commands that come from master, log it
2018-02-13 15:55:26 +01:00
Salvatore Sanfilippo
1296894d25
Merge pull request #3832 from oranagra/slave_reply_to_master_pr
...
when a slave responds with an error on commands that come from master, log it
2018-02-13 15:55:26 +01:00
Salvatore Sanfilippo
f9e6c2046f
Merge pull request #3745 from guybe7/unstable
...
enlarged buffer given to ld2string
2018-02-13 15:50:21 +01:00
Salvatore Sanfilippo
028efd8242
Merge pull request #3745 from guybe7/unstable
...
enlarged buffer given to ld2string
2018-02-13 15:50:21 +01:00
antirez
c14ba46e3a
Make it explicit with a comment why we kill the old AOF rewrite.
...
See #3858 .
2018-02-13 15:43:34 +01:00
antirez
d4f1cbbd3a
Make it explicit with a comment why we kill the old AOF rewrite.
...
See #3858 .
2018-02-13 15:43:34 +01:00
Guy Benoish
f782006782
rewriteAppendOnlyFileBackground() failure fix
...
It is possible to do BGREWRITEAOF even if appendonly=no. This is by design.
stopAppendonly() didn't turn off aof_rewrite_scheduled (it can be turned on
again by BGREWRITEAOF even while appendonly is off anyway).
After configuring `appendonly yes` it will see that the state is AOF_OFF,
there's no RDB fork, so it will do rewriteAppendOnlyFileBackground() which
will fail since the aof_child_pid is set (was scheduled and started by cron).
Solution:
stopAppendonly() will turn off the schedule flag (regardless of who asked for it).
startAppendonly() will terminate any existing fork and start a new one (so it is the most recent).
2018-02-13 15:41:06 +01:00
Guy Benoish
cfa0d361b7
rewriteAppendOnlyFileBackground() failure fix
...
It is possible to do BGREWRITEAOF even if appendonly=no. This is by design.
stopAppendonly() didn't turn off aof_rewrite_scheduled (it can be turned on
again by BGREWRITEAOF even while appendonly is off anyway).
After configuring `appendonly yes` it will see that the state is AOF_OFF,
there's no RDB fork, so it will do rewriteAppendOnlyFileBackground() which
will fail since the aof_child_pid is set (was scheduled and started by cron).
Solution:
stopAppendonly() will turn off the schedule flag (regardless of who asked for it).
startAppendonly() will terminate any existing fork and start a new one (so it is the most recent).
2018-02-13 15:41:06 +01:00
Salvatore Sanfilippo
480d4af1e7
Merge pull request #4684 from oranagra/latency_monitor_max
...
fix to latency monitor reporting wrong max latency
2018-02-13 15:31:11 +01:00
Salvatore Sanfilippo
3ff53a8228
Merge pull request #4684 from oranagra/latency_monitor_max
...
fix to latency monitor reporting wrong max latency
2018-02-13 15:31:11 +01:00
Oran Agra
8e8d957ff8
fix to latency monitor reporting wrong max latency
...
in some cases LATENCY HISTORY reported latency that was
higher than the max latency reported by LATENCY LATEST / DOCTOR
2018-02-13 15:58:40 +02:00
Oran Agra
a151e92947
fix to latency monitor reporting wrong max latency
...
in some cases LATENCY HISTORY reported latency that was
higher than the max latency reported by LATENCY LATEST / DOCTOR
2018-02-13 15:58:40 +02:00
赵磊
aacecbc997
Remove updateLFU() in dbOverwrite().
2018-02-11 21:02:07 +08:00
赵磊
04a3125f02
Remove updateLFU() in dbOverwrite().
2018-02-11 21:02:07 +08:00
antirez
32ac4c64ba
Rax updated to latest antirez/rax commit.
2018-02-02 11:10:18 +01:00
antirez
0b58392719
Rax updated to latest antirez/rax commit.
2018-02-02 11:10:18 +01:00
zhaozhao.zz
968cb26693
config: handle special configuration "" for auth
2018-01-26 22:49:39 +08:00
zhaozhao.zz
59eb641bdf
config: handle special configuration "" for auth
2018-01-26 22:49:39 +08:00
Salvatore Sanfilippo
4aa2ecd98b
Merge pull request #4269 from jianqingdu/unstable
...
fix not call va_end() when syncWrite() failed
2018-01-24 10:55:25 +01:00
Salvatore Sanfilippo
6314165e4d
Merge pull request #4269 from jianqingdu/unstable
...
fix not call va_end() when syncWrite() failed
2018-01-24 10:55:25 +01:00
Salvatore Sanfilippo
4bffeda8b0
Merge pull request #4628 from mnunberg/patch-1
...
redismodule.h: Check ModuleNameBusy before calling it
2018-01-24 10:48:04 +01:00
Salvatore Sanfilippo
7c41737e39
Merge pull request #4628 from mnunberg/patch-1
...
redismodule.h: Check ModuleNameBusy before calling it
2018-01-24 10:48:04 +01:00
antirez
5f5be1ee33
Fix integration test NOREPLICAS error time dependent false positive.
2018-01-24 10:10:48 +01:00
antirez
a8d678d26d
Fix integration test NOREPLICAS error time dependent false positive.
2018-01-24 10:10:48 +01:00
Mark Nunberg
062bd733da
redismodule.h: Check ModuleNameBusy before calling it
...
Older versions might not have this function.
2018-01-23 10:49:18 -05:00
Mark Nunberg
eb80bec044
redismodule.h: Check ModuleNameBusy before calling it
...
Older versions might not have this function.
2018-01-23 10:49:18 -05:00
antirez
727dd43614
Fix migrateCommand() access of not initialized byte.
2018-01-18 12:41:05 +01:00
antirez
bca90f9ef7
Fix migrateCommand() access of not initialized byte.
2018-01-18 12:41:05 +01:00
Guy Benoish
fd8efb7c36
Replication buffer fills up on high rate traffic.
...
When feeding the master with a high rate traffic the the slave's feed is much slower.
This causes the replication buffer to grow (indefinitely) which leads to slave disconnection.
The problem is that writeToClient() decides to stop writing after NET_MAX_WRITES_PER_EVENT
writes (In order to be fair to clients).
We should ignore this when the client is a slave.
It's better if clients wait longer, the alternative is that the slave has no chance to stay in
sync in this situation.
2018-01-18 12:10:48 +01:00