antirez
22829267ec
Remove useless conditional from emptyDb().
...
Related to #4852 .
2018-07-25 16:34:57 +02:00
antirez
945d779d12
Make emptyDb() change introduced in #4852 simpler to read.
2018-07-25 16:32:52 +02:00
Salvatore Sanfilippo
0e993a1d7c
Merge pull request #4852 from soloestoy/optimize-flushall
...
optimize flushdb, avoid useless loops
2018-07-25 16:30:11 +02:00
zhaozhao.zz
31d005a3e4
optimize flushdb, avoid useless loops
2018-07-25 18:13:34 +08:00
Salvatore Sanfilippo
da378a1d07
Merge pull request #5133 from soloestoy/fix-xdel-memory-leak
...
Streams: fix xdel memory leak
2018-07-24 18:57:05 +02:00
zhaozhao.zz
372f424399
Streams: fix xdel memory leak
2018-07-25 00:06:27 +08:00
antirez
f9adc44920
Example the magic +1 in migrateCommand().
...
Related to #5154 .
2018-07-24 17:31:43 +02:00
antirez
94f4c11942
Make changes of PR #5154 hopefully simpler.
2018-07-24 17:27:43 +02:00
Salvatore Sanfilippo
27eb7f27be
Merge pull request #5154 from trevor211/optimizeMigrate
...
Do not migrate already expired keys.
2018-07-24 17:24:37 +02:00
antirez
88ec961edf
Streams: refactoring of next entry seek in the iterator.
...
After #5161 the code could be made a bit more obvious for newcomers.
2018-07-24 11:07:27 +02:00
Salvatore Sanfilippo
a4e994c039
Merge pull request #5161 from soloestoy/optimize-stream-iterator
...
Streams: skip master fileds only when we are going forward in streamIteratorGetID
2018-07-24 10:59:55 +02:00
Salvatore Sanfilippo
bbdb152b2c
Merge pull request #5163 from oranagra/fix_slave_buffer_test
...
fix slave buffer test suite false positives
2018-07-24 10:28:48 +02:00
antirez
ae0232d276
string2ll(): better commenting.
2018-07-24 10:27:20 +02:00
Oran Agra
c5058ebee1
fix slave buffer test suite false positives
...
it looks like on slow machines we're getting:
[err]: slave buffer are counted correctly in tests/unit/maxmemory.tcl
Expected condition '$slave_buf > 2*1024*1024' to be true (16914 > 2*1024*1024)
this is a result of the slave waking up too early and eating the
slave buffer before the traffic and the test ends.
2018-07-24 11:24:27 +03:00
antirez
6d54904951
Merge branch 'removeRedundantCheck' of https://github.com/dsomeshwar/redis into unstable
2018-07-24 10:24:24 +02:00
antirez
8aa5ed1e03
Restore string2ll() to original version.
...
See PR #5157 .
2018-07-24 10:22:12 +02:00
antirez
97b08f5483
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-07-24 00:21:49 +02:00
antirez
54bbc283b1
string2ll(): remove duplicated check for special case.
...
Related to #5157 . The PR author correctly indentified that the check was
duplicated, but removing the second one introduces a bug that was fixed
in the past (hence the duplication). Instead we can remove the first
instance of the check without issues.
2018-07-24 00:20:20 +02:00
antirez
510c2045d9
string2ll(): test for NULL pointer in all the cases.
2018-07-24 00:18:39 +02:00
Salvatore Sanfilippo
6264e81b85
Merge pull request #5160 from oranagra/fix_zmalloc_usable
...
fix recursion typo in zmalloc_usable
2018-07-24 00:07:59 +02:00
antirez
1ecfe03852
Change 42 to 1000 as warning level for cached scripts.
...
Related to #4883 .
2018-07-23 18:44:58 +02:00
Salvatore Sanfilippo
a5f07a06f4
Merge pull request #4883 from itamarhaber/lua_scripts-in-info-memory
...
Adds memory information about the scripts' cache to INFO
2018-07-23 18:43:05 +02:00
antirez
3d32af7ec6
Dynamic HZ: adapt cron frequency to number of clients.
2018-07-23 14:21:04 +02:00
antirez
6bfbad38af
Dynamic HZ: separate hz from the configured hz.
...
This way we can remember what the user configured HZ is, but change the
actual HZ dynamically if needed in the dynamic HZ feature
implementation.
2018-07-23 14:13:58 +02:00
Itamar Haber
527786c0f3
Adds Lua overheads to MEMORY STATS, smartens the MEMORY DOCTOR
2018-07-22 21:16:00 +03:00
zhaozhao.zz
8e01dbe90b
Streams: skip master fileds only when we are going forward in streamIteratorGetID
2018-07-22 17:52:09 +08:00
Oran Agra
359705c08d
fix recursion typo in zmalloc_usable
2018-07-22 10:17:35 +03:00
dsomeshwar
af41c94526
removing redundant check
2018-07-21 23:42:08 +05:30
WuYunlong
89de21d6a6
Do not migrate already expired keys.
2018-07-21 10:00:32 +08:00
WuYunlong
ea2a56acf5
Consider aof write error as well as rdb in lua script.
2018-07-21 08:48:51 +08:00
antirez
ebce3647df
Top comment clientsCron().
2018-07-20 09:46:18 +02:00
antirez
ee9b50b0cb
Clarify that clientsCronTrackExpansiveClients() indexes may jump ahead.
2018-07-20 09:36:48 +02:00
antirez
502fe74232
Rename INFO CLIENT max buffers field names for correctness.
...
They are actually delayed a few seconds, so let's call them "recent".
2018-07-19 17:38:20 +02:00
antirez
e42fe2628e
Fix wrong array index variable in getExpansiveClientsInfo().
2018-07-19 17:34:15 +02:00
antirez
28557ee271
Change INFO CLIENTS sections to report pre-computed max/min client buffers.
2018-07-19 17:16:19 +02:00
dejun.xdj
950bff839f
Streams: ID of xclaim command starts from the sixth argument.
2018-07-19 20:48:08 +08:00
antirez
b3d4d162b3
Rename var in clientsCronTrackExpansiveClients() for clarity.
2018-07-19 13:59:13 +02:00
antirez
2373eaccf1
Implement a function to retrieve the expansive clients mem usage.
2018-07-19 13:58:04 +02:00
antirez
9c87d5cabe
clientsCronTrackExpansiveClients() actual implementation.
2018-07-19 13:54:20 +02:00
antirez
363edba137
clientsCronTrackExpansiveClients() skeleton and ideas.
2018-07-19 13:49:00 +02:00
antirez
7401f4b7cf
Make vars used only by INFO CLIENTS local to the block.
...
Related to #4727 .
2018-07-19 12:23:05 +02:00
Salvatore Sanfilippo
8b638d90be
Merge pull request #4727 from kingpeterpaule/redis-fix-info-cli
...
move getClientsMaxBuffers func into info clients command
2018-07-19 12:21:35 +02:00
antirez
be0266ab8d
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-07-18 17:41:37 +02:00
antirez
8f94829fa3
In addReplyErrorLength() only panic when replying to slave.
...
See #5135 for more context.
2018-07-18 17:41:16 +02:00
antirez
84d17a5f72
Refine comment in addReplyErrorLength() about replying to masters/slaves.
...
See #5135 for some context.
2018-07-18 17:40:07 +02:00
Salvatore Sanfilippo
4ff114bcfa
Merge pull request #5138 from oranagra/improve_defrag_test
...
make active defrag test more stable
2018-07-18 11:05:03 +02:00
Oran Agra
0a4d1f114e
make active defrag test more stable
...
on slower machines, the active defrag test tended to fail.
although the fragmentation ratio was below the treshold, the defragger was
still in the middle of a scan cycle.
this commit changes:
- the defragger uses the current fragmentation state, rather than the cache one
that is updated by server cron every 100ms. this actually fixes a bug of
starting one excess scan cycle
- the test lets the defragger use more CPU cycles, in hope that the defrag
will be faster, but also give it more time before we give up.
2018-07-18 10:16:33 +03:00
Salvatore Sanfilippo
7050029b5d
Merge pull request #5122 from trevor211/allowWritesWhenAofDisabled
...
Accept write commands if persisting is disabled
2018-07-17 18:08:46 +02:00
Salvatore Sanfilippo
b8d6bdf224
Merge pull request #4237 from aspirewit/update-comment
...
Update the comment
2018-07-17 18:04:55 +02:00
antirez
cc69607936
Streams: better error when $ is given with XREADGROUP.
2018-07-17 17:54:10 +02:00