antirez
00e5fefe6d
Fix ip and missing mode in RM_GetClusterNodeInfo().
2019-12-29 15:46:31 +01:00
antirez
c0d6c9a0c1
Fix duplicated CLIENT SETNAME reply.
...
Happened when we set the name to "" to cancel the name.
Was introduced during the RESP3 refactoring.
See #6036 .
2019-12-29 15:44:59 +01:00
antirez
6e4f70b817
Fix duplicated CLIENT SETNAME reply.
...
Happened when we set the name to "" to cancel the name.
Was introduced during the RESP3 refactoring.
See #6036 .
2019-12-29 15:44:59 +01:00
antirez
6c1b4b3905
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2019-12-29 15:42:08 +01:00
antirez
faea46710c
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2019-12-29 15:42:08 +01:00
antirez
2746213038
Inline protocol: handle empty strings well.
...
This bug is from the first version of Redis. Probably the problem here
is that before we used an SDS split function that created empty strings
for additional spaces, like in "SET foo bar".
AFAIK later we replaced it with the curretn sdssplitarg() API that has
no such a problem. As a result, we introduced a bug, where it is no
longer possible to do something like:
SET foo ""
Using the inline protocol. Now it is fixed.
2019-12-29 15:40:40 +01:00
antirez
5521910de7
Inline protocol: handle empty strings well.
...
This bug is from the first version of Redis. Probably the problem here
is that before we used an SDS split function that created empty strings
for additional spaces, like in "SET foo bar".
AFAIK later we replaced it with the curretn sdssplitarg() API that has
no such a problem. As a result, we introduced a bug, where it is no
longer possible to do something like:
SET foo ""
Using the inline protocol. Now it is fixed.
2019-12-29 15:40:40 +01:00
Salvatore Sanfilippo
1eb8950f6a
Merge pull request #6706 from guybe7/stream_id_edge_cases
...
Stream: Handle streamID-related edge cases
2019-12-29 14:53:06 +01:00
Salvatore Sanfilippo
3ff95d9074
Merge pull request #6706 from guybe7/stream_id_edge_cases
...
Stream: Handle streamID-related edge cases
2019-12-29 14:53:06 +01:00
Salvatore Sanfilippo
676089e602
Merge pull request #6707 from oranagra/fix_config_limits
...
config.c adjust config limits and mutable
2019-12-29 14:51:40 +01:00
Salvatore Sanfilippo
1bae5dfff6
Merge pull request #6707 from oranagra/fix_config_limits
...
config.c adjust config limits and mutable
2019-12-29 14:51:40 +01:00
John Sully
bbbe030e78
Merge branch 'unstable' into keydbpro
...
Former-commit-id: 7ddcbb8ec0c842bd4a79b6e14ebd33616174e793
2019-12-27 18:17:36 -05:00
John Sully
f5b428d6e1
Merge branch 'unstable' into keydbpro
...
Former-commit-id: 7ddcbb8ec0c842bd4a79b6e14ebd33616174e793
2019-12-27 18:17:36 -05:00
John Sully
55cddbe82f
Fix some static analysis warnings
...
Former-commit-id: 42a8f22c21706f9ddcaa63ceafc5ad817c1fe876
2019-12-27 18:17:22 -05:00
John Sully
da17594170
Fix some static analysis warnings
...
Former-commit-id: 42a8f22c21706f9ddcaa63ceafc5ad817c1fe876
2019-12-27 18:17:22 -05:00
John Sully
55361c65d8
Merge branch 'keydbpro' of https://github.com/JohnSully/KeyDB-Pro into keydbpro
...
Former-commit-id: b52725163ec6ea128102880be33c43437693cc9e
2019-12-27 17:46:51 -05:00
John Sully
68bc33820d
Merge branch 'keydbpro' of https://github.com/JohnSully/KeyDB-Pro into keydbpro
...
Former-commit-id: b52725163ec6ea128102880be33c43437693cc9e
2019-12-27 17:46:51 -05:00
John Sully
df3b99bf62
Ignore dependency files
...
Former-commit-id: f18d973adcf38483400edac85e9258c37aa4e8e5
2019-12-27 17:46:16 -05:00
John Sully
18f4a4a019
Ignore dependency files
...
Former-commit-id: f18d973adcf38483400edac85e9258c37aa4e8e5
2019-12-27 17:46:16 -05:00
John Sully
8f20fc7f33
Ignore dependency files
...
Former-commit-id: 6e06e0dfc7cd572d93cce99c4b8b8b0b59e95e60
2019-12-27 17:45:56 -05:00
John Sully
badb709a8f
Ignore dependency files
...
Former-commit-id: 6e06e0dfc7cd572d93cce99c4b8b8b0b59e95e60
2019-12-27 17:45:56 -05:00
John Sully
0fd9a4c67a
Merge keydb community
...
Former-commit-id: b9dcd0997c3dfd3cd2a5908ba540bc4d389104a0
2019-12-27 17:44:48 -05:00
John Sully
5dda897950
Merge keydb community
...
Former-commit-id: b9dcd0997c3dfd3cd2a5908ba540bc4d389104a0
2019-12-27 17:44:48 -05:00
John Sully
082e493d32
Make incremental building work with header files
...
Former-commit-id: bf500ab44b82e9a3ad7f341b7d2f7f583fdf336f
2019-12-27 17:34:41 -05:00
John Sully
6d52647e57
Make incremental building work with header files
...
Former-commit-id: bf500ab44b82e9a3ad7f341b7d2f7f583fdf336f
2019-12-27 17:34:41 -05:00
Oran Agra
f10051c5fd
config.c adjust config limits and mutable
...
- make lua-replicate-commands mutable (it never was, but i don't see why)
- make tcp-backlog immutable (fix a recent refactory mistake)
- increase the max limit of a few configs to match what they were before
the recent refactory
2019-12-26 15:16:15 +02:00
Oran Agra
0c3fe52ef7
config.c adjust config limits and mutable
...
- make lua-replicate-commands mutable (it never was, but i don't see why)
- make tcp-backlog immutable (fix a recent refactory mistake)
- increase the max limit of a few configs to match what they were before
the recent refactory
2019-12-26 15:16:15 +02:00
Guy Benoish
6731e0dab5
Stream: Handle streamID-related edge cases
...
This commit solves several edge cases that are related to
exhausting the streamID limits: We should correctly calculate
the succeeding streamID instead of blindly incrementing 'seq'
This affects both XREAD and XADD.
Other (unrelated) changes:
Reply with a better error message when trying to add an entry
to a stream that has exhausted last_id
2019-12-26 15:31:37 +05:30
Guy Benoish
1f75ce30df
Stream: Handle streamID-related edge cases
...
This commit solves several edge cases that are related to
exhausting the streamID limits: We should correctly calculate
the succeeding streamID instead of blindly incrementing 'seq'
This affects both XREAD and XADD.
Other (unrelated) changes:
Reply with a better error message when trying to add an entry
to a stream that has exhausted last_id
2019-12-26 15:31:37 +05:30
John Sully
bb6aa59883
recommended rocksdb tuning
...
Former-commit-id: 2a634365f901968f9758d2d362f211b8e0fddc2a
2019-12-24 02:22:47 -05:00
John Sully
5c657aefcb
recommended rocksdb tuning
...
Former-commit-id: 2a634365f901968f9758d2d362f211b8e0fddc2a
2019-12-24 02:22:47 -05:00
John Sully
098684bf8e
Track key count accurately before we've committed to the database. Also use this to optimize DB lookups when all keys are in memory
...
Former-commit-id: 78c07f0276109a085761b7044d4edc63af26d3da
2019-12-24 00:03:38 -05:00
John Sully
fb2d81395d
Track key count accurately before we've committed to the database. Also use this to optimize DB lookups when all keys are in memory
...
Former-commit-id: 78c07f0276109a085761b7044d4edc63af26d3da
2019-12-24 00:03:38 -05:00
John Sully
7da74195a8
Perf remove extra lookup in rocksdb
...
Former-commit-id: 8074472c7a25572a53f1166911920c2cb168c141
2019-12-23 23:32:04 -05:00
John Sully
2f46f18c35
Perf remove extra lookup in rocksdb
...
Former-commit-id: 8074472c7a25572a53f1166911920c2cb168c141
2019-12-23 23:32:04 -05:00
John Sully
cded9874a0
More testing
...
Former-commit-id: 564d94f0653315ce05495a8d83ff8577a365c11b
2019-12-23 22:14:43 -05:00
John Sully
3d265fc3df
More testing
...
Former-commit-id: 564d94f0653315ce05495a8d83ff8577a365c11b
2019-12-23 22:14:43 -05:00
John Sully
054bbe9baa
Fix issue where database size is off when setting key with expire
...
Former-commit-id: 7796918bfb4a98bc056b3b8f4065f1416da8d89a
2019-12-23 22:07:33 -05:00
John Sully
f8c903475a
Fix issue where database size is off when setting key with expire
...
Former-commit-id: 7796918bfb4a98bc056b3b8f4065f1416da8d89a
2019-12-23 22:07:33 -05:00
John Sully
ef62b9b14c
Add missing files
...
Former-commit-id: 4eadf8f0923ee70ffa3af329a4d636d508bfad8d
2019-12-23 19:07:53 -05:00
John Sully
0ab5ea7b9b
Add missing files
...
Former-commit-id: 4eadf8f0923ee70ffa3af329a4d636d508bfad8d
2019-12-23 19:07:53 -05:00
John Sully
4fd552d8b6
Add more test code, and fix bugs uncovered
...
Former-commit-id: 5362fa4b62f89cbc1e92e01c73a45c4e3718708b
2019-12-23 17:17:41 -05:00
John Sully
94ea48978d
Add more test code, and fix bugs uncovered
...
Former-commit-id: 5362fa4b62f89cbc1e92e01c73a45c4e3718708b
2019-12-23 17:17:41 -05:00
Yossi Gottlieb
7ca3d5db5f
Add REDISMODULE_CTX_FLAGS_MULTI_DIRTY.
2019-12-23 19:43:51 +02:00
Yossi Gottlieb
0c898bdb07
Add REDISMODULE_CTX_FLAGS_MULTI_DIRTY.
2019-12-23 19:43:51 +02:00
Oran Agra
5cc62cc219
modules don't signalModifiedKey in setKey() since that's done (optionally) in RM_CloseKey
2019-12-23 10:15:52 +02:00
Oran Agra
660645c742
modules don't signalModifiedKey in setKey() since that's done (optionally) in RM_CloseKey
2019-12-23 10:15:52 +02:00
John Sully
bd4d372d45
Key count is innacurate after overwrite
...
Former-commit-id: 180c5a8e401415cede36548ab8d01f3e4ff8fb7f
2019-12-22 19:41:36 -05:00
John Sully
033eda6016
Key count is innacurate after overwrite
...
Former-commit-id: 180c5a8e401415cede36548ab8d01f3e4ff8fb7f
2019-12-22 19:41:36 -05:00
John Sully
59f7bd49c9
Add additional tests
...
Former-commit-id: e7d2c78e776b8262fd54caeb7b6bd210182e9bdb
2019-12-22 19:16:30 -05:00