John Sully
1d0036882c
Fix: Active replication falls behind under high load
...
Former-commit-id: 3d0de946bb73a34f96cd773e85c102c2743e6480
2019-05-18 20:23:20 -04:00
Salvatore Sanfilippo
fd0ee469ab
Merge pull request #6100 from chrizel/typo-fixes
...
Typo fixes in CONTRIBUTING
2019-05-15 17:48:40 +02:00
Christian Zeller
7fababd44e
Typo fixes in CONTRIBUTING
2019-05-15 16:10:48 +02:00
antirez
fd9407dfc8
Update CONTRIBUTING with present info.
2019-05-15 12:46:01 +02:00
antirez
074d24df1e
Narrow the effects of PR #6029 to the exact state.
...
CLIENT PAUSE may be used, in other contexts, for a long time making all
the slaves time out. Better for now to be more specific about what
should disable senidng PINGs.
An alternative to that would be to virtually refresh the slave
interactions when clients are paused, however for now I went for this
more conservative solution.
2019-05-15 12:16:43 +02:00
Salvatore Sanfilippo
caf74e507e
Merge pull request #6029 from chendq8/clientpause
...
fix cluster failover time out
2019-05-15 12:03:19 +02:00
antirez
1a1ba48390
Test: fix slowlog test false positive.
...
In fast systems "SLOWLOG RESET" is fast enough to don't be logged even
when the time limit is "1" sometimes. Leading to false positives such
as:
[err]: SLOWLOG - can be disabled in tests/unit/slowlog.tcl
Expected '1' to be equal to '0'
2019-05-14 16:55:52 +02:00
antirez
9724ca4e22
Make comment in getClientOutputBufferMemoryUsage() describing the present.
2019-05-13 17:30:06 +02:00
antirez
4f4676a142
Fix test false positive introduced by threaded I/O.
...
Now clients that are ready to be terminated asynchronously are processed
more often in beforeSleep() instead of being processed in serverCron().
This means that the test will not be able to catch the moment the client
was terminated, also note that the 'omem' figure now changes in big
steps, because of the new client output buffers layout.
So we have to change the test range in order to accomodate for that.
Yet the test is useful enough to be worth taking, even if its precision
is reduced by this commit. Probably if we get more problems, a thing
that makes sense is just to check that the limit is < 200k. That's more
than enough actually.
2019-05-13 17:27:10 +02:00
John Sully
22dc65b35b
Update Active Replication wiki links
...
Former-commit-id: 866b8ead9147e454fe577ec26bb6cf3a502b091f
2019-05-11 21:53:30 -04:00
John Sully
6205dee978
Fix a few issues from the merge
...
Former-commit-id: aa274960fff095c4c3cd570cdbaaabb9ca005651
2019-05-11 19:26:59 -04:00
John Sully
25a904605a
Make lazy free test more reliable
...
Former-commit-id: 54d6eb851bbea48e858d84bca818cb14c65b6403
2019-05-11 17:57:35 -04:00
John Sully
e48c132d35
Merge branch 'unstable' of https://github.com/antirez/redis into MergeRedis
...
Note: some tests failing
Former-commit-id: 86d7276f24f0cf1a0eceb6cd00a6a0ae2a0fa520
2019-05-11 02:20:34 -04:00
John Sully
b9b955044b
Add byline to logo
...
Former-commit-id: 09186514381019ce6d07f5d0d78d19e229b00c84
2019-05-10 23:48:14 -04:00
Salvatore Sanfilippo
e633254ccf
Merge pull request #6053 from soloestoy/enhance-aof-fsync-everysec
...
aof: enhance AOF_FSYNC_EVERYSEC, more details in #5985
2019-05-10 18:06:40 +02:00
Salvatore Sanfilippo
34f6d94701
Merge pull request #6074 from trevor211/fixActiveExpire
...
Do not active expire keys in the background when the switch is off.
2019-05-10 12:39:35 +02:00
Salvatore Sanfilippo
1e9b8d853d
Merge pull request #6080 from soloestoy/fix-makefile
...
Makefile: 1TD -> STD
2019-05-10 12:37:07 +02:00
Salvatore Sanfilippo
2903c56bda
Merge pull request #6073 from yossigo/fix/blocked-client-id
...
Preserve client->id for blocked clients.
2019-05-10 12:32:47 +02:00
Salvatore Sanfilippo
6b490e33c4
Merge pull request #6081 from Happy4Code/mod_comments
...
change the comments there may have a mis type
2019-05-10 12:28:12 +02:00
Salvatore Sanfilippo
891f4a38f6
Merge pull request #6077 from zltl/patch-7
...
delete sdsTest() from REDIS_TEST in server.c to fix build failed
2019-05-10 12:27:47 +02:00
Salvatore Sanfilippo
433f763814
Merge pull request #6083 from tangquanawj/fix-inappropriate-add-operation-code
...
fix-inappropriate-add-operation-code
2019-05-10 12:25:18 +02:00
Salvatore Sanfilippo
402b0d0bd1
Merge pull request #6086 from yongman/fix-uint64-in-defrag
...
Fix uint64_t hash value in active defrag
2019-05-10 12:23:59 +02:00
Salvatore Sanfilippo
19c3d5b743
Merge pull request #6087 from AngusP/linux-build-warnings
...
[Minor] Fix build warnings on Linux
2019-05-10 12:23:42 +02:00
Salvatore Sanfilippo
1212f22858
Merge pull request #6091 from soloestoy/fix-test-skip-till
...
test cases: skiptill -> skip-till
2019-05-10 12:22:19 +02:00
zhaozhao.zz
c64aec9ce7
test cases: skiptill -> skip-till
2019-05-10 16:27:25 +08:00
John Sully
0f2c05adea
Fix CentOS build failure
...
Former-commit-id: 272d9297b6c022abbd4eeef890a0e1f41fc0536d
2019-05-09 19:54:34 -04:00
John Sully
c84ab4a822
Merge branch 'unstable' of https://github.com/JohnSully/redis2 into unstable
...
Former-commit-id: f5bfc71899f607b4a6db9b1c7fa224b1e7a0cb79
2019-05-09 19:16:50 -04:00
John Sully
6e00cc15dd
build break fix
...
Former-commit-id: 42e1ded55fa33f8a45dc0041fd4c6376eab5f0b9
2019-05-09 19:16:31 -04:00
John Sully
4aa0008f7f
Fix issue #11
...
Former-commit-id: 6c410af5a89aa9c11df67e04d1cfbde55aa7fe90
2019-05-09 19:14:10 -04:00
John Sully
403a72e70d
Fix typo
...
Former-commit-id: 57ae67618130fb03a3397bba923627eeb037b645
2019-05-09 19:06:58 -04:00
John Sully
cfd9b5e6ee
Add missing file
...
Former-commit-id: 7896ca6e52b9caa9d8ab78145f16872fe488c4bb
2019-05-09 19:05:09 -04:00
John Sully
d74a109d6e
Change debug messages to reference KeyDB
...
Former-commit-id: c4a315dd5ece321dad02401356d9523e54f91024
2019-05-09 19:03:50 -04:00
John Sully
e69b51a6d4
Fix module locking issues
...
Former-commit-id: bf26959b722285f9b8caedb853e712d5b4ce6b3f
2019-05-09 19:00:27 -04:00
Angus Pearson
a1fb0be1d7
Enlarge error buffer in redis-check-aof.c to remove compiler warning of output truncation through snprintf format string
2019-05-08 12:13:45 +01:00
Angus Pearson
bea09a7fa6
Add <strings.h> include to deps/hiredis/read.c to fix Implicit Declaration of strcasecmp warning
2019-05-08 11:36:31 +01:00
yongman
fb4ee7f0c5
Fix uint64_t hash value in active defrag
2019-05-08 16:29:16 +08:00
唐权
842dd85b26
Update ziplist.c
...
Hi, @antirez
In the code, to get the size of ziplist, "unsigned int bytes = ZIPLIST_HEADER_SIZE+1;" is correct,
but why not make it more readable and easy to understand
2019-05-08 12:53:56 +08:00
Salvatore Sanfilippo
f674e83215
Merge pull request #6082 from soloestoy/fix-config-rewrite-memleak
...
fix memory leak when rewrite config file
2019-05-07 10:25:13 +02:00
zhaozhao.zz
48d591a010
fix memory leak when rewrite config file
2019-05-07 15:59:16 +08:00
stan011
d9d3d3065b
change the comments there may have a mis type
2019-05-07 14:22:40 +08:00
zhaozhao.zz
340a723b87
Makefile: 1TD -> STD
2019-05-07 13:35:27 +08:00
Salvatore Sanfilippo
a72ab70fee
Merge pull request #6070 from oranagra/stabilize_repl_tests
...
make replication tests more stable on slow machines
2019-05-06 18:05:33 +02:00
antirez
3d053dbb6d
Threaded IO: handleClientsWithPendingReadsUsingThreads top comment.
2019-05-06 18:02:51 +02:00
antirez
5baeb14cf3
Threaded IO: configuration directive for turning on/off reads.
2019-05-06 18:02:51 +02:00
antirez
1c0c436757
Threaded IO: ability to disable reads from threaded path.
2019-05-06 18:02:51 +02:00
antirez
90d720e7a5
Threaded IO: put fflush() inside tio_debug conditional.
2019-05-06 18:02:51 +02:00
antirez
6ab6a97fe6
Threaded IO: parsing WIP 2: refactoring to parse from thread.
2019-05-06 18:02:51 +02:00
antirez
647a66ebba
Threaded IO: parsing WIP 1: set current_client in a better scoped way.
2019-05-06 18:02:51 +02:00
antirez
463ccf8664
Threaded IO: logging should be safe in I/O threads.
...
Potentially it is possible that we get interleaved writes, even if
serverLog() makes sure to write into a buffer and then use printf(), so
even this should be ok. However in general POSIX guarantees that writing
to the same file pointer object from multiple threads is safe. Anyway
currently we *reopen* the file at each call, but for the standard output
logging.
The logging functions actually also access global configuration while
performing the log (for instance in order to check the log level, the
log filename and so forth), however dunring the I/O threads execution
we cannot alter such shared state in any way.
2019-05-06 18:02:51 +02:00
antirez
8d7d2be24f
Threaded IO: process read queue before stopping threads.
2019-05-06 18:02:51 +02:00