WuYunlong
85bc26f8da
Fix lua related memory leak.
2020-02-04 16:38:46 +08:00
Salvatore Sanfilippo
a0781a2ce8
Merge pull request #6808 from yossigo/fix/redis-cli-openssl-1.0.x
...
TLS: Fix missing initialization in redis-cli.
2020-02-03 16:43:56 +01:00
Oran Agra
f5d37082ca
fix uninitialized info_cb var in module.c
2020-02-03 16:35:39 +02:00
Guy Benoish
2492bdc90b
Exclude "keymiss" notification from NOTIFY_ALL
...
Because "keymiss" is "special" compared to the rest of
the notifications (Trying not to break existing apps
using the 'A' format for notifications)
Also updated redis.conf and module.c docs
2020-02-03 15:43:44 +05:30
Leo Murillo
0ab1604c0c
Set ZSKIPLIST_MAXLEVEL to optimal value given 2^64 elements and p=0.25
2020-02-02 02:48:00 -06:00
Salvatore Sanfilippo
541a667c77
Merge pull request #6812 from guybe7/str_convert_fix
...
ld2string should fail if string contains \0 in the middle
2020-01-30 17:51:04 +01:00
Guy Benoish
add0229c31
DEBUG OBJECT should pass keyname to module when loading
2020-01-30 19:15:12 +05:30
Guy Benoish
3fd717daee
ld2string should fail if string contains \0 in the middle
...
This bug affected RM_StringToLongDouble and HINCRBYFLOAT.
I added tests for both cases.
Main changes:
1. Fixed string2ld to fail if string contains \0 in the middle
2. Use string2ld in getLongDoubleFromObject - No point of
having duplicated code here
The two changes above broke RM_SaveLongDouble/RM_LoadLongDouble
because the long double string was saved with length+1 (An innocent
mistake, but it's actually a bug - The length passed to
RM_SaveLongDouble should not include the last \0).
2020-01-30 18:15:17 +05:30
antirez
bc168c91ec
ACL LOG: also log ACL errors in the scripting/MULTI ctx.
2020-01-30 10:50:32 +01:00
Yossi Gottlieb
a7420b2478
TLS: Fix missing initialization in redis-cli.
2020-01-29 21:40:02 +02:00
antirez
eef1489240
ACL LOG: implement LOG RESET.
2020-01-29 18:51:04 +01:00
antirez
5bcb4e6905
ACL LOG: group similar entries in a given time delta.
2020-01-29 18:40:32 +01:00
antirez
2ed300b786
Add more info in the unblockClientFromModule() function.
2020-01-29 12:47:50 +01:00
Salvatore Sanfilippo
d0bb1e572f
Merge pull request #6699 from guybe7/module_blocked_on_key_timeout_memleak
...
Modules: Fix blocked-client-related memory leak
2020-01-29 12:06:14 +01:00
antirez
f550dfca47
ACL LOG: actually emit entries.
2020-01-28 18:04:20 +01:00
antirez
99a5b98bf0
ACL LOG: implement ACL LOG subcommadn skeleton.
2020-01-28 17:30:50 +01:00
antirez
800425a319
ACL LOG: data structures and initial functions.
2020-01-27 18:37:52 +01:00
qetu3790
7bd9afe780
Fix not used constant in lru_test_mode.
...
LRU_CYCLE_PERIOD is defined,but not used.
2020-01-23 17:18:07 +08:00
srzhao
f6621280c9
Check OOM at script start to get stable lua OOM state.
...
Checking OOM by `getMaxMemoryState` inside script might get different result
with `freeMemoryIfNeededAndSafe` at script start, because lua stack and
arguments also consume memory.
This leads to memory `borderline` when memory grows near server.maxmemory:
- `freeMemoryIfNeededAndSafe` at script start detects no OOM, no memory freed
- `getMaxMemoryState` inside script detects OOM, script aborted
We solve this 'borderline' issue by saving OOM state at script start to get
stable lua OOM state.
related to issue #6565 and #5250 .
2020-01-20 21:34:05 +08:00
srzhao
90589504cc
fix impl of aof-child whitelist SIGUSR1 feature.
2020-01-17 11:50:51 +08:00
hwware
65cffe587c
format fix
2020-01-16 17:35:26 -05:00
hwware
89f5aaa4d7
fix potentical memory leaks
2020-01-16 17:33:23 -05:00
antirez
c0bdf0eb73
Change error message for #6775 .
2020-01-15 17:55:24 +01:00
Salvatore Sanfilippo
b2ccea5f3c
Merge pull request #6775 from SqREL/make-error-of-invalid-command-withing-context-explicit
...
Make error when submitting command in incorrect context more explicit
2020-01-15 17:53:51 +01:00
Ponnuvel Palaniyappan
9df0a501ee
Fix a potential overflow with strncpy
2020-01-14 08:10:39 +00:00
antirez
aca010264c
Setting N I/O threads should mean N-1 additional + 1 main thread.
2020-01-13 18:53:36 +01:00
antirez
5c5f25a9f9
Simplify #6379 changes.
2020-01-13 13:25:37 +01:00
Salvatore Sanfilippo
520a0a6b75
Merge pull request #6739 from trevor211/fixMemoryLeak
...
Fix potential memory leak of rioWriteBulkStreamID().
2020-01-13 13:23:49 +01:00
antirez
5ac23a2765
Jump to right label on AOF parsing error.
...
Related to #6054 .
2020-01-13 13:16:15 +01:00
antirez
ff9e42365f
Port PR #6110 to new connection object code.
2020-01-13 12:54:39 +01:00
antirez
9d6f439760
A few comments about main thread serving I/O as well.
...
Related to #6110 .
2020-01-13 12:50:26 +01:00
Salvatore Sanfilippo
3875ea7671
Merge pull request #6110 from soloestoy/enhance-io-threaded
...
Enhance IO Threaded: use main thread to handle read/write work
2020-01-13 12:46:40 +01:00
Vasyl Melnychuk
9ea3bfdb8b
Make error when submitting command in incorrect context more explicit
...
So error message `ERR only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context` will become
`ERR 'get' command submitted, but only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context`
2020-01-10 23:34:15 +02:00
antirez
69a4508bee
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2020-01-10 13:15:36 +01:00
Salvatore Sanfilippo
eee3e28cbf
Merge pull request #6114 from ShooterIT/async-rename-rdb
...
Rename rdb when replica finish receiving rdb asynchronously
2020-01-10 13:06:39 +01:00
antirez
b275416746
Free fakeclient argv on AOF error.
...
We exit later, so no bug fixed, but it is more correct.
See #6054 , thanks to @ShooterIT for finding the issue.
2020-01-10 13:02:45 +01:00
Salvatore Sanfilippo
56ce6b00a6
Merge pull request #6746 from leomurillo/unstable
...
Fix bug on KEYS command where pattern starts with * followed by \x00
2020-01-10 12:18:19 +01:00
Salvatore Sanfilippo
7fc6cb4081
Merge pull request #6703 from guybe7/blocking_xread_empty_reply
...
Blocking XREAD[GROUP] should always reply with valid data (or timeout)
2020-01-09 17:32:14 +01:00
Salvatore Sanfilippo
8c0e7f7df7
Merge pull request #6724 from JohnSully/incremental
...
Add support for incremental build with header files
2020-01-09 17:10:02 +01:00
Salvatore Sanfilippo
6c1ce6b565
Merge pull request #6715 from trevor211/fixPotentialClusterLinkError
...
Fix petential cluster link error.
2020-01-09 17:05:54 +01:00
Salvatore Sanfilippo
4021f3d968
Merge pull request #6698 from yossigo/ctx-flags-multi-dirty
...
Add REDISMODULE_CTX_FLAGS_MULTI_DIRTY.
2020-01-08 13:09:48 +01:00
Salvatore Sanfilippo
7956f6fe6c
Merge pull request #6748 from hwware/typofix
...
typo fix in acl.c
2020-01-08 13:06:06 +01:00
Salvatore Sanfilippo
3449828238
Merge pull request #6735 from itamarhaber/io-threads
...
Adjusts 'io_threads_num' max in config.c
2020-01-08 12:50:13 +01:00
Salvatore Sanfilippo
68b2c53f7f
Merge pull request #6743 from yz1509/unstable
...
Sentinel: avoid sentinel changes promoted_slave to be its own replica.
2020-01-08 12:30:49 +01:00
antirez
4573a41249
XCLAIM: Create the consumer only on successful claims.
...
Fixes #6744 .
2020-01-08 10:10:11 +01:00
hwware
2a6a01cbf2
typo fix in acl.c
2020-01-07 21:09:44 -05:00
Leo Murillo
4a1e1a8c24
Fix bug on KEYS command where pattern starts with * followed by \x00 (null char).
2020-01-07 13:55:26 -06:00
WuYunlong
fc9f1b9012
Free allocated sds in pfdebugCommand() to avoid memory leak.
2020-01-07 11:17:52 +08:00
yz1509
a127e0cc7d
avoid sentinel changes promoted_slave to be its own replica.
2020-01-07 10:29:54 +08:00
WuYunlong
e2b8c9280b
Fix potential memory leak of clusterLoadConfig().
2020-01-07 10:28:36 +08:00