gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
9,187 Commits 1 Branch 0 Tags
Commit Graph

9187 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
swilly22
29827d37a5 Introduce ReplyWithVerbatimString, ReplyWithEmptyArray, ReplyWithNullArray and ReplyWithEmptyString to redis module API 2019-10-28 08:50:25 +02:00
zhaozhao.zz
18c4ccf898 Modules: make unloading module more safe 
As we know if a module exports module-side data types,
unload it is not allowed. This rule is the same with
blocked clients in module, because we use background
threads to implement module blocked clients, and it's
not safe to unload a module if there are background
threads running. So it's necessary to check if any
blocked clients running in this module when unload it.

Moreover, after that we can ensure that if no modules,
then no module blocked clients even module unloaded.
So, we can call moduleHandleBlockedClients only when
we have installed modules.
 2019-10-28 11:31:58 +08:00
Carsten Strotmann
f12c08d921 Typo fix: kill -> still 2019-10-25 19:38:45 +02:00
happynote3966
fd5c1adbd7 fix comment typo in redis-cli.c 2019-10-25 22:31:55 +09:00
Wander Hillen
3ca35b8024 Merge branch 'unstable' into minor-typos 2019-10-25 10:18:26 +02:00
John Sully
a55fe8a3ba Fix potential race in pubsub 
Former-commit-id: 427c5999f167256dc3a6a0f49ad28313f700a155
 2019-10-25 02:50:30 -04:00
John Sully
949270801e Signals can happen on any thread, so look for the signal handler not the command on the callstack 
Former-commit-id: f1d2b2945007f8811528b197480e255c6b35559c
 2019-10-24 23:30:08 -04:00
John Sully
70fba8e707 Two fixes: 1) Remove race conditions by not locking clients when async writing. 2) Don't derefence dangling pointers in lambda 
Former-commit-id: cb93752aff4c67d4475e9ed17833335716c45744
 2019-10-24 23:07:02 -04:00
John Sully
c8f1efddaa Sanitizers work with GCC too 
Former-commit-id: 549cad378d9faccae0c47917d000c0cad3561351
 2019-10-24 23:05:39 -04:00
John Sully
7bdc24a86d Remove the DB lock, its unnecessary 
Former-commit-id: 631f863dd89cd642e2023beabf8b31cdc84bbdff
 2019-10-24 20:18:48 -04:00
John Sully
b39e6c9497 Remove unlocked KEYS command support, we will do this with snapshotting 
Former-commit-id: 4396682c07d4df3fdca01d1299ad171e310a9fc7
 2019-10-24 20:18:11 -04:00
Oran Agra
5ba6fe50c7 Module API for LatencyAddSample 2019-10-24 14:24:55 +03:00
Yossi Gottlieb
a6d42ebfd9 Modules: improve tests Makefile. 
Removes some boilerplate per module, add clean target.
 2019-10-24 13:21:35 +03:00
antirez
1ffe4578e2 Remove trailing space from server.c. 2019-10-24 11:20:15 +02:00
antirez
3bd7f715c8 Modules hooks: test flush event. 2019-10-24 10:51:03 +02:00
antirez
51b680be42 Modules hooks: initial Tcl test file. 2019-10-24 10:41:25 +02:00
Oran Agra
70815145a7 Make module tests pass with valgrind, and fix a leak in diskless load 2019-10-24 09:45:25 +03:00
John Sully
8d2dc7ab52 Build break, ensure C99 compatibility 
Former-commit-id: ca4ee4e3e4e28e2a186ac782ab0052c56a798ed2
 2019-10-23 13:38:07 -04:00
John Sully
391b2f311e Fix build break in TravisCI 
Former-commit-id: 2da09e07321e114faa04f84ef7a50908ecac5eea
 2019-10-23 13:31:39 -04:00
John Sully
8d0b21c403 If a replica is about to be closed, don't wait on its lock (potential deadlock) 
Former-commit-id: 4986dc6da9855ba14d760a89f13ec40c8bea4baf
 2019-10-23 13:20:23 -04:00
John Sully
8b44d86c7c processEventsWhileBlocked needs to release the lock in a safe way 
Former-commit-id: 1a70af2ae13962db038b0635cc29488019323538
 2019-10-23 13:19:57 -04:00
antirez
a398066625 Modules hooks: select DB zero by default. 2019-10-23 18:51:44 +02:00
antirez
e9f6688a68 Modules hooks: test module draft. 2019-10-23 18:42:02 +02:00
antirez
83adff66c7 Modules hooks: fix memory leak in example module. 2019-10-23 18:39:53 +02:00
antirez
938dafa9e3 Modules hooks: for nested calls, create new fake clients. 
We can't use the same client at the same time when re-entering the hook.
 2019-10-23 18:39:53 +02:00
antirez
261a66b791 Modules hooks: don't call the hook for fake clients. 2019-10-23 18:39:53 +02:00
antirez
d6739df4fc Modules hooks: do not re-enter in hooks. 
Calling a module hook callback may result in callback operations in turn
triggering other events the module is subscribed too. We don't want to
trigger those, it's unsafe and quite confusing, and to do it correcly we
would need to maintain an event list: quite a more complex
implementation.
 2019-10-23 18:39:53 +02:00
antirez
9d10d62003 Modules hooks: select the right DB for FLUSHDB events. 2019-10-23 18:39:53 +02:00
antirez
77a37cafd5 Modules hooks: FLUSHDB event example. 2019-10-23 18:39:53 +02:00
antirez
581c9133e5 Modules hooks: implement the FLUSHDB event. 2019-10-23 18:39:53 +02:00
antirez
6cd26b3db3 Modules hooks: unify structures definitions. 2019-10-23 18:39:53 +02:00
antirez
4866552961 Modules hooks: document what yet to implement WIP 2. 2019-10-23 18:39:53 +02:00
antirez
d41d09d474 Modules hooks: document what yet to implement WIP 1. 2019-10-23 18:39:53 +02:00
antirez
aa4d69606d Modules hooks: do more in example client callback. 2019-10-23 18:39:53 +02:00
antirez
7379bb76f2 Module hooks: fixes and an example module. 2019-10-23 18:39:53 +02:00
antirez
d5bd45a368 Modules hooks: fix sub event in calls from client change. 2019-10-23 18:39:53 +02:00
antirez
f3e4f24f68 Modules hooks: fix define / linker issues. Implement one test event. 2019-10-23 18:39:53 +02:00
antirez
98a0d95965 Modules hooks: handle module unloading + API export. 2019-10-23 18:39:53 +02:00
antirez
30d8dce935 Modules hooks: fix a leak and a few more issues. 2019-10-23 18:39:53 +02:00
antirez
aa9b870db3 Modules hooks: event firing logic. 2019-10-23 18:39:53 +02:00
antirez
e9f6e9306b Modules: refactoring of RM_GetClientInfoById(). 2019-10-23 18:39:53 +02:00
antirez
482cf667aa Modules: fix RedisModule_GetClientInfoById() example. 2019-10-23 18:39:53 +02:00
antirez
16af0381d5 Modules: export GetClientInfoById(). 2019-10-23 18:39:53 +02:00
antirez
23ec02d161 Modules: add the client ID to the client info structure. 2019-10-23 18:39:53 +02:00
antirez
35c8b8969e Modules: RM_GetClientInfoById() draft. 2019-10-23 18:39:53 +02:00
antirez
1f1d25b5a9 Modules hooks: a first version of events and some API. 2019-10-23 18:39:53 +02:00
antirez
7333e5c5a8 Modules hooks: initial design of data structures. 2019-10-23 18:39:53 +02:00
antirez
58a0ef3020 Modules: fix moduleCreateArgvFromUserFormat() casting bug. 
In 32 bit systems casting to "long" will cut the result to 32 bit.
 2019-10-23 18:39:14 +02:00
John Sully
60c35d6ea7 Remove race conditions 
Former-commit-id: 5a8cb77d0df7f319809ff965a72fe46925f49289
 2019-10-22 23:26:37 -04:00
John Sully
b1190c24a8 Optimize deadlock detection, fix callstack for ASM, and annotate locks 
Note: This change moves our assembly code to use the GNU Assembler because NASM seems to be incapable of emitting the necessary debug information for callstack unwinding to work.

Former-commit-id: 600fc241cfe79b9b32ac6010c6ea0c66747f0f15
 2019-10-22 21:34:51 -04:00