gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
27,350 Commits 1 Branch 0 Tags
Commit Graph

27350 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Salvatore Sanfilippo
5558c0e4cf
Merge pull request #6848 from oranagra/opt_use_diskless_load_calls 
reduce repeated calls to use_diskless_load
 2020-02-06 10:30:39 +01:00
Salvatore Sanfilippo
086f25d1a8 Merge pull request #6849 from oranagra/free_client_mutex 
freeClientAsync don't lock mutex if there's just one thread
 2020-02-06 10:29:46 +01:00
Salvatore Sanfilippo
7cf53252ee
Merge pull request #6849 from oranagra/free_client_mutex 
freeClientAsync don't lock mutex if there's just one thread
 2020-02-06 10:29:46 +01:00
Salvatore Sanfilippo
965cc6b607 Merge pull request #6850 from oranagra/restart_aof_unset_master 
move restartAOFAfterSYNC from replicaofCommand to replicationUnsetMaster
 2020-02-06 10:27:05 +01:00
Salvatore Sanfilippo
44266d6d92
Merge pull request #6850 from oranagra/restart_aof_unset_master 
move restartAOFAfterSYNC from replicaofCommand to replicationUnsetMaster
 2020-02-06 10:27:05 +01:00
Salvatore Sanfilippo
6a677cc2fa Merge pull request #6851 from oranagra/aof_rewrite_scheduled 
stopAppendOnly resets aof_rewrite_scheduled
 2020-02-06 10:23:11 +01:00
Salvatore Sanfilippo
58a3a3fa68
Merge pull request #6851 from oranagra/aof_rewrite_scheduled 
stopAppendOnly resets aof_rewrite_scheduled
 2020-02-06 10:23:11 +01:00
Salvatore Sanfilippo
b8a57dc76e Merge pull request #6852 from oranagra/acl_help 
add SAVE subcommand to ACL HELP and top comment
 2020-02-06 10:22:16 +01:00
Salvatore Sanfilippo
711b13801e
Merge pull request #6852 from oranagra/acl_help 
add SAVE subcommand to ACL HELP and top comment
 2020-02-06 10:22:16 +01:00
Salvatore Sanfilippo
fd94ed0819 Merge pull request #6853 from oranagra/debug_help 
DEBUG HELP - add PROTOCOL
 2020-02-06 10:21:55 +01:00
Salvatore Sanfilippo
f25962337d
Merge pull request #6853 from oranagra/debug_help 
DEBUG HELP - add PROTOCOL
 2020-02-06 10:21:55 +01:00
Salvatore Sanfilippo
df9ca7d05a Merge pull request #6854 from guybe7/mem_overhead_miscalc 
Fix small bugs related to replica and monitor ambiguity
 2020-02-06 10:21:30 +01:00
Salvatore Sanfilippo
15c7f1317e
Merge pull request #6854 from guybe7/mem_overhead_miscalc 
Fix small bugs related to replica and monitor ambiguity
 2020-02-06 10:21:30 +01:00
Guy Benoish
2b10c2ce47 Some refactroing using getClientType instead of CLIENT_SLAVE 2020-02-06 14:12:08 +05:30
Guy Benoish
91c41b6dde Some refactroing using getClientType instead of CLIENT_SLAVE 2020-02-06 14:12:08 +05:30
Oran Agra
bc705b1b26 DEBUG HELP - add PROTOCOL 2020-02-06 10:40:29 +02:00
Oran Agra
31ffbf1133 DEBUG HELP - add PROTOCOL 2020-02-06 10:40:29 +02:00
Guy Benoish
818b77193b Fix small bugs related to replica and monitor ambiguity 
1. server.repl_no_slaves_since can be set when a MONITOR client disconnects
2. c->repl_ack_time can be set by a newline from a MONITOR client
3. Improved comments
 2020-02-06 14:10:02 +05:30
Guy Benoish
e33fffbde1 Fix small bugs related to replica and monitor ambiguity 
1. server.repl_no_slaves_since can be set when a MONITOR client disconnects
2. c->repl_ack_time can be set by a newline from a MONITOR client
3. Improved comments
 2020-02-06 14:10:02 +05:30
Oran Agra
7e53f26984 add SAVE subcommand to ACL HELP and top comment 2020-02-06 10:31:43 +02:00
Oran Agra
6d29c34da7 add SAVE subcommand to ACL HELP and top comment 2020-02-06 10:31:43 +02:00
Oran Agra
a772eb89cc stopAppendOnly resets aof_rewrite_scheduled 
althouh in theory, users can do BGREWRITEAOF even if aof is disabled, i
suppose it is more common that the scheduled flag is set by either
startAppendOnly, of a failed initial AOFRW fork (AOF_WAIT_REWRITE)
 2020-02-06 10:17:34 +02:00
Oran Agra
69e8ea7143 stopAppendOnly resets aof_rewrite_scheduled 
althouh in theory, users can do BGREWRITEAOF even if aof is disabled, i
suppose it is more common that the scheduled flag is set by either
startAppendOnly, of a failed initial AOFRW fork (AOF_WAIT_REWRITE)
 2020-02-06 10:17:34 +02:00
Oran Agra
3a74aa3ebe move restartAOFAfterSYNC from replicaofCommand to replicationUnsetMaster 
replicationUnsetMaster can be called from other places, not just
replicaofCOmmand, and all of these need to restart AOF
 2020-02-06 10:14:32 +02:00
Oran Agra
aac6a4cf13 move restartAOFAfterSYNC from replicaofCommand to replicationUnsetMaster 
replicationUnsetMaster can be called from other places, not just
replicaofCOmmand, and all of these need to restart AOF
 2020-02-06 10:14:32 +02:00
Oran Agra
df866ad322 freeClientAsync don't lock mutex if there's just one thread 2020-02-06 10:07:17 +02:00
Oran Agra
86e302f5f3 freeClientAsync don't lock mutex if there's just one thread 2020-02-06 10:07:17 +02:00
Oran Agra
3ea0716cad reduce repeated calls to use_diskless_load 
this function possibly iterates on the module list
 2020-02-06 09:41:45 +02:00
Oran Agra
485d5d4a18 reduce repeated calls to use_diskless_load 
this function possibly iterates on the module list
 2020-02-06 09:41:45 +02:00
Oran Agra
01eadbd6e1 moduleRDBLoadError, add key name, and use panic rather than exit 
using panic rather than exit means you get s stack trace of the code
path that experianced the error, and possibly other info.
 2020-02-06 09:37:04 +02:00
Oran Agra
85cc696f50 moduleRDBLoadError, add key name, and use panic rather than exit 
using panic rather than exit means you get s stack trace of the code
path that experianced the error, and possibly other info.
 2020-02-06 09:37:04 +02:00
Oran Agra
4050c57139 Fix client flags to be int64 in module.c 
currently there's no bug since the flags these functions handle are
always lower than 32bit, but still better fix the type to prevent future
bugs.
 2020-02-06 09:33:20 +02:00
Oran Agra
d454d5a4f5 Fix client flags to be int64 in module.c 
currently there's no bug since the flags these functions handle are
always lower than 32bit, but still better fix the type to prevent future
bugs.
 2020-02-06 09:33:20 +02:00
Oran Agra
e41c1824d6 fix maxmemory config warning 
the warning condition was if usage > limit (saying it'll cause eviction
or oom), but in fact the eviction and oom depends on used minus slave
buffers.

other than fixing the condition, i add info about the current usage and
limit, which may be useful when looking at the log.
 2020-02-06 09:23:22 +02:00
Oran Agra
a17bddf2a1 fix maxmemory config warning 
the warning condition was if usage > limit (saying it'll cause eviction
or oom), but in fact the eviction and oom depends on used minus slave
buffers.

other than fixing the condition, i add info about the current usage and
limit, which may be useful when looking at the log.
 2020-02-06 09:23:22 +02:00
Oran Agra
f7bb301644 Memory leak when bind config is provided twice 2020-02-06 09:17:39 +02:00
Oran Agra
7e1d5954e5 Memory leak when bind config is provided twice 2020-02-06 09:17:39 +02:00
Oran Agra
ddc1845286 A few non-data commands that should be allowed while loading or stale 
SELECT, and HELLO are commands that may be executed by the client
as soon as it connects, there's no reason to block them, preventing the
client from doing the rest of his sequence (which might just be INFO or
CONFIG, etc).

MONITOR, DEBUG, SLOWLOG, TIME, LASTSAVE are all non-data accessing
commands, which there's no reason to block.
 2020-02-06 08:53:23 +02:00
Oran Agra
ac2c96f5b1 A few non-data commands that should be allowed while loading or stale 
SELECT, and HELLO are commands that may be executed by the client
as soon as it connects, there's no reason to block them, preventing the
client from doing the rest of his sequence (which might just be INFO or
CONFIG, etc).

MONITOR, DEBUG, SLOWLOG, TIME, LASTSAVE are all non-data accessing
commands, which there's no reason to block.
 2020-02-06 08:53:23 +02:00
Yossi Gottlieb
bc5e0a456b TLS: Update documentation. 2020-02-05 21:19:03 +02:00
Yossi Gottlieb
bb3d45a386 TLS: Update documentation. 2020-02-05 21:19:03 +02:00
Oran Agra
467090e45f Add handling of short read of module id in rdb 2020-02-05 19:47:09 +02:00
Oran Agra
fe7e8dc955 Add handling of short read of module id in rdb 2020-02-05 19:47:09 +02:00
Salvatore Sanfilippo
9d016c0084 Merge pull request #6839 from yossigo/fix/redis-conf-tls-clarifications 
TLS: Some redis.conf clarifications.
 2020-02-05 17:33:21 +01:00
Salvatore Sanfilippo
edfe1b2f8b
Merge pull request #6839 from yossigo/fix/redis-conf-tls-clarifications 
TLS: Some redis.conf clarifications.
 2020-02-05 17:33:21 +01:00
Yossi Gottlieb
f4c7f1ac27 TLS: Some redis.conf clarifications. 2020-02-05 18:30:12 +02:00
Yossi Gottlieb
1e02d599dc TLS: Some redis.conf clarifications. 2020-02-05 18:30:12 +02:00
Oran Agra
13a7379024 update RM_SignalModifiedKey doc comment 2020-02-05 18:15:38 +02:00
Oran Agra
3795aaf42a update RM_SignalModifiedKey doc comment 2020-02-05 18:15:38 +02:00
Oran Agra
7d12ef55ca Optimize temporary memory allocations for getKeysFromCommand mechanism 
now that we may use it more often (ACL), these excessive calls to malloc
and free can become an overhead.
 2020-02-05 18:06:33 +02:00