Oran Agra
1333a46b7e
fix maxmemory config warning
...
the warning condition was if usage > limit (saying it'll cause eviction
or oom), but in fact the eviction and oom depends on used minus slave
buffers.
other than fixing the condition, i add info about the current usage and
limit, which may be useful when looking at the log.
2020-02-12 14:17:40 +01:00
Oran Agra
a98e5a1fc3
Fix client flags to be int64 in module.c
...
currently there's no bug since the flags these functions handle are
always lower than 32bit, but still better fix the type to prevent future
bugs.
2020-02-12 14:17:40 +01:00
Oran Agra
8e7282eb3e
Fix client flags to be int64 in module.c
...
currently there's no bug since the flags these functions handle are
always lower than 32bit, but still better fix the type to prevent future
bugs.
2020-02-12 14:17:40 +01:00
Oran Agra
e92983ed3f
moduleRDBLoadError, add key name, and use panic rather than exit
...
using panic rather than exit means you get s stack trace of the code
path that experianced the error, and possibly other info.
2020-02-12 14:17:40 +01:00
Oran Agra
a678390e52
moduleRDBLoadError, add key name, and use panic rather than exit
...
using panic rather than exit means you get s stack trace of the code
path that experianced the error, and possibly other info.
2020-02-12 14:17:40 +01:00
Oran Agra
a8e2bbe8f6
stopAppendOnly resets aof_rewrite_scheduled
...
althouh in theory, users can do BGREWRITEAOF even if aof is disabled, i
suppose it is more common that the scheduled flag is set by either
startAppendOnly, of a failed initial AOFRW fork (AOF_WAIT_REWRITE)
2020-02-12 14:15:56 +01:00
Oran Agra
f42ce57d0f
stopAppendOnly resets aof_rewrite_scheduled
...
althouh in theory, users can do BGREWRITEAOF even if aof is disabled, i
suppose it is more common that the scheduled flag is set by either
startAppendOnly, of a failed initial AOFRW fork (AOF_WAIT_REWRITE)
2020-02-12 14:15:56 +01:00
Oran Agra
2af4039b3e
reduce repeated calls to use_diskless_load
...
this function possibly iterates on the module list
2020-02-12 14:15:56 +01:00
Oran Agra
919fbf421d
reduce repeated calls to use_diskless_load
...
this function possibly iterates on the module list
2020-02-12 14:15:56 +01:00
Oran Agra
23cbfea39b
add SAVE subcommand to ACL HELP and top comment
2020-02-12 14:15:56 +01:00
Oran Agra
df096bc96b
add SAVE subcommand to ACL HELP and top comment
2020-02-12 14:15:56 +01:00
Oran Agra
5e3b4c978b
freeClientAsync don't lock mutex if there's just one thread
2020-02-12 14:15:56 +01:00
Oran Agra
22e45d46fe
freeClientAsync don't lock mutex if there's just one thread
2020-02-12 14:15:56 +01:00
Oran Agra
3988bfff50
DEBUG HELP - add PROTOCOL
2020-02-12 14:15:56 +01:00
Oran Agra
a55e584706
DEBUG HELP - add PROTOCOL
2020-02-12 14:15:56 +01:00
Oran Agra
ad1c21283e
move restartAOFAfterSYNC from replicaofCommand to replicationUnsetMaster
...
replicationUnsetMaster can be called from other places, not just
replicaofCOmmand, and all of these need to restart AOF
2020-02-12 14:15:56 +01:00
Oran Agra
ba28924418
move restartAOFAfterSYNC from replicaofCommand to replicationUnsetMaster
...
replicationUnsetMaster can be called from other places, not just
replicaofCOmmand, and all of these need to restart AOF
2020-02-12 14:15:56 +01:00
Guy Benoish
084dc68128
Some refactroing using getClientType instead of CLIENT_SLAVE
2020-02-12 14:15:56 +01:00
Guy Benoish
5a6cfbf4ca
Some refactroing using getClientType instead of CLIENT_SLAVE
2020-02-12 14:15:56 +01:00
Guy Benoish
f4c30fd74b
Fix small bugs related to replica and monitor ambiguity
...
1. server.repl_no_slaves_since can be set when a MONITOR client disconnects
2. c->repl_ack_time can be set by a newline from a MONITOR client
3. Improved comments
2020-02-12 14:15:56 +01:00
Guy Benoish
fae306b374
Fix small bugs related to replica and monitor ambiguity
...
1. server.repl_no_slaves_since can be set when a MONITOR client disconnects
2. c->repl_ack_time can be set by a newline from a MONITOR client
3. Improved comments
2020-02-12 14:15:56 +01:00
Yossi Gottlieb
351529cc39
TLS: Some redis.conf clarifications.
2020-02-12 14:15:56 +01:00
Yossi Gottlieb
736309660f
TLS: Some redis.conf clarifications.
2020-02-12 14:15:56 +01:00
Oran Agra
601d423498
config.c verbose error replies for CONFIG SET, like config file parsing
...
We noticed that the error replies for the generic mechanism for enums
are very verbose for config file parsing, but not for config set
command.
instead of replicating this code, i did a small refactoring to share
code between CONFIG SET and config file parsing.
and also renamed the enum group functions to be consistent with the
naming of other types.
2020-02-12 14:15:56 +01:00
Oran Agra
488e194787
config.c verbose error replies for CONFIG SET, like config file parsing
...
We noticed that the error replies for the generic mechanism for enums
are very verbose for config file parsing, but not for config set
command.
instead of replicating this code, i did a small refactoring to share
code between CONFIG SET and config file parsing.
and also renamed the enum group functions to be consistent with the
naming of other types.
2020-02-12 14:15:56 +01:00
Oran Agra
138252dc56
memoryGetKeys helper function so that ACL can limit access to keys for MEMORY command
2020-02-12 14:15:56 +01:00
Oran Agra
c82ccf0670
memoryGetKeys helper function so that ACL can limit access to keys for MEMORY command
2020-02-12 14:15:56 +01:00
antirez
491949ee5b
ACL LOG: make max log entries configurable.
2020-02-12 14:15:35 +01:00
antirez
51c1a9f8fb
ACL LOG: make max log entries configurable.
2020-02-12 14:15:35 +01:00
antirez
c30fe3a93f
ACL LOG: test for AUTH reason.
2020-02-12 14:15:35 +01:00
antirez
ea1e1b12c9
ACL LOG: test for AUTH reason.
2020-02-12 14:15:35 +01:00
antirez
c0de265bfa
ACL LOG: log failed auth attempts.
2020-02-12 14:15:35 +01:00
antirez
7379c78a9b
ACL LOG: log failed auth attempts.
2020-02-12 14:15:35 +01:00
antirez
c60351e489
ACL LOG: implement a few basic tests.
2020-02-12 14:15:35 +01:00
antirez
9f6e84f6be
ACL LOG: implement a few basic tests.
2020-02-12 14:15:35 +01:00
antirez
74c4d2f158
ACL LOG: also log ACL errors in the scripting/MULTI ctx.
2020-02-12 14:15:35 +01:00
antirez
82790e510f
ACL LOG: also log ACL errors in the scripting/MULTI ctx.
2020-02-12 14:15:35 +01:00
antirez
3853c71288
ACL LOG: implement LOG RESET.
2020-02-12 14:15:35 +01:00
antirez
943008ebac
ACL LOG: implement LOG RESET.
2020-02-12 14:15:35 +01:00
antirez
7b53636462
ACL LOG: group similar entries in a given time delta.
2020-02-12 14:15:35 +01:00
antirez
e271a61103
ACL LOG: group similar entries in a given time delta.
2020-02-12 14:15:35 +01:00
antirez
9f5b64c4a6
ACL LOG: actually emit entries.
2020-02-12 14:15:35 +01:00
antirez
f1974d5d67
ACL LOG: actually emit entries.
2020-02-12 14:15:35 +01:00
antirez
e6eafd3e1f
ACL LOG: implement ACL LOG subcommadn skeleton.
2020-02-12 14:15:35 +01:00
antirez
d9b153c9f6
ACL LOG: implement ACL LOG subcommadn skeleton.
2020-02-12 14:15:35 +01:00
antirez
2d06604451
ACL LOG: data structures and initial functions.
2020-02-12 14:15:35 +01:00
antirez
577fc4388b
ACL LOG: data structures and initial functions.
2020-02-12 14:15:35 +01:00
Salvatore Sanfilippo
3fb021696f
Merge pull request #6691 from kraj/fno-common
...
Mark extern definition of SDS_NOINIT in sds.h
2020-02-12 14:04:53 +01:00
Salvatore Sanfilippo
8aa0b19d83
Merge pull request #6691 from kraj/fno-common
...
Mark extern definition of SDS_NOINIT in sds.h
2020-02-12 14:04:53 +01:00
Salvatore Sanfilippo
5f1f2bed7d
Merge pull request #6882 from lifubang/userpass
...
correct help info for --user and --pass
2020-02-12 14:04:15 +01:00