gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
15,247 Commits 1 Branch 0 Tags
Commit Graph

15247 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
antirez
da8c7c49bf Example sentinel conf: document requirepass. 2020-03-25 15:54:34 +01:00
guodongxiaren
da14982d1e string literal should be const char* 2020-03-25 15:54:34 +01:00
WuYunlong
299f1d0258 Add 14-consistency-check.tcl to prove there is a data consistency issue. 2020-03-25 15:54:34 +01:00
antirez
bdb338cf77 Aesthetic changes in PR #6989. 2020-03-25 15:54:34 +01:00
Itamar Haber
dc8885a1ca Adds keyspace notifications to migrate and restore 2020-03-25 15:54:34 +01:00
antirez
61b98f32a2 Regression test for #7011. 2020-03-25 15:54:34 +01:00
bodong.ybd
bfb18e5519 Remove duplicate obj files in Makefile 2020-03-25 15:54:34 +01:00
antirez
34ea2f4e1a ACL: default user off should not allow automatic authentication. 
This fixes issue #7011.
 2020-03-25 15:54:34 +01:00
antirez
cbbf9b3931 Sentinel: document auth-user directive. 2020-03-25 15:54:34 +01:00
antirez
9c2e42ddfc ACL: Make Redis 6 more backward compatible with requirepass. 
Note that this as a side effect fixes Sentinel "requirepass" mode.
 2020-03-25 15:54:34 +01:00
antirez
d387f67dcb Sentinel: implement auth-user directive for ACLs. 2020-03-25 15:54:34 +01:00
antirez
c4d7f30e25 PSYNC2: meaningful offset test. 2020-03-25 15:43:34 +01:00
antirez
57fa355e56 PSYNC2: meaningful offset implemented. 
A very commonly signaled operational problem with Redis master-replicas
sets is that, once the master becomes unavailable for some reason,
especially because of network problems, many times it wont be able to
perform a partial resynchronization with the new master, once it rejoins
the partition, for the following reason:

1. The master becomes isolated, however it keeps sending PINGs to the
replicas. Such PINGs will never be received since the link connection is
actually already severed.
2. On the other side, one of the replicas will turn into the new master,
setting its secondary replication ID offset to the one of the last
command received from the old master: this offset will not include the
PINGs sent by the master once the link was already disconnected.
3. When the master rejoins the partion and is turned into a replica, its
offset will be too advanced because of the PINGs, so a PSYNC will fail,
and a full synchronization will be required.

Related to issue #7002 and other discussion we had in the past around
this problem.
 2020-03-25 15:26:37 +01:00
antirez
f15042dbf0 Explain why we allow transactions in -BUSY state. 
Related to #7022.
 2020-03-25 12:46:59 +01:00
Salvatore Sanfilippo
643bc48a00
Merge pull request #7022 from oranagra/multi-busy-script 
MULTI/EXEC during LUA script timeout are messed up
 2020-03-25 12:44:26 +01:00
John Sully
7b2b437539 Fix failure to load subkey expires 
Former-commit-id: 528a43bd6c80f073d928dd18c4f67f37cfd0977a
 2020-03-25 01:38:58 -04:00
John Sully
70faf2f375 Expire entry needs to be resorted after a subkey expires 
Former-commit-id: b357803362728c26a1169e3cec279c693b86205b
 2020-03-25 01:06:40 -04:00
John Sully
e12170c724 Evict on load if we have a storage provider 
Former-commit-id: bb091796c3da7282e040c7b72a28ec1c5f5ecfb7
 2020-03-24 14:49:43 -04:00
John Sully
79f48a214e Prevent issue where count can be out of sync temporarily, causing crashes where we expect the count to be perfect 
Former-commit-id: 77c9f36413c6f0cbb0b13a7ec746746c97faadcd
 2020-03-24 00:21:12 -04:00
John Sully
ae81c227fe Fix OOM errors during forkless bgsave 
Former-commit-id: c31c64b13409c741e8d52ad06add78300c39fce2
 2020-03-23 23:12:10 -04:00
John Sully
bb3314c0d9 Fix incorrect prefix comparison 
Former-commit-id: 1ef167546be0678edd457d65a5368e8706fde0a3
 2020-03-23 22:51:46 -04:00
John Sully
0381e728ab Fix incorrect count when loading FLASH 
Former-commit-id: 38ee9c0df144621f7ca750527e9efb16e754ef40
 2020-03-23 19:47:48 -04:00
John Sully
82e1ed482a Prevent bookkeeping keys from leaking through 
Former-commit-id: 1a5af28e115fc123bf250b4a80ac69232bb3add0
 2020-03-23 18:06:47 -04:00
Oran Agra
ec007559ff MULTI/EXEC during LUA script timeout are messed up 
Redis refusing to run MULTI or EXEC during script timeout may cause partial
transactions to run.

1) if the client sends MULTI+commands+EXEC in pipeline without waiting for
response, but these arrive to the shards partially while there's a busy script,
and partially after it eventually finishes: we'll end up running only part of
the transaction (since multi was ignored, and exec would fail).

2) similar to the above if EXEC arrives during busy script, it'll be ignored and
the client state remains in a transaction.

the 3rd test which i added for a case where MULTI and EXEC are ok, and
only the body arrives during busy script was already handled correctly
since processCommand calls flagTransaction
 2020-03-23 20:45:32 +02:00
antirez
c80d81c80a Improve comments of replicationCacheMasterUsingMyself(). 2020-03-23 16:17:35 +01:00
antirez
61de1c1146 Fix BITFIELD_RO test. 2020-03-23 12:02:12 +01:00
antirez
918086e253 Abort transactions after -READONLY error. Fix #7014. 2020-03-23 11:47:49 +01:00
antirez
38514e3c8d Minor changes to BITFIELD_RO PR #6951. 2020-03-23 11:28:09 +01:00
Salvatore Sanfilippo
493a7f9823
Merge pull request #6951 from yangbodong22011/feature-bitfield-ro 
Added BITFIELD_RO variants for read-only operations.
 2020-03-23 11:23:21 +01:00
antirez
19f5be231d Modules: updated function doc after #7003. 2020-03-23 11:17:50 +01:00
Salvatore Sanfilippo
7c5dc07016
Merge pull request #7003 from guybe7/rm_context_flags_handle_null 
Allow RM_GetContextFlags to work with ctx==NULL
 2020-03-23 11:15:42 +01:00
Salvatore Sanfilippo
b9e5be5f56
Merge pull request #7005 from hwware/memoryleakfix-redis-cli 
fix potential memory leak in redis-cli lua debug mode
 2020-03-23 11:14:46 +01:00
Salvatore Sanfilippo
89f46f0fa1
Merge pull request #7018 from yossigo/fix-accept-issues 
Fix issues with failed/rejected accepts.
 2020-03-23 11:10:59 +01:00
Salvatore Sanfilippo
d1788a5ddb
Merge pull request #7019 from hwware/cscfix 
Fix Bug for Client Side Caching: Unexpected Behaviour when Switching between OPTIN/OPTOUT Mode
 2020-03-23 11:09:55 +01:00
hwware
34d5982bd5 remove redundant Semicolon 2020-03-23 01:07:46 -04:00
hwware
a2732291cd clean CLIENT_TRACKING_CACHING flag when disabled caching 2020-03-23 01:04:49 -04:00
Yossi Gottlieb
2dab5015b7 Fix crashes related to failed/rejected accepts. 2020-03-22 14:47:44 +02:00
Yossi Gottlieb
4c08ae3ff6 Cluster: fix misleading accept errors. 2020-03-22 14:46:16 +02:00
Yossi Gottlieb
fa9aa90813 Conns: Fix connClose() / connAccept() behavior. 
We assume accept handlers may choose to reject a connection and close
it, but connAccept() callers can't distinguish between this state and
other error states requiring connClose().

This makes it safe (and mandatory!) to always call connClose() if
connAccept() fails, and safe for accept handlers to close connections
(which will defer).
 2020-03-22 14:42:03 +02:00
Salvatore Sanfilippo
5634ee973c
Merge pull request #7013 from hwware/clusterhelpfix 
add missing commands description in cluster help
 2020-03-20 16:33:10 +01:00
hwware
93bb42a0b5 add missing commands in cluster help 2020-03-20 09:01:12 -04:00
antirez
1e16b9384d Merge branch 'unstable' of github.com:/antirez/redis into unstable 2020-03-20 13:21:28 +01:00
antirez
5497a44037 Regression test for #7011. 2020-03-20 12:52:06 +01:00
antirez
f9c56dbb09 ACL: default user off should not allow automatic authentication. 
This fixes issue #7011.
 2020-03-20 12:45:48 +01:00
John Sully
b057a9cd7a Unstable branch should always be version 0.0.0 
Former-commit-id: 448808529ab9e9e4705c2e7cbda5b3e6523b7c6f
 2020-03-19 15:52:24 -04:00
John Sully
dada212214 Merge branch 'RELEASE_5' into unstable 
Former-commit-id: a0bc2084128f991697d3e1b7473d14c55afdd785
 2020-03-19 15:38:16 -04:00
John Sully
69806aaa7b Print stack traces of other threads in the deadlock detector 
Former-commit-id: 6b0172b9bf124372f4c8688c91c380c6c1b607c7
 2020-03-19 15:37:49 -04:00
John Sully
1bdccb3c42 Log which thread a message came from 
Former-commit-id: bc1eccb66d3302d6c99588fb4a5a879e1ef243b1
 2020-03-19 15:37:24 -04:00
John Sully
4d5d7ed59f Fix lock inversion in processEventsWhileBlocked 
Former-commit-id: a9249d4a82a0f0355ac8ffa40b34b9c14cabf66b
 2020-03-19 15:28:39 -04:00
John Sully
87626299a6 Prevent dangling lock when we can't free the client 
Former-commit-id: 3c373494d63b21744b264f0a47e6999bcdda6b2b
 2020-03-19 14:34:23 -04:00