antirez
37d26d689f
Remove useless comment from serverCron().
...
The behavior is well specified by the code itself.
2018-01-17 11:23:41 +01:00
Salvatore Sanfilippo
6c925586dc
Merge pull request #4546 from hqin6/unstable
...
fixbug for #4545 dead loop aof rewrite
2018-01-17 11:21:55 +01:00
heqin
a5a5fc6927
fixbug for #4545 dead loop aof rewrite
2018-01-17 18:08:30 +08:00
Salvatore Sanfilippo
e1ac223e27
Merge pull request #4609 from Qinch/unstable
...
fix assert problem in ZIP_DECODE_PREVLENSIZE macro
2018-01-17 10:45:11 +01:00
antirez
3d176c3833
Hopefully more clear comment to explain the change in #4607 .
2018-01-16 15:52:13 +01:00
qinchao
1fdfc1a837
fix assert problem in ZIP_DECODE_PREVLENSIZE
...
, see issue: https://github.com/antirez/redis/issues/4587
2018-01-16 22:43:06 +08:00
Salvatore Sanfilippo
40166ec44b
Merge pull request #4607 from oranagra/psync2_backlog
...
PSYNC2 fix - promoted slave should hold on to it's backlog
2018-01-16 15:32:58 +01:00
Oran Agra
12f7ed3bb5
PSYNC2 fix - promoted slave should hold on to it's backlog
...
after a slave is promoted (assuming it has no slaves
and it booted over an hour ago), it will lose it's replication
backlog at the next replication cron, rather than waiting for slaves
to connect to it.
so on a simple master/slave faiover, if the new slave doesn't connect
immediately, it may be too later and PSYNC2 will fail.
2018-01-16 10:10:42 +02:00
zhaozhao.zz
410a7d4413
aof: format code and comment
2018-01-15 13:01:03 +01:00
antirez
4b49dbfab3
Put more details in the comment introduced by #4601 .
2018-01-15 12:50:08 +01:00
Salvatore Sanfilippo
e448ff1dc2
Merge pull request #4601 from soloestoy/fix-memoryleak-for-lazy-server-del
...
lazyfree: fix memory leak for lazyfree-lazy-server-del
2018-01-15 12:43:55 +01:00
zhaozhao.zz
bc09b1a969
lazyfree: fix memory leak for lazyfree-lazy-server-del
2018-01-15 00:45:37 +08:00
Salvatore Sanfilippo
f0d3240328
Merge pull request #4575 from soloestoy/bugfix-benchmark
...
redis-benchmark: bugfix - handle zero liveclients in right way
2018-01-12 17:43:01 +01:00
Salvatore Sanfilippo
2e51347925
Merge pull request #4581 from dvirsky/module_unlink
...
Added RM_UnlinkKey - a low level analog to UNLINK command
2018-01-12 17:41:09 +01:00
antirez
bcfdd6b138
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-01-12 17:16:38 +01:00
Salvatore Sanfilippo
437bccb8ac
Merge pull request #4586 from gnuhpc/fix-crashlog-typo
...
Fix a typo(maybe instruction?) in crash log
2018-01-12 17:16:12 +01:00
antirez
b686b085ed
Fix getKeysUsingCommandTable() in the case of nagative arity.
...
This fixes a crash with Redis Cluster when OBJECT is mis-used, because
getKeysUsingCommandTable() will call serverPanic() detecting we are
accessing an invalid argument in the case "OBJECT foo" is called.
This bug was introduced when OBJECT HELP was introduced, because the key
argument is set fixed at index 2 in the command table, however now
OBJECT may be called with an insufficient number of arguments to extract
the key.
The "Right Thing" would be to have a specific function to extract keys
from the OBJECT command, however this is kinda of an overkill, so I
preferred to make getKeysUsingCommandTable() more robust and just return
no keys when it's not possible to honor the command table, because new
commands are often added and also there are a number with an HELP
subcommand violating the normal form, and crashing for this trivial
reason or having many command-specific key extraction functions is not
great.
2018-01-12 11:26:29 +01:00
antirez
4b525c93d3
Document new protocol options in #4568 into redis.conf.
2018-01-11 11:40:57 +01:00
antirez
32aa53d8a3
proto-max-querybuf-len -> client-query-buffer-limit.
...
We already had client buffer limits exported as configuration options.
Stick with the naming scheme already used.
See #4568 .
2018-01-11 11:36:26 +01:00
antirez
4573d2648d
New config options about protocol prefixed with "proto".
...
Related to #4568 .
2018-01-11 11:27:41 +01:00
Salvatore Sanfilippo
5a12109c99
Merge pull request #4568 from oranagra/restore_size_limit
...
fix RESTORE command size limits
2018-01-11 11:20:02 +01:00
huijing.whj
9e2253b0a8
fix int overflow problem in freeMemoryIfNeeded
2018-01-10 23:47:02 +08:00
Salvatore Sanfilippo
1171ac22ef
Merge pull request #3356 from yusaku/fix-module-firstkey
...
Fix the firstkey, lastkey, and keystep of moduleCommand
2018-01-09 18:58:31 +01:00
antirez
f33db219a6
Test: MIGRATE AUTH test added.
...
Related to #2507 .
2018-01-09 18:49:19 +01:00
antirez
8dbcf05e91
Rewrite MIGRATE AUTH option.
...
See PR #2507 . This is a reimplementation of the fix that contained
different problems.
2018-01-09 18:48:26 +01:00
gnuhpc
f980e794f7
Fix a typo(maybe instruction?) in crash log
2018-01-09 16:13:02 +08:00
Dvir Volk
7e4794f67c
Added RM_UnlinkKey - a low level analog to UNLINK command
2018-01-07 16:41:43 +02:00
Salvatore Sanfilippo
35957ba833
Merge pull request #4579 from gnuhpc/fix-memoryusage-list
...
Fix memory usage list bug
2018-01-05 11:53:11 +01:00
gnuhpc
35b38d789a
Fix memory usage list bug
2018-01-05 12:16:24 +08:00
zhaozhao.zz
0c608a4ce9
redis-benchmark: bugfix - handle zero liveclients in right way
2018-01-03 12:47:25 +08:00
Oran Agra
41be5ba332
Add config options for max-bulk-len and max-querybuf-len mainly to support RESTORE of large keys
2017-12-29 12:43:48 +02:00
Oran Agra
5821e8cf82
fix processing of large bulks (above 2GB)
...
- protocol parsing (processMultibulkBuffer) was limitted to 32big positions in the buffer
readQueryFromClient potential overflow
- rioWriteBulkCount used int, although rioWriteBulkString gave it size_t
- several places in sds.c that used int for string length or index.
- bugfix in RM_SaveAuxField (return was 1 or -1 and not length)
- RM_SaveStringBuffer was limitted to 32bit length
2017-12-29 12:24:19 +02:00
antirez
3612de4906
Hyperloglog: refresh hdr variable correctly.
...
This is a fix for the #3819 improvements. The o->ptr may change because
of hllSparseSet() calls, so 'hdr' must be correctly re-fetched.
2017-12-22 11:26:31 +01:00
antirez
bb3ba76417
Hyperloglog: Support for PFMERGE sparse encoding as target.
...
This is a fix for #3819 .
2017-12-22 11:01:27 +01:00
antirez
355302b300
Hyperloglog: refactoring of sparse/dense add function.
...
The commit splits the add functions into a set() and add() set of
functions, so that it's possible to set registers in an independent way
just having the index and count.
Related to #3819 , otherwise a fix is not possible.
2017-12-22 11:00:22 +01:00
heqin
31109c10e9
fixbug for #4545 dead loop aof rewrite
2017-12-18 17:59:03 +08:00
Itamar Haber
8f4aff385c
Uppercases subcommands in OBJECT HELP
2017-12-15 21:21:12 +02:00
Itamar Haber
3c860af353
Uppercases subcommands in MEMORY HELP
2017-12-15 21:19:41 +02:00
Salvatore Sanfilippo
2d1c0725e8
Merge pull request #4540 from hqin6/unstable
...
fixbug for #4538 Error opening /setting AOF rewrite IPC pipes: No suc…
2017-12-15 12:41:02 +01:00
heqin
c0296376a5
fixbug for #4538 Error opening /setting AOF rewrite IPC pipes: No such file or directory
2017-12-15 11:06:58 +08:00
Salvatore Sanfilippo
5461dc907d
Merge pull request #4536 from tporadowski/antirez_unstable-cli-history
...
Always enable command history in redis-cli run on a TTY
2017-12-14 22:14:45 +01:00
Salvatore Sanfilippo
f9c443322d
Merge pull request #4528 from nashe/patch-oob-read-4527
...
Prevent off-by-one read in stringmatchlen()
2017-12-14 12:21:32 +01:00
antirez
87b16c07d2
safe_write -> aofWrite. Function commented.
...
Related to #4498 .
2017-12-14 12:19:36 +01:00
Salvatore Sanfilippo
c4d9f5b2b7
Merge pull request #4498 from soloestoy/aof-safe-write
...
Aof safe write -- fix the short write
2017-12-14 12:15:46 +01:00
Tomasz Poradowski
b58c25aefc
always enable command history in redis-cli
...
- when redis-cli is running in a TTY - always enable command history
buffering, regardless if history file path can be successfully
determined
2017-12-13 23:49:41 +01:00
antirez
3c36d7c91a
Cluster: allow read-only EVAL/EVALSHA in slaves.
...
Fix #3665 .
2017-12-13 13:36:01 +01:00
nashe
b3028109ea
Prevent off-by-one read in stringmatchlen() ( fixes #4527 )
2017-12-12 01:25:03 +01:00
Itamar Haber
17c8ff5a1c
Standardizes MEMORY HELP
subcommand
2017-12-10 17:54:56 +02:00
zhaozhao.zz
72d64eb653
zset: change the span of zskiplistNode to unsigned long
2017-12-08 16:09:27 +08:00
zhaozhao.zz
93512e13a0
zset: fix the int problem
2017-12-08 15:37:08 +08:00