Ponnuvel Palaniyappan
dafb94db79
Fix a potential overflow with strncpy
2020-02-27 18:02:30 +01:00
antirez
ea697b6345
Improve aeDeleteEventLoop() top comment grammar.
2020-02-27 18:02:30 +01:00
wangyuan21
dd4798802c
free time event when delete eventloop
2020-02-27 18:02:30 +01:00
srzhao
ecf3b2ef32
fix impl of aof-child whitelist SIGUSR1 feature.
2020-02-27 18:02:30 +01:00
meir@redislabs.com
2966132c52
Changed log level for module fork api from 'notice' to 'verbos'.
2020-02-27 18:02:30 +01:00
hwware
7277e5d8a8
format fix
2020-02-27 18:02:30 +01:00
hwware
1bb5ee9c68
fix potentical memory leaks
2020-02-27 18:02:30 +01:00
Hengjian Tang
973297336f
modify the read buf size according to the write buf size PROTO_IOBUF_LEN defined before
2020-02-27 18:02:30 +01:00
Ariel
15ea13245a
fix ThreadSafeContext lock/unlock function names
2020-02-27 18:02:30 +01:00
Guy Benoish
4d12c37c54
XREADGROUP should propagate XCALIM/SETID in MULTI/EXEC
...
Use built-in alsoPropagate mechanism that wraps commands
in MULTI/EXEC before sending them to replica/AOF
2020-02-27 18:02:30 +01:00
Guy Benoish
2ecab0b63a
Modules: Do not auto-unblock clients if not blocked on keys
2020-02-27 18:02:30 +01:00
antirez
b439542604
Tracking: optin/out implemented.
2020-02-27 18:02:30 +01:00
hwware
ba0270799e
add missing subcommand description for debug oom
2020-02-27 18:00:47 +01:00
Madelyn Olson
d1f22eaca4
Give an error message if you specify redirect twice
2020-02-27 18:00:47 +01:00
Madelyn Olson
762fbcb687
Minor CSC fixes and fixed documentation
2020-02-27 18:00:47 +01:00
Oran Agra
349aa24511
Defrag big lists in portions to avoid latency and freeze
...
When active defrag kicks in and finds a big list, it will create a bookmark to
a node so that it is able to resume iteration from that node later.
The quicklist manages that bookmark, and updates it in case that node is deleted.
This will increase memory usage only on lists of over 1000 (see
active-defrag-max-scan-fields) quicklist nodes (1000 ziplists, not 1000 items)
by 16 bytes.
In 32 bit build, this change reduces the maximum effective config of
list-compress-depth and list-max-ziplist-size (from 32767 to 8191)
2020-02-27 18:00:47 +01:00
Guy Benoish
b4ddc7b7ba
XGROUP DESTROY should unblock XREADGROUP with -NOGROUP
2020-02-27 18:00:47 +01:00
hayashier
73806f74ca
fix typo from fss to rss
2020-02-27 18:00:47 +01:00
antirez
f15fb727a0
Tracking: fix max-keys configuration directive.
2020-02-27 18:00:46 +01:00
Itamar Haber
e374573f30
Fixes segfault on calling trackingGetTotalKeys
...
... with CSC disabled
2020-02-27 18:00:46 +01:00
antirez
73d47d5749
Signal key as modified when expired on-access.
...
This fixes WATCH and client side caching with keys expiring because of
a synchronous access and not because of background expiring.
2020-02-27 18:00:46 +01:00
antirez
1db7257107
Tracking: fix operators precedence error in bcast check.
2020-02-27 17:59:57 +01:00
antirez
fe96e29d5f
Tracking: fix behavior when switchinig from normal to BCAST.
2020-02-27 17:59:57 +01:00
antirez
f21be1ec55
Tracking: fix sending messages bug + tracking off bug.
2020-02-27 17:59:57 +01:00
antirez
6fb1aa2381
Tracking: BCAST: basic feature now works.
2020-02-27 17:59:57 +01:00
antirez
d4fe79a174
Tracking: BCAST: broadcasting of keys in prefixes implemented.
2020-02-27 17:59:57 +01:00
antirez
abb81c6351
Tracking: BCAST: registration in the prefix table.
2020-02-27 17:59:57 +01:00
antirez
77da960815
Tracking: BCAST: parsing of the options + skeleton.
2020-02-27 17:59:57 +01:00
antirez
3e8c69a9de
Tracking: always reply with an array of keys.
2020-02-27 17:59:57 +01:00
antirez
a788c373e6
Tracking: minor change of names and new INFO field.
2020-02-27 17:59:57 +01:00
antirez
df83892760
Rax.c: populate data field after random walk.
2020-02-27 17:59:57 +01:00
antirez
0517da3618
Tracking: rename INFO field with total items.
2020-02-27 17:59:57 +01:00
antirez
3c16d6b32d
Tracking: first conversion from hashing to key names.
2020-02-27 17:59:57 +01:00
Oran Agra
3b4f147775
add no-slowlog option to RM_CreateCommand
2020-02-27 17:59:57 +01:00
Khem Raj
5e762d847c
Mark extern definition of SDS_NOINIT in sds.h
...
This helps in avoiding multiple definition of this variable, its also
defined globally in sds.c
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2020-02-12 14:17:54 +01:00
lifubang
54f5499aee
correct help info for --user and --pass
...
Signed-off-by: lifubang <lifubang@acmcoder.com>
2020-02-12 14:17:54 +01:00
Guy Benoish
dd34f70368
Diskless-load emptyDb-related fixes
...
1. Call emptyDb even in case of diskless-load: We want modules
to get the same FLUSHDB event as disk-based replication.
2. Do not fire any module events when flushing the backups array.
3. Delete redundant call to signalFlushedDb (Called from emptyDb).
2020-02-12 14:17:54 +01:00
lifubang
5e042dbc05
fix ssl flag check for redis-cli
...
Signed-off-by: lifubang <lifubang@acmcoder.com>
2020-02-12 14:17:54 +01:00
Guy Benoish
dcbe8bfad1
Exclude "keymiss" notification from NOTIFY_ALL
...
Because "keymiss" is "special" compared to the rest of
the notifications (Trying not to break existing apps
using the 'A' format for notifications)
Also updated redis.conf and module.c docs
2020-02-12 14:17:54 +01:00
Oran Agra
36caf2e42b
update RM_SignalModifiedKey doc comment
2020-02-12 14:17:40 +01:00
Oran Agra
3067352a8d
Add handling of short read of module id in rdb
2020-02-12 14:17:40 +01:00
Oran Agra
4440133e9a
A few non-data commands that should be allowed while loading or stale
...
SELECT, and HELLO are commands that may be executed by the client
as soon as it connects, there's no reason to block them, preventing the
client from doing the rest of his sequence (which might just be INFO or
CONFIG, etc).
MONITOR, DEBUG, SLOWLOG, TIME, LASTSAVE are all non-data accessing
commands, which there's no reason to block.
2020-02-12 14:17:40 +01:00
Oran Agra
c957794144
Memory leak when bind config is provided twice
2020-02-12 14:17:40 +01:00
Oran Agra
1333a46b7e
fix maxmemory config warning
...
the warning condition was if usage > limit (saying it'll cause eviction
or oom), but in fact the eviction and oom depends on used minus slave
buffers.
other than fixing the condition, i add info about the current usage and
limit, which may be useful when looking at the log.
2020-02-12 14:17:40 +01:00
Oran Agra
8e7282eb3e
Fix client flags to be int64 in module.c
...
currently there's no bug since the flags these functions handle are
always lower than 32bit, but still better fix the type to prevent future
bugs.
2020-02-12 14:17:40 +01:00
Oran Agra
a678390e52
moduleRDBLoadError, add key name, and use panic rather than exit
...
using panic rather than exit means you get s stack trace of the code
path that experianced the error, and possibly other info.
2020-02-12 14:17:40 +01:00
Oran Agra
919fbf421d
reduce repeated calls to use_diskless_load
...
this function possibly iterates on the module list
2020-02-12 14:15:56 +01:00
Oran Agra
22e45d46fe
freeClientAsync don't lock mutex if there's just one thread
2020-02-12 14:15:56 +01:00
Oran Agra
ba28924418
move restartAOFAfterSYNC from replicaofCommand to replicationUnsetMaster
...
replicationUnsetMaster can be called from other places, not just
replicaofCOmmand, and all of these need to restart AOF
2020-02-12 14:15:56 +01:00
Oran Agra
f42ce57d0f
stopAppendOnly resets aof_rewrite_scheduled
...
althouh in theory, users can do BGREWRITEAOF even if aof is disabled, i
suppose it is more common that the scheduled flag is set by either
startAppendOnly, of a failed initial AOFRW fork (AOF_WAIT_REWRITE)
2020-02-12 14:15:56 +01:00