gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
10,861 Commits 1 Branch 0 Tags
Commit Graph

7858 Commits

Author SHA1 Message Date
antirez
45ba72ad01 Explain why we allow transactions in -BUSY state. 
Related to #7022.
 2020-03-25 15:55:24 +01:00
Oran Agra
e1e2f91589 MULTI/EXEC during LUA script timeout are messed up 
Redis refusing to run MULTI or EXEC during script timeout may cause partial
transactions to run.

1) if the client sends MULTI+commands+EXEC in pipeline without waiting for
response, but these arrive to the shards partially while there's a busy script,
and partially after it eventually finishes: we'll end up running only part of
the transaction (since multi was ignored, and exec would fail).

2) similar to the above if EXEC arrives during busy script, it'll be ignored and
the client state remains in a transaction.

the 3rd test which i added for a case where MULTI and EXEC are ok, and
only the body arrives during busy script was already handled correctly
since processCommand calls flagTransaction
 2020-03-25 15:55:24 +01:00
antirez
484a14ebde Improve comments of replicationCacheMasterUsingMyself(). 2020-03-25 15:55:24 +01:00
antirez
4cfceac287 Fix BITFIELD_RO test. 2020-03-25 15:55:24 +01:00
antirez
6a1a5cb2a1 Abort transactions after -READONLY error. Fix #7014. 2020-03-25 15:55:24 +01:00
antirez
243b26d97d Minor changes to BITFIELD_RO PR #6951. 2020-03-25 15:55:24 +01:00
bodong.ybd
015d1cb2ff Added BITFIELD_RO variants for read-only operations. 2020-03-25 15:55:24 +01:00
antirez
5a13e0feb1 Modules: updated function doc after #7003. 2020-03-25 15:55:24 +01:00
Guy Benoish
6680c06705 Allow RM_GetContextFlags to work with ctx==NULL 2020-03-25 15:55:24 +01:00
hwware
2dcae61087 fix potentical memory leak in redis-cli 2020-03-25 15:55:24 +01:00
Yossi Gottlieb
700126e9cf Fix crashes related to failed/rejected accepts. 2020-03-25 15:55:24 +01:00
Yossi Gottlieb
1f1d642e01 Cluster: fix misleading accept errors. 2020-03-25 15:55:24 +01:00
Yossi Gottlieb
1a948d0c5b Conns: Fix connClose() / connAccept() behavior. 
We assume accept handlers may choose to reject a connection and close
it, but connAccept() callers can't distinguish between this state and
other error states requiring connClose().

This makes it safe (and mandatory!) to always call connClose() if
connAccept() fails, and safe for accept handlers to close connections
(which will defer).
 2020-03-25 15:55:24 +01:00
hwware
4a0249c0c8 remove redundant Semicolon 2020-03-25 15:55:24 +01:00
hwware
9c9ef6fb9b clean CLIENT_TRACKING_CACHING flag when disabled caching 2020-03-25 15:55:24 +01:00
hwware
04d838274f add missing commands in cluster help 2020-03-25 15:55:24 +01:00
artix
5ccdb7a5be Support Redis Cluster Proxy PROXY INFO command 2020-03-25 15:55:24 +01:00
antirez
07c75f60f3 Restore newline at the end of redis-cli.c 2020-03-25 15:54:34 +01:00
chendianqiang
1994eda07e use correct list for moduleUnregisterUsedAPI 2020-03-25 15:54:34 +01:00
fengpf
e8c11fe29d fix comments in latency.c 2020-03-25 15:54:34 +01:00
WuYunlong
37c6571a6c Fix master replica inconsistency for upgrading scenario. 
Before this commit, when upgrading a replica, expired keys will not
be loaded, thus causing replica having less keys in db. To this point,
master and replica's keys is logically consistent. However, before
the keys in master and replica are physically consistent, that is,
they have the same dbsize, if master got a problem and the replica
got promoted and becomes new master of that partition, and master
updates a key which does not exist on master, but physically exists
on the old master(new replica), the old master would refuse to update
the key, thus causing master and replica data inconsistent.

How could this happen?
That's all because of the wrong judgement of roles while starting up
the server. We can not use server.masterhost to judge if the server
is master or replica, since it fails in cluster mode.

When we start the server, we load rdb and do want to load expired keys,
and do not want to have the ability to active expire keys, if it is
a replica.
 2020-03-25 15:54:34 +01:00
guodongxiaren
0fd48a7c53 string literal should be const char* 2020-03-25 15:54:34 +01:00
Itamar Haber
2eec521f8c Adds keyspace notifications to migrate and restore 2020-03-25 15:54:34 +01:00
bodong.ybd
a8f56fbfcd Remove duplicate obj files in Makefile 2020-03-25 15:54:34 +01:00
antirez
21c22bcd9a ACL: default user off should not allow automatic authentication. 
This fixes issue #7011.
 2020-03-25 15:54:34 +01:00
antirez
d9f9a29afa ACL: Make Redis 6 more backward compatible with requirepass. 
Note that this as a side effect fixes Sentinel "requirepass" mode.
 2020-03-25 15:54:34 +01:00
antirez
31707f25c7 Sentinel: implement auth-user directive for ACLs. 2020-03-25 15:54:34 +01:00
zhaozhao.zz
714ae38ee1 Threaded IO: bugfix client kill may crash redis 2020-03-25 15:54:34 +01:00
zhaozhao.zz
db4f03bc51 Threaded IO: handle pending reads clients ASAP after event loop 2020-03-25 15:54:34 +01:00
antirez
352ea2365f Aesthetic changes in PR #6989. 2020-03-25 15:54:34 +01:00
zhaozhao.zz
d3491c5182 Threaded IO: bugfix #6988 process events while blocked 2020-03-25 15:54:34 +01:00
John Sully
41dfd175a8 Fix failure to load subkey expires 
Former-commit-id: 528a43bd6c80f073d928dd18c4f67f37cfd0977a
 2020-03-25 01:38:58 -04:00
John Sully
9ff5d3f3c4 Expire entry needs to be resorted after a subkey expires 
Former-commit-id: b357803362728c26a1169e3cec279c693b86205b
 2020-03-25 01:06:40 -04:00
John Sully
982175b584 Evict on load if we have a storage provider 
Former-commit-id: bb091796c3da7282e040c7b72a28ec1c5f5ecfb7
 2020-03-24 14:49:43 -04:00
John Sully
aed3d33499 Prevent issue where count can be out of sync temporarily, causing crashes where we expect the count to be perfect 
Former-commit-id: 77c9f36413c6f0cbb0b13a7ec746746c97faadcd
 2020-03-24 00:21:12 -04:00
John Sully
ad8a61697b Fix OOM errors during forkless bgsave 
Former-commit-id: c31c64b13409c741e8d52ad06add78300c39fce2
 2020-03-23 23:12:10 -04:00
John Sully
2b199b384d Unstable branch should always be version 0.0.0 
Former-commit-id: 448808529ab9e9e4705c2e7cbda5b3e6523b7c6f
 2020-03-19 15:52:24 -04:00
John Sully
436ffa98de Merge branch 'RELEASE_5' into unstable 
Former-commit-id: a0bc2084128f991697d3e1b7473d14c55afdd785
 2020-03-19 15:38:16 -04:00
John Sully
4f55afa948 Print stack traces of other threads in the deadlock detector 
Former-commit-id: 6b0172b9bf124372f4c8688c91c380c6c1b607c7
 2020-03-19 15:37:49 -04:00
John Sully
833f5b39f4 Log which thread a message came from 
Former-commit-id: bc1eccb66d3302d6c99588fb4a5a879e1ef243b1
 2020-03-19 15:37:24 -04:00
John Sully
1b9ef774da Fix lock inversion in processEventsWhileBlocked 
Former-commit-id: a9249d4a82a0f0355ac8ffa40b34b9c14cabf66b
 2020-03-19 15:28:39 -04:00
John Sully
96be5f6a6c Prevent dangling lock when we can't free the client 
Former-commit-id: 3c373494d63b21744b264f0a47e6999bcdda6b2b
 2020-03-19 14:34:23 -04:00
John Sully
b0dceb9410 Merge branch 'keydbpro' into PRO_RELEASE_6 
Former-commit-id: 23c3316c10f2771bc26e50698b48934ec7549bcd
 2020-03-17 17:47:55 -04:00
John Sully
a767ba8447 Special case version 0.0.0 which is equal to any version 
Former-commit-id: 869d037490b6905674f75a8552898aed72148558
 2020-03-17 17:25:36 -04:00
John Sully
b25ac5e6c1 Merge branch 'keydbpro' into PRO_RELEASE_6 
Former-commit-id: dd8339da10c17f0e2f238310a10e97395f8f12ac
 2020-03-17 17:11:51 -04:00
John Sully
9ae07e994d Cache count of keys in database 
Former-commit-id: 7cd266030ad82b5fddd4668d666adc95e1bed475
 2020-03-17 17:11:41 -04:00
John Sully
0249ff44a5 Merge branch 'redis_6_merge' into keydbpro 
Former-commit-id: ff3190cac5c5d222904aa2d57d97c752c1b7e554
 2020-03-17 00:10:09 -04:00
John Sully
e800858c4c Merge branch 'unstable' into redis_6_merge 
Former-commit-id: 40761e403166bf3342fe388ab742498f99245b1a
 2020-03-17 00:09:48 -04:00
John Sully
72f6847f95 Fix issue #153: Config get replicaof returns a corrupt response 
Former-commit-id: 5aef606d3bc1d748ca8d2df1d36feccaa2e583c0
 2020-03-16 20:43:46 -04:00
John Sully
b1356bb175 Merge branch 'redis_6_merge' into keydbpro 
Former-commit-id: aea8413a15001e2c27cf03dd41fa15151b0d3ccb
 2020-03-15 18:48:45 -04:00