gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
14,683 Commits 1 Branch 0 Tags
Commit Graph

14683 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Oran Agra
ac2c96f5b1 A few non-data commands that should be allowed while loading or stale 
SELECT, and HELLO are commands that may be executed by the client
as soon as it connects, there's no reason to block them, preventing the
client from doing the rest of his sequence (which might just be INFO or
CONFIG, etc).

MONITOR, DEBUG, SLOWLOG, TIME, LASTSAVE are all non-data accessing
commands, which there's no reason to block.
 2020-02-06 08:53:23 +02:00
Yossi Gottlieb
bb3d45a386 TLS: Update documentation. 2020-02-05 21:19:03 +02:00
Oran Agra
fe7e8dc955 Add handling of short read of module id in rdb 2020-02-05 19:47:09 +02:00
Salvatore Sanfilippo
edfe1b2f8b
Merge pull request #6839 from yossigo/fix/redis-conf-tls-clarifications 
TLS: Some redis.conf clarifications.
 2020-02-05 17:33:21 +01:00
Yossi Gottlieb
1e02d599dc TLS: Some redis.conf clarifications. 2020-02-05 18:30:12 +02:00
Oran Agra
3795aaf42a update RM_SignalModifiedKey doc comment 2020-02-05 18:15:38 +02:00
Oran Agra
774d8cd721 Optimize temporary memory allocations for getKeysFromCommand mechanism 
now that we may use it more often (ACL), these excessive calls to malloc
and free can become an overhead.
 2020-02-05 18:06:33 +02:00
Salvatore Sanfilippo
44ac202fbf
Merge pull request #6831 from oranagra/config_c_refactor_3 
config.c verbose error replies for CONFIG SET, like config file parsing
 2020-02-05 13:41:15 +01:00
Salvatore Sanfilippo
4abf0e1e10
Merge pull request #6829 from oranagra/memory_get_keys 
memoryGetKeys helper function so that ACL can limit access to keys for MEMORY command
 2020-02-05 13:33:18 +01:00
Oran Agra
ffdd0620d0 config.c verbose error replies for CONFIG SET, like config file parsing 
We noticed that the error replies for the generic mechanism for enums
are very verbose for config file parsing, but not for config set
command.

instead of replicating this code, i did a small refactoring to share
code between CONFIG SET and config file parsing.

and also renamed the enum group functions to be consistent with the
naming of other types.
 2020-02-05 11:41:24 +02:00
Oran Agra
9ac6cb9ce4 memoryGetKeys helper function so that ACL can limit access to keys for MEMORY command 2020-02-05 09:42:49 +02:00
Guy Benoish
1c7a2269d6 Add RM_CreateStringFromDouble 2020-02-04 19:28:09 +05:30
antirez
90fae58b49 ACL LOG: make max log entries configurable. 2020-02-04 13:19:40 +01:00
antirez
64a73e9293 ACL LOG: test for AUTH reason. 2020-02-04 12:58:48 +01:00
antirez
0c1a4b5576 ACL LOG: log failed auth attempts. 2020-02-04 12:55:26 +01:00
lifubang
540b917a26 fix ssl flag check for redis-cli 
Signed-off-by: lifubang <lifubang@acmcoder.com>
 2020-02-04 17:32:30 +08:00
Guy Benoish
6fe55c2f29 ld2string should fail if string contains \0 in the middle 
This bug affected RM_StringToLongDouble and HINCRBYFLOAT.
I added tests for both cases.

Main changes:
1. Fixed string2ld to fail if string contains \0 in the middle
2. Use string2ld in getLongDoubleFromObject - No point of
   having duplicated code here

The two changes above broke RM_SaveLongDouble/RM_LoadLongDouble
because the long double string was saved with length+1 (An innocent
mistake, but it's actually a bug - The length passed to
RM_SaveLongDouble should not include the last \0).
 2020-02-04 10:23:48 +01:00
Leo Murillo
f7a94526dd Set ZSKIPLIST_MAXLEVEL to optimal value given 2^64 elements and p=0.25 2020-02-04 10:23:48 +01:00
antirez
bbce3ba974 Add more info in the unblockClientFromModule() function. 2020-02-04 10:23:48 +01:00
WuYunlong
eecfa9793e Fix lua related memory leak. 2020-02-04 10:23:48 +01:00
Guy Benoish
40295fb3fe Modules: Fix blocked-client-related memory leak 
If a blocked module client times-out (or disconnects, unblocked
by CLIENT command, etc.) we need to call moduleUnblockClient
in order to free memory allocated by the module sub-system
and blocked-client private data

Other changes:
Made blockedonkeys.tcl tests a bit more aggressive in order
to smoke-out potential memory leaks
 2020-02-04 10:23:48 +01:00
WuYunlong
d2509811b7 Add tcl regression test in scripting.tcl to reproduce memory leak. 2020-02-04 10:23:48 +01:00
Yossi Gottlieb
29d4a1502a TLS: Fix missing initialization in redis-cli. 2020-02-04 10:23:48 +01:00
Oran Agra
ec0c61da05 fix uninitialized info_cb var in module.c 2020-02-04 10:23:48 +01:00
Salvatore Sanfilippo
cfe39b7859
Merge pull request #6818 from leomurillo/zskiplistLevels 
Set ZSKIPLIST_MAXLEVEL to 32
 2020-02-04 10:20:56 +01:00
Salvatore Sanfilippo
6ca1ad1e27
Merge pull request #6825 from trevor211/fixMemoryLeakAboutLuaScript 
Fix memory leak about lua script
 2020-02-04 10:19:16 +01:00
WuYunlong
eb2196f5ce Fix lua related memory leak. 2020-02-04 16:38:46 +08:00
WuYunlong
01eaf53bb3 Add tcl regression test in scripting.tcl to reproduce memory leak. 2020-02-04 16:34:11 +08:00
John Sully
46506b3e53 module fixes 
Former-commit-id: ef4e11ecb8a6f1a05bb21f014120b0ef9e771b60
 2020-02-04 01:22:25 -05:00
John Sully
0a07ce9d6d rename to pro binary 
Former-commit-id: a8854bfd83de72d6aa418ee6d9b44fae1f622787
 2020-02-04 00:30:13 -05:00
John Sully
a4917a6587 Merge branch 'keydbpro' into PRO_RELEASE_6 
Former-commit-id: 055eaa99ab918609f4ac6b533da3067e5e32a170
 2020-02-03 20:16:20 -05:00
John Sully
98d15c7d14 Ensure create-cluster launches pro 
Former-commit-id: 8b3773805d2208070e807ede219821c524495c34
 2020-02-03 20:15:59 -05:00
John Sully
2bf1648e04 Bump version 
Former-commit-id: ac84153f61b213d42ad503ac38948f9740a5f923
 2020-02-03 20:01:53 -05:00
John Sully
dcfd0472ed Merge branch 'unstable' into keydbpro 
Former-commit-id: 0db79c793e30ab268cb0f771928468e477e3b8da
 2020-02-03 20:00:16 -05:00
John Sully
c2eb10c322 Fix cluster test failures from Redis 6 merge 
Former-commit-id: fd702e43f19ac2b8097afef84a73c8e71172979b
 2020-02-03 20:00:09 -05:00
John Sully
0dfa45b2af Build portable rocksdb binaries 
Former-commit-id: e94db969f8ac584b75b2ad015b65c1d0d73d0776
 2020-02-03 17:33:15 -05:00
John Sully
2ee97b5bb5 Fix failure to save RDB on shutdown 
Former-commit-id: 1a8331c88a17deaa5faf34c7ea65957c57530546
 2020-02-03 16:00:01 -05:00
Salvatore Sanfilippo
2400f5782e
Merge pull request #6808 from yossigo/fix/redis-cli-openssl-1.0.x 
TLS: Fix missing initialization in redis-cli.
 2020-02-03 16:43:56 +01:00
Salvatore Sanfilippo
726abe4deb
Merge pull request #6824 from oranagra/fix_module_c_uninit_var 
fix uninitialized info_cb var in module.c
 2020-02-03 15:46:13 +01:00
Oran Agra
138ed120dd fix uninitialized info_cb var in module.c 2020-02-03 16:35:39 +02:00
Guy Benoish
2fda5f5c98 Exclude "keymiss" notification from NOTIFY_ALL 
Because "keymiss" is "special" compared to the rest of
the notifications (Trying not to break existing apps
using the 'A' format for notifications)

Also updated redis.conf and module.c docs
 2020-02-03 15:43:44 +05:30
John Sully
9e4233207e Optimize bgsave snapshotting 
Former-commit-id: 15b4bf003537fe6fd926146f46d38203683846be
 2020-02-02 23:42:44 -05:00
John Sully
0ac4c6b5ec 3 fixes, 0 array access on boot, getAsync is useless on single theaded, and don't print COW info for BG thread work since it will be inaccurate 
Former-commit-id: 09362ff44afed8525816437aead84f215eb59c36
 2020-02-02 23:30:42 -05:00
John Sully
70994b5a07 RDB thread cleanup fixes 
Former-commit-id: 3e30cf6de930c40c3a1c63a761b2018836d4ae52
 2020-02-02 23:29:20 -05:00
John Sully
a532e49dc2 Handle case where src dict is larger in dictMerge 
Former-commit-id: c750fdb381f5dd3e92d251a82bd86533eb2cadf5
 2020-02-02 23:27:25 -05:00
Leo Murillo
560e1e6c4b Set ZSKIPLIST_MAXLEVEL to optimal value given 2^64 elements and p=0.25 2020-02-02 02:48:00 -06:00
John Sully
d8dcb94e37 endSnapshotAsync implementation (fails tests w/ multithreading) 
Former-commit-id: b401e9fcae40cf1d4e4c1584f57e760d9adf36a9
 2020-02-01 22:28:24 -05:00
John Sully
a223fb7bed Merge branch 'unstable' into keydbpro 
Former-commit-id: 53b36801cede2dbebbf33ec665af69f810b438d5
 2020-02-01 21:52:26 -05:00
John Sully
2c899d7219 addRef memory model too restrictive 
Former-commit-id: 249e0fdd363853ab7b489314002bdacd2438fa55
 2020-02-01 21:52:17 -05:00
John Sully
2bc0075623 use dictMerge() in endSnapshot for speed and cleaner code 
Former-commit-id: ed8e10234e4499506f2557b0858dba86c30c9dc0
 2020-02-01 21:08:26 -05:00