gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
27,626 Commits 1 Branch 0 Tags
Commit Graph

21065 Commits

Author SHA1 Message Date
ShooterIT
8af1e513f6 Implements sendfile for redis. 2020-05-25 12:08:01 +02:00
antirez
ed3fd6c524 Fix #7306 less aggressively. 
Citing from the issue:

btw I suggest we change this fix to something else:
* We revert the fix.
* We add a call that disconnects chained replicas in the place where we trim the replica (that is a master i this case) offset.
This way we can avoid disconnections when there is no trimming of the backlog.

Note that we now want to disconnect replicas asynchronously in
disconnectSlaves(), because it's in general safer now that we can call
it from freeClient(). Otherwise for instance the command:

    CLIENT KILL TYPE master

May crash: clientCommand() starts running the linked of of clients,
looking for clients to kill. However it finds the master, kills it
calling freeClient(), but this in turn calls replicationCacheMaster()
that may also call disconnectSlaves() now. So the linked list iterator
of the clientCommand() will no longer be valid.
 2020-05-25 12:08:01 +02:00
antirez
3c21418cd8 Fix #7306 less aggressively. 
Citing from the issue:

btw I suggest we change this fix to something else:
* We revert the fix.
* We add a call that disconnects chained replicas in the place where we trim the replica (that is a master i this case) offset.
This way we can avoid disconnections when there is no trimming of the backlog.

Note that we now want to disconnect replicas asynchronously in
disconnectSlaves(), because it's in general safer now that we can call
it from freeClient(). Otherwise for instance the command:

    CLIENT KILL TYPE master

May crash: clientCommand() starts running the linked of of clients,
looking for clients to kill. However it finds the master, kills it
calling freeClient(), but this in turn calls replicationCacheMaster()
that may also call disconnectSlaves() now. So the linked list iterator
of the clientCommand() will no longer be valid.
 2020-05-25 12:08:01 +02:00
antirez
1bf75eaca7 Clarify what is happening in PR #7320. 2020-05-25 11:47:38 +02:00
antirez
92a3ff6168 Clarify what is happening in PR #7320. 2020-05-25 11:47:38 +02:00
Maxime de Roucy
c0f60008cb acl: @replication command group 
containing mandatory commands for replication (used by masteruser user)


Former-commit-id: 123bc125cfe7b30fdeef833759a33ccc854b5c51
 2020-05-25 02:35:22 -04:00
Maxime de Roucy
b9b4b4cfde acl: @replication command group 
containing mandatory commands for replication (used by masteruser user)


Former-commit-id: 123bc125cfe7b30fdeef833759a33ccc854b5c51
 2020-05-25 02:35:22 -04:00
John Sully
4bb5c35548 Fix issue #170. Intermittent crash destroying fastlock due to implicit type conversion in assert 
Former-commit-id: ecbe168b5421687899a621c995e44f43faec2b71
 2020-05-25 02:13:57 -04:00
John Sully
c15802af8b Fix issue #170. Intermittent crash destroying fastlock due to implicit type conversion in assert 
Former-commit-id: ecbe168b5421687899a621c995e44f43faec2b71
 2020-05-25 02:13:57 -04:00
zhaozhao.zz
dd7739f314 PSYNC2: second_replid_offset should be real meaningful offset 
After adjustMeaningfulReplOffset(), all the other related variable
should be updated, including server.second_replid_offset.

Or the old version redis like 5.0 may receive wrong data from
replication stream, cause redis 5.0 can sync with redis 6.0,
but doesn't know meaningful offset.
 2020-05-25 11:17:54 +08:00
zhaozhao.zz
eec769be59 PSYNC2: second_replid_offset should be real meaningful offset 
After adjustMeaningfulReplOffset(), all the other related variable
should be updated, including server.second_replid_offset.

Or the old version redis like 5.0 may receive wrong data from
replication stream, cause redis 5.0 can sync with redis 6.0,
but doesn't know meaningful offset.
 2020-05-25 11:17:54 +08:00
John Sully
9a357ec4b5 Fix infinite logs of Error in rreplay 
Former-commit-id: 00cef78858cd05fc067fa5002f2995653452c63f
 2020-05-24 20:05:22 -04:00
John Sully
fa671d5193 Fix infinite logs of Error in rreplay 
Former-commit-id: 00cef78858cd05fc067fa5002f2995653452c63f
 2020-05-24 20:05:22 -04:00
John Sully
845027c291 Enable TLS connections 
Former-commit-id: d05da0fabdfeb7eadce6546c7c1d85739b2794d7
 2020-05-24 19:57:16 -04:00
John Sully
fcfff165da Enable TLS connections 
Former-commit-id: d05da0fabdfeb7eadce6546c7c1d85739b2794d7
 2020-05-24 19:57:16 -04:00
John Sully
2857bed8bd bump version 
Former-commit-id: 9353b3aac2ab65120f2ad5caa2f8272ae02df380
 2020-05-24 18:35:03 -04:00
John Sully
5a669218eb bump version 
Former-commit-id: 9353b3aac2ab65120f2ad5caa2f8272ae02df380
 2020-05-24 18:35:03 -04:00
John Sully
9267a55e42 Merge branch 'keydbpro' into PRO_RELEASE_6 
Former-commit-id: 056c672cf60a00980cb10e97fc5da93d8eada937
 2020-05-24 18:34:15 -04:00
John Sully
c4d524df9c Merge branch 'keydbpro' into PRO_RELEASE_6 
Former-commit-id: 056c672cf60a00980cb10e97fc5da93d8eada937
 2020-05-24 18:34:15 -04:00
John Sully
25f0bdf527 Fix test failures 
Former-commit-id: c0b2263478d79f33d04ed409a68caa312884fa4c
 2020-05-24 18:33:15 -04:00
John Sully
15bf66b922 Fix test failures 
Former-commit-id: c0b2263478d79f33d04ed409a68caa312884fa4c
 2020-05-24 18:33:15 -04:00
John Sully
7db546130f Fix crash on shutdown with snapshots pending 
Former-commit-id: 124e79a81d6995ea7d5ba39d1830b591b705acbf
 2020-05-24 17:11:56 -04:00
John Sully
69b550d91a Fix crash on shutdown with snapshots pending 
Former-commit-id: 124e79a81d6995ea7d5ba39d1830b591b705acbf
 2020-05-24 17:11:56 -04:00
John Sully
e0a0d93a07 Merge branch 'unstable' into keydbpro 
Former-commit-id: a830cf85df236885558c5571c0bf23cfb23e3655
 2020-05-24 14:41:53 -04:00
John Sully
cece963cf3 Merge branch 'unstable' into keydbpro 
Former-commit-id: a830cf85df236885558c5571c0bf23cfb23e3655
 2020-05-24 14:41:53 -04:00
John Sully
d176ae50ec don't keep feeding data to clients pending close 
Former-commit-id: 4db3f2a443a6f71d1486781005ee37546e89d6e1
 2020-05-24 12:46:11 -04:00
John Sully
0a1d2c99ac don't keep feeding data to clients pending close 
Former-commit-id: 4db3f2a443a6f71d1486781005ee37546e89d6e1
 2020-05-24 12:46:11 -04:00
John Sully
5c35593937 Quiet TSAN during exit 
Former-commit-id: fd710d590a6297b74e06ce6832dd75bfca0a266f
 2020-05-24 12:45:10 -04:00
John Sully
975ca828d4 Quiet TSAN during exit 
Former-commit-id: fd710d590a6297b74e06ce6832dd75bfca0a266f
 2020-05-24 12:45:10 -04:00
John Sully
7630b63f06 Hold the AE lock until we process the repl backlog after a command 
Former-commit-id: 4893eedacbf5f9210d02361ed07b9beee0c9f655
 2020-05-24 11:19:23 -04:00
John Sully
23e1601276 Hold the AE lock until we process the repl backlog after a command 
Former-commit-id: 4893eedacbf5f9210d02361ed07b9beee0c9f655
 2020-05-24 11:19:23 -04:00
John Sully
0d8c7c7182 Add standardized way to post client dependent functions 
Former-commit-id: fb50163b47cf660911dc7f67809c15ba1394613a
 2020-05-24 02:46:39 -04:00
John Sully
b892d3deff Add standardized way to post client dependent functions 
Former-commit-id: fb50163b47cf660911dc7f67809c15ba1394613a
 2020-05-24 02:46:39 -04:00
John Sully
65e4f82982 remove unnecessary cplusplus guard 
Former-commit-id: 3b8463f9d20162369cffd9ed347865c5c8049f40
 2020-05-24 02:45:55 -04:00
John Sully
f517eaf182 remove unnecessary cplusplus guard 
Former-commit-id: 3b8463f9d20162369cffd9ed347865c5c8049f40
 2020-05-24 02:45:55 -04:00
John Sully
0dd0ea7eda race in connection state when setting a handler on a different thread 
Former-commit-id: 42c7677690c434168135992429f7521239475ef8
 2020-05-24 02:45:11 -04:00
John Sully
78b647bd6f race in connection state when setting a handler on a different thread 
Former-commit-id: 42c7677690c434168135992429f7521239475ef8
 2020-05-24 02:45:11 -04:00
John Sully
d3bd1ab56b Fix ASAN races 
Former-commit-id: 8665f250314c4e3de32f3b31a2c0158908ef982b
 2020-05-24 01:58:33 -04:00
John Sully
dc27b95a47 Fix ASAN races 
Former-commit-id: 8665f250314c4e3de32f3b31a2c0158908ef982b
 2020-05-24 01:58:33 -04:00
John Sully
4136a1084b Incorrect locking in replication error paths 
Former-commit-id: 1c6b57314747787958ad215826296627f9050f59
 2020-05-24 01:57:49 -04:00
John Sully
cc080de221 Incorrect locking in replication error paths 
Former-commit-id: 1c6b57314747787958ad215826296627f9050f59
 2020-05-24 01:57:49 -04:00
John Sully
2ea5bf4f55 Incorrect memory order on weak ordered architectures 
Former-commit-id: 90162da1a6c025d148a0d1761ae4d5fbc9bfc0ef
 2020-05-24 01:57:18 -04:00
John Sully
51976e2be8 Incorrect memory order on weak ordered architectures 
Former-commit-id: 90162da1a6c025d148a0d1761ae4d5fbc9bfc0ef
 2020-05-24 01:57:18 -04:00
John Sully
dde860c60b If we request shutdown from a client on a different thread than a blocking lua script we fail to actually shutdown until the script completes 
Former-commit-id: 1ca6c1dd56131bc28fe9f831e2b9cab7adb846a3
 2020-05-24 01:56:23 -04:00
John Sully
926da1f899 If we request shutdown from a client on a different thread than a blocking lua script we fail to actually shutdown until the script completes 
Former-commit-id: 1ca6c1dd56131bc28fe9f831e2b9cab7adb846a3
 2020-05-24 01:56:23 -04:00
John Sully
aaff167eb9 race calculating client overhead 
Former-commit-id: 2d27c8ecdb5242284301f135b1d542f9ead5b8f2
 2020-05-24 01:53:43 -04:00
John Sully
de376acb15 race calculating client overhead 
Former-commit-id: 2d27c8ecdb5242284301f135b1d542f9ead5b8f2
 2020-05-24 01:53:43 -04:00
John Sully
3813d5835e During RDB load we can only handle clients on the main thread as our workers are not yet created. This change also unifies the accept logic across the socket types 
Former-commit-id: 59cda9cfb96eca55c4b445309970bd95277ebc5c
 2020-05-23 16:03:24 -04:00
John Sully
18b8a83ecb During RDB load we can only handle clients on the main thread as our workers are not yet created. This change also unifies the accept logic across the socket types 
Former-commit-id: 59cda9cfb96eca55c4b445309970bd95277ebc5c
 2020-05-23 16:03:24 -04:00
John Sully
3c0e1a1baf Diskless replication handler needs to run on the main thread 
Former-commit-id: 091af6400348b7716f7fe0bc845bf7f16d922815
 2020-05-23 15:15:42 -04:00