Liu Zhen
123d94ffc0
fix clusters mixing accidentally by gossip
...
`clusterStartHandshake` will start hand handshake
and eventually send CLUSTER MEET message, which is strictly prohibited
in the REDIS CLUSTER SPEC.
Only system administrator can initiate CLUSTER MEET message.
Futher, according to the SPEC, rather than IP/PORT pairs, only nodeid
can be trusted.
2020-06-06 11:43:29 +02:00
Liu Zhen
84a7a90586
fix clusters mixing accidentally by gossip
...
`clusterStartHandshake` will start hand handshake
and eventually send CLUSTER MEET message, which is strictly prohibited
in the REDIS CLUSTER SPEC.
Only system administrator can initiate CLUSTER MEET message.
Futher, according to the SPEC, rather than IP/PORT pairs, only nodeid
can be trusted.
2020-06-06 11:43:29 +02:00
antirez
a5f0fa7f7a
Fix handling of special chars in ACL LOAD.
...
Now it is also possible for ACL SETUSER to accept empty strings
as valid operations (doing nothing), so for instance
ACL SETUSER myuser ""
Will have just the effect of creating a user in the default state.
This should fix #7329 .
2020-06-06 11:43:29 +02:00
antirez
cd63359a17
Fix handling of special chars in ACL LOAD.
...
Now it is also possible for ACL SETUSER to accept empty strings
as valid operations (doing nothing), so for instance
ACL SETUSER myuser ""
Will have just the effect of creating a user in the default state.
This should fix #7329 .
2020-06-06 11:43:29 +02:00
antirez
8b15ba933d
Revert "Implements sendfile for redis."
...
This reverts commit 5675053269b0cbc2cf525c99321c96b7c2b39abe.
2020-06-06 11:42:45 +02:00
antirez
61074b43a6
Revert "Implements sendfile for redis."
...
This reverts commit 9cf500a3f67e4e2ce51414c354e3472faf095d5b.
2020-06-06 11:42:45 +02:00
antirez
3b452cac99
Revert "avoid using sendfile if tls-replication is enabled"
...
This reverts commit 13bbd165e87923558952203d310e9ad053d4d7c0.
2020-06-06 11:42:41 +02:00
antirez
d1e23e04aa
Revert "avoid using sendfile if tls-replication is enabled"
...
This reverts commit b9abecfc4c97db01fa6f09180c68a92ea5974ac1.
2020-06-06 11:42:41 +02:00
John Sully
779023beff
Ensure CRON jobs run in a clean environment
...
Former-commit-id: c6dce838b7cc94e115fd73a64dda663f0a2c28c5
2020-06-05 21:35:47 -04:00
John Sully
18f6579ec7
Ensure CRON jobs run in a clean environment
...
Former-commit-id: c6dce838b7cc94e115fd73a64dda663f0a2c28c5
2020-06-05 21:35:47 -04:00
John Sully
848cd33d51
We need to search snapshots before deciding to not save a key
...
Former-commit-id: 357b09c500eecfe61970e121644a7200ac2387b9
2020-06-05 00:39:58 -04:00
John Sully
327f922e04
We need to search snapshots before deciding to not save a key
...
Former-commit-id: 357b09c500eecfe61970e121644a7200ac2387b9
2020-06-05 00:39:58 -04:00
John Sully
a0e502684d
Fix dangling lock
...
Former-commit-id: 212e56984edfa3221c73b1d3c083efcd28f0dd25
2020-06-04 22:59:24 -04:00
John Sully
0606662009
Fix dangling lock
...
Former-commit-id: 212e56984edfa3221c73b1d3c083efcd28f0dd25
2020-06-04 22:59:24 -04:00
John Sully
9204f7b629
Fix race when we free an item before we finish writing to disk making it temporarily unavailable
...
Former-commit-id: 6139cfee295261d0210f2af6217c2a23eeaf52b8
2020-06-04 22:18:03 -04:00
John Sully
d2a29bf343
Fix race when we free an item before we finish writing to disk making it temporarily unavailable
...
Former-commit-id: 6139cfee295261d0210f2af6217c2a23eeaf52b8
2020-06-04 22:18:03 -04:00
John Sully
e522540e2f
Add latency marker for process changes phase for FLASH
...
Former-commit-id: 61e20b025d45b0af8ed60aab96246b30e4d0ed3d
2020-06-04 01:29:17 -04:00
John Sully
9851fde2fa
Add latency marker for process changes phase for FLASH
...
Former-commit-id: 61e20b025d45b0af8ed60aab96246b30e4d0ed3d
2020-06-04 01:29:17 -04:00
John Sully
bec9bb1e0f
Latency doctor updated for KeyDB Pro
...
Former-commit-id: a2690fca4a74e92eb44d5e38f886b08363a6d7b0
2020-06-04 01:28:52 -04:00
John Sully
bc846d047d
Latency doctor updated for KeyDB Pro
...
Former-commit-id: a2690fca4a74e92eb44d5e38f886b08363a6d7b0
2020-06-04 01:28:52 -04:00
John Sully
689c1354be
maxmem samples way too high
...
Former-commit-id: 599cac856d4ec77d59c5f5b4fae5b9f194c202ef
2020-06-04 01:28:34 -04:00
John Sully
8517297100
maxmem samples way too high
...
Former-commit-id: 599cac856d4ec77d59c5f5b4fae5b9f194c202ef
2020-06-04 01:28:34 -04:00
John Sully
8888498bfd
Make snapshot completion faster and add latency monitor
...
Former-commit-id: 8063be6ee70a652c22c3263dccf318366e208891
2020-06-04 01:07:14 -04:00
John Sully
54cc984d86
Make snapshot completion faster and add latency monitor
...
Former-commit-id: 8063be6ee70a652c22c3263dccf318366e208891
2020-06-04 01:07:14 -04:00
John Sully
cb4bb9d7eb
Consolidate snapshots should not consider keys in bulk storage
...
Former-commit-id: e02a8f503d45daf63150c60a8a8c3751b9b8581e
2020-06-04 00:26:51 -04:00
John Sully
f184eb6c3a
Consolidate snapshots should not consider keys in bulk storage
...
Former-commit-id: e02a8f503d45daf63150c60a8a8c3751b9b8581e
2020-06-04 00:26:51 -04:00
John Sully
e7586ddca1
Disambiguate temp rdb files so its less likely two servers with the same working dir will collide
...
Former-commit-id: 8fbc5a63c54589bb42aa1b1b53c56f399211605c
2020-06-04 00:25:37 -04:00
John Sully
959c6b8a19
Disambiguate temp rdb files so its less likely two servers with the same working dir will collide
...
Former-commit-id: 8fbc5a63c54589bb42aa1b1b53c56f399211605c
2020-06-04 00:25:37 -04:00
John Sully
f50ed30ad2
Only set tombstone if there is something to mask
...
Former-commit-id: ea092693f53ff0803c44a851219993a933166cc3
2020-06-04 00:23:37 -04:00
John Sully
d21486d065
Only set tombstone if there is something to mask
...
Former-commit-id: ea092693f53ff0803c44a851219993a933166cc3
2020-06-04 00:23:37 -04:00
John Sully
28397f140a
Extra debug checks in dictmerge
...
Former-commit-id: 839b2a151e6bad67017de87d7a637359f6ae63d1
2020-06-04 00:22:59 -04:00
John Sully
4ddc516382
Extra debug checks in dictmerge
...
Former-commit-id: 839b2a151e6bad67017de87d7a637359f6ae63d1
2020-06-04 00:22:59 -04:00
John Sully
b39f917335
Clear tombstone dict when clearing database we don't need it
...
Former-commit-id: a8e1ef075eacfc0b767302f2514ca6f0342982bc
2020-06-04 00:17:19 -04:00
John Sully
afabc8a87e
Clear tombstone dict when clearing database we don't need it
...
Former-commit-id: a8e1ef075eacfc0b767302f2514ca6f0342982bc
2020-06-04 00:17:19 -04:00
John Sully
4cf14b6e49
Fix crash where tombstone is evicted
...
Former-commit-id: 1f6ff7cc0fc0173610d77a69076eeaf478c3b701
2020-06-03 23:30:35 -04:00
John Sully
a80b8c1b11
Fix crash where tombstone is evicted
...
Former-commit-id: 1f6ff7cc0fc0173610d77a69076eeaf478c3b701
2020-06-03 23:30:35 -04:00
John Sully
6a9b345f56
RocksDB compression is too slow
...
Former-commit-id: 665a8ff0a0a10ffecc36a8410030abd73879944c
2020-06-03 22:21:03 -04:00
John Sully
cebc1b7e48
Add DB commit latency samples
...
Former-commit-id: 557ea8d285045496105e3330f0007e02aa4359d7
2020-06-03 22:06:05 -04:00
John Sully
aebc185824
Add DB commit latency samples
...
Former-commit-id: 557ea8d285045496105e3330f0007e02aa4359d7
2020-06-03 22:06:05 -04:00
zhaozhao.zz
cfc3e6f55d
AOF: append origin SET if no expire option
2020-06-03 17:55:18 +08:00
zhaozhao.zz
5d0774d62f
AOF: append origin SET if no expire option
2020-06-03 17:55:18 +08:00
John Sully
589448bdf0
Fix crash when overwriting key stored in FLASH but not in ram during a BGSAVE while clustering is enabled
...
Former-commit-id: 32967b1d671b151bed976e3d13ce26c7e1496c82
2020-06-02 23:59:24 -04:00
John Sully
65f96b6de3
Fix crash when overwriting key stored in FLASH but not in ram during a BGSAVE while clustering is enabled
...
Former-commit-id: 32967b1d671b151bed976e3d13ce26c7e1496c82
2020-06-02 23:59:24 -04:00
John Sully
ffbd43fbfa
Bump maxmemory samples by a lot
...
Former-commit-id: ae46d64b2e6b16f81df6b4e12ddc9fed63a9785b
2020-06-02 17:22:45 -04:00
John Sully
743074078b
Bump maxmemory samples by a lot
...
Former-commit-id: ae46d64b2e6b16f81df6b4e12ddc9fed63a9785b
2020-06-02 17:22:45 -04:00
John Sully
ad174ab352
Merge error, server always flushes on eviction
...
Former-commit-id: 9b3b0c9a40ab5dcdac9620f0fbad84887cc9c832
2020-06-02 17:21:41 -04:00
John Sully
f98bae1401
Merge error, server always flushes on eviction
...
Former-commit-id: 9b3b0c9a40ab5dcdac9620f0fbad84887cc9c832
2020-06-02 17:21:41 -04:00
zhaozhao.zz
14dc507de2
donot free protected client in freeClientsInAsyncFreeQueue
...
related #7234
2020-06-02 11:48:14 +08:00
zhaozhao.zz
ad6b71352d
donot free protected client in freeClientsInAsyncFreeQueue
...
related #7234
2020-06-02 11:48:14 +08:00
John Sully
64adf015b1
Undecorated new is OK to use
...
Former-commit-id: 5b885bb1649805f6a2edb8d28edd1447bb6c4843
2020-06-01 23:36:01 -04:00