gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
10,376 Commits 1 Branch 0 Tags
Commit Graph

10376 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Oran Agra
1f9520a75d Add handling of short read of module id in rdb 2020-02-12 14:17:40 +01:00
Yossi Gottlieb
e7e595192a TLS: Update documentation. 2020-02-12 14:17:40 +01:00
Oran Agra
ca22e14d8a A few non-data commands that should be allowed while loading or stale 
SELECT, and HELLO are commands that may be executed by the client
as soon as it connects, there's no reason to block them, preventing the
client from doing the rest of his sequence (which might just be INFO or
CONFIG, etc).

MONITOR, DEBUG, SLOWLOG, TIME, LASTSAVE are all non-data accessing
commands, which there's no reason to block.
 2020-02-12 14:17:40 +01:00
Oran Agra
da8ec22fc6 Memory leak when bind config is provided twice 2020-02-12 14:17:40 +01:00
Oran Agra
600d02e1a7 fix maxmemory config warning 
the warning condition was if usage > limit (saying it'll cause eviction
or oom), but in fact the eviction and oom depends on used minus slave
buffers.

other than fixing the condition, i add info about the current usage and
limit, which may be useful when looking at the log.
 2020-02-12 14:17:40 +01:00
Oran Agra
a98e5a1fc3 Fix client flags to be int64 in module.c 
currently there's no bug since the flags these functions handle are
always lower than 32bit, but still better fix the type to prevent future
bugs.
 2020-02-12 14:17:40 +01:00
Oran Agra
e92983ed3f moduleRDBLoadError, add key name, and use panic rather than exit 
using panic rather than exit means you get s stack trace of the code
path that experianced the error, and possibly other info.
 2020-02-12 14:17:40 +01:00
Oran Agra
a8e2bbe8f6 stopAppendOnly resets aof_rewrite_scheduled 
althouh in theory, users can do BGREWRITEAOF even if aof is disabled, i
suppose it is more common that the scheduled flag is set by either
startAppendOnly, of a failed initial AOFRW fork (AOF_WAIT_REWRITE)
 2020-02-12 14:15:56 +01:00
Oran Agra
2af4039b3e reduce repeated calls to use_diskless_load 
this function possibly iterates on the module list
 2020-02-12 14:15:56 +01:00
Oran Agra
23cbfea39b add SAVE subcommand to ACL HELP and top comment 2020-02-12 14:15:56 +01:00
Oran Agra
5e3b4c978b freeClientAsync don't lock mutex if there's just one thread 2020-02-12 14:15:56 +01:00
Oran Agra
3988bfff50 DEBUG HELP - add PROTOCOL 2020-02-12 14:15:56 +01:00
Oran Agra
ad1c21283e move restartAOFAfterSYNC from replicaofCommand to replicationUnsetMaster 
replicationUnsetMaster can be called from other places, not just
replicaofCOmmand, and all of these need to restart AOF
 2020-02-12 14:15:56 +01:00
Guy Benoish
084dc68128 Some refactroing using getClientType instead of CLIENT_SLAVE 2020-02-12 14:15:56 +01:00
Guy Benoish
f4c30fd74b Fix small bugs related to replica and monitor ambiguity 
1. server.repl_no_slaves_since can be set when a MONITOR client disconnects
2. c->repl_ack_time can be set by a newline from a MONITOR client
3. Improved comments
 2020-02-12 14:15:56 +01:00
Yossi Gottlieb
351529cc39 TLS: Some redis.conf clarifications. 2020-02-12 14:15:56 +01:00
Oran Agra
601d423498 config.c verbose error replies for CONFIG SET, like config file parsing 
We noticed that the error replies for the generic mechanism for enums
are very verbose for config file parsing, but not for config set
command.

instead of replicating this code, i did a small refactoring to share
code between CONFIG SET and config file parsing.

and also renamed the enum group functions to be consistent with the
naming of other types.
 2020-02-12 14:15:56 +01:00
Oran Agra
138252dc56 memoryGetKeys helper function so that ACL can limit access to keys for MEMORY command 2020-02-12 14:15:56 +01:00
antirez
491949ee5b ACL LOG: make max log entries configurable. 2020-02-12 14:15:35 +01:00
antirez
c30fe3a93f ACL LOG: test for AUTH reason. 2020-02-12 14:15:35 +01:00
antirez
c0de265bfa ACL LOG: log failed auth attempts. 2020-02-12 14:15:35 +01:00
antirez
c60351e489 ACL LOG: implement a few basic tests. 2020-02-12 14:15:35 +01:00
antirez
74c4d2f158 ACL LOG: also log ACL errors in the scripting/MULTI ctx. 2020-02-12 14:15:35 +01:00
antirez
3853c71288 ACL LOG: implement LOG RESET. 2020-02-12 14:15:35 +01:00
antirez
7b53636462 ACL LOG: group similar entries in a given time delta. 2020-02-12 14:15:35 +01:00
antirez
9f5b64c4a6 ACL LOG: actually emit entries. 2020-02-12 14:15:35 +01:00
antirez
e6eafd3e1f ACL LOG: implement ACL LOG subcommadn skeleton. 2020-02-12 14:15:35 +01:00
antirez
2d06604451 ACL LOG: data structures and initial functions. 2020-02-12 14:15:35 +01:00
John Sully
e216a1f386 Merge branch 'redis_6_merge' into keydbpro 
Former-commit-id: 4bd4159e2d8a7cdd0af9719776dca3e7d161d166
 2020-02-11 03:48:24 -05:00
John Sully
968e668245 Merge branch 'unstable' into redis_6_merge 
Former-commit-id: 329519d4aa230a9f7f2d3b82158f8cafcbbd6952
 2020-02-11 03:48:08 -05:00
John Sully
4748094356 Fix race condition in allocating connections to threads 
Former-commit-id: 52434a583aa7114ff5658226441ab82ed3110a57
 2020-02-11 03:44:28 -05:00
John Sully
23e7de94a8 Merge branch 'redis_6_merge' into keydbpro 
Former-commit-id: 4091800e499cade8bc188c9e6f52f535c500f282
 2020-02-11 02:54:24 -05:00
John Sully
fbaa46505c Merge branch 'unstable' into redis_6_merge 
Former-commit-id: 18a5f46b6138e8a975dda0ed4897d19eed756d24
 2020-02-11 02:39:08 -05:00
John Sully
d4c1e98124 Implement an error handler so bug #125 can't happen 
Former-commit-id: 16a019dba053fd0654116ff98a2ad0b66a9ed4e6
 2020-02-11 01:41:00 -05:00
John Sully
fef9925b7f Fix higher latency at low load by grouping clients to threads. This fixes slow perf in cluster benchmarks mentioned in issue #102 
Former-commit-id: 1a4c3224c9848f02fbdb49674045b593cfc41d31
 2020-02-11 01:00:21 -05:00
John Sully
e4d74b993f Fix cases where duplicate RREPLAY is applied 
Former-commit-id: c3317686f8b8d94a3b2295def899ae30e208f327
 2020-02-11 00:59:07 -05:00
John Sully
30ece138d5 Fix issue #119 
Former-commit-id: 46224721237616c345f6726b721a354d7bda71df
 2020-02-10 19:52:57 -05:00
John Sully
68235881e9 Fix memory leak in cron 
Former-commit-id: f1748f8c7611ad96d7ba4fed66439cd1f043e6f3
 2020-02-10 18:26:04 -05:00
John Sully
d346ad7734 Add missing test file 
Former-commit-id: 0c101dccc825668cb7ff07c23e82db0f5642b786
 2020-02-10 18:15:29 -05:00
John Sully
eac3cffe41 CLANG build fix 
Former-commit-id: dc78bf1ccbd3dfd2de582d2a0d0be3223de3c7c3
 2020-02-10 00:29:26 -05:00
John Sully
25ef65463e Ensure multi-master works for ring topologies 
Former-commit-id: a7cc3aac28ccec4dadb80aa2cc7279c53982bc28
 2020-02-10 00:25:03 -05:00
John Sully
d292477625 Merge branch 'unstable' of https://github.com/JohnSully/KeyDB into unstable 
Former-commit-id: 339631530a5e18af7ad53f1a3df03d24085f9450
 2020-02-09 02:25:20 -05:00
John Sully
6c2cef7687 Addmissing test file 
Former-commit-id: fb2bdf7d05e27b15dcb53b09d6820416a99a3ba7
 2020-02-08 16:49:41 -05:00
John Sully
3aa271fe38 Merge branch 'unstable' into keydbpro 
Former-commit-id: fec8209c1996112976d927d65dbc2b4492131681
 2020-02-07 16:46:13 -05:00
John Sully
bf83742b4f merge 5.0 unstable 
Former-commit-id: c45f1328ac82fa9ebc8731314b40bd059ea45b6f
 2020-02-07 16:45:59 -05:00
John Sully
eabc436814 Fix issue #137 and #132 
Former-commit-id: 050d58007f84e4f71b0ae8b053ae4d6fd5bb4ec7
 2020-02-06 23:31:31 -05:00
John Sully
8800a516d1 Add test to detect issue #137 and #132 
Former-commit-id: 49d86746edef497a568c6f3a64695d420305cca8
 2020-02-06 23:31:12 -05:00
Guy Benoish
2ad427f862 ld2string should fail if string contains \0 in the middle 
This bug affected RM_StringToLongDouble and HINCRBYFLOAT.
I added tests for both cases.

Main changes:
1. Fixed string2ld to fail if string contains \0 in the middle
2. Use string2ld in getLongDoubleFromObject - No point of
   having duplicated code here

The two changes above broke RM_SaveLongDouble/RM_LoadLongDouble
because the long double string was saved with length+1 (An innocent
mistake, but it's actually a bug - The length passed to
RM_SaveLongDouble should not include the last \0).
 2020-02-04 10:23:48 +01:00
Leo Murillo
5b2c6c5efa Set ZSKIPLIST_MAXLEVEL to optimal value given 2^64 elements and p=0.25 2020-02-04 10:23:48 +01:00
antirez
229229eb55 Add more info in the unblockClientFromModule() function. 2020-02-04 10:23:48 +01:00