Guy Benoish
5a6cfbf4ca
Some refactroing using getClientType instead of CLIENT_SLAVE
2020-02-12 14:15:56 +01:00
Guy Benoish
fae306b374
Fix small bugs related to replica and monitor ambiguity
...
1. server.repl_no_slaves_since can be set when a MONITOR client disconnects
2. c->repl_ack_time can be set by a newline from a MONITOR client
3. Improved comments
2020-02-12 14:15:56 +01:00
Oran Agra
488e194787
config.c verbose error replies for CONFIG SET, like config file parsing
...
We noticed that the error replies for the generic mechanism for enums
are very verbose for config file parsing, but not for config set
command.
instead of replicating this code, i did a small refactoring to share
code between CONFIG SET and config file parsing.
and also renamed the enum group functions to be consistent with the
naming of other types.
2020-02-12 14:15:56 +01:00
Oran Agra
c82ccf0670
memoryGetKeys helper function so that ACL can limit access to keys for MEMORY command
2020-02-12 14:15:56 +01:00
antirez
51c1a9f8fb
ACL LOG: make max log entries configurable.
2020-02-12 14:15:35 +01:00
antirez
7379c78a9b
ACL LOG: log failed auth attempts.
2020-02-12 14:15:35 +01:00
antirez
82790e510f
ACL LOG: also log ACL errors in the scripting/MULTI ctx.
2020-02-12 14:15:35 +01:00
antirez
943008ebac
ACL LOG: implement LOG RESET.
2020-02-12 14:15:35 +01:00
antirez
e271a61103
ACL LOG: group similar entries in a given time delta.
2020-02-12 14:15:35 +01:00
antirez
f1974d5d67
ACL LOG: actually emit entries.
2020-02-12 14:15:35 +01:00
antirez
d9b153c9f6
ACL LOG: implement ACL LOG subcommadn skeleton.
2020-02-12 14:15:35 +01:00
antirez
577fc4388b
ACL LOG: data structures and initial functions.
2020-02-12 14:15:35 +01:00
Salvatore Sanfilippo
8aa0b19d83
Merge pull request #6691 from kraj/fno-common
...
Mark extern definition of SDS_NOINIT in sds.h
2020-02-12 14:04:53 +01:00
lifubang
dc8f947d7c
correct help info for --user and --pass
...
Signed-off-by: lifubang <lifubang@acmcoder.com>
2020-02-12 16:34:22 +08:00
antirez
71f3f3f1af
Tracking: BCAST: broadcasting of keys in prefixes implemented.
2020-02-11 18:11:59 +01:00
antirez
3f7ba86255
Tracking: BCAST: registration in the prefix table.
2020-02-11 17:26:29 +01:00
John Sully
d1885547f2
Merge branch 'unstable' into redis_6_merge
...
Former-commit-id: 329519d4aa230a9f7f2d3b82158f8cafcbbd6952
2020-02-11 03:48:08 -05:00
John Sully
da293758fc
Fix race condition in allocating connections to threads
...
Former-commit-id: 52434a583aa7114ff5658226441ab82ed3110a57
2020-02-11 03:44:28 -05:00
John Sully
ee99605def
Merge branch 'unstable' into redis_6_merge
...
Former-commit-id: 18a5f46b6138e8a975dda0ed4897d19eed756d24
2020-02-11 02:39:08 -05:00
John Sully
e30630d53b
Implement an error handler so bug #125 can't happen
...
Former-commit-id: 16a019dba053fd0654116ff98a2ad0b66a9ed4e6
2020-02-11 01:41:00 -05:00
John Sully
3282d4114f
Fix higher latency at low load by grouping clients to threads. This fixes slow perf in cluster benchmarks mentioned in issue #102
...
Former-commit-id: 1a4c3224c9848f02fbdb49674045b593cfc41d31
2020-02-11 01:00:21 -05:00
John Sully
47acc74247
Fix cases where duplicate RREPLAY is applied
...
Former-commit-id: c3317686f8b8d94a3b2295def899ae30e208f327
2020-02-11 00:59:07 -05:00
John Sully
3f62860342
Fix issue #119
...
Former-commit-id: 46224721237616c345f6726b721a354d7bda71df
2020-02-10 19:52:57 -05:00
John Sully
5a71721610
Fix memory leak in cron
...
Former-commit-id: f1748f8c7611ad96d7ba4fed66439cd1f043e6f3
2020-02-10 18:26:04 -05:00
antirez
dfe126f3e9
Tracking: BCAST: parsing of the options + skeleton.
2020-02-10 17:18:11 +01:00
antirez
f53cc00c09
Tracking: always reply with an array of keys.
2020-02-10 13:42:18 +01:00
meir@redislabs.com
67dbc5f365
Changed log level for module fork api from 'notice' to 'verbos'.
2020-02-10 12:10:32 +02:00
John Sully
66925e9a54
CLANG build fix
...
Former-commit-id: dc78bf1ccbd3dfd2de582d2a0d0be3223de3c7c3
2020-02-10 00:29:26 -05:00
John Sully
9cd3b8253d
Ensure multi-master works for ring topologies
...
Former-commit-id: a7cc3aac28ccec4dadb80aa2cc7279c53982bc28
2020-02-10 00:25:03 -05:00
John Sully
70cb1df72a
merge 5.0 unstable
...
Former-commit-id: c45f1328ac82fa9ebc8731314b40bd059ea45b6f
2020-02-07 16:45:59 -05:00
antirez
85e4777d5c
Tracking: minor change of names and new INFO field.
2020-02-07 18:12:45 +01:00
antirez
1ea6672430
Rax.c: populate data field after random walk.
2020-02-07 18:12:10 +01:00
antirez
d933d6f2a4
Tracking: rename INFO field with total items.
2020-02-07 17:19:17 +01:00
antirez
92357b2d61
Tracking: first conversion from hashing to key names.
2020-02-07 14:03:43 +01:00
John Sully
a5a736be73
Fix issue #137 and #132
...
Former-commit-id: 050d58007f84e4f71b0ae8b053ae4d6fd5bb4ec7
2020-02-06 23:31:31 -05:00
John Sully
a21c81c30e
Add test to detect issue #137 and #132
...
Former-commit-id: 49d86746edef497a568c6f3a64695d420305cca8
2020-02-06 23:31:12 -05:00
Oran Agra
46216b0e83
add no-slowlog option to RM_CreateCommand
2020-02-06 15:06:33 +02:00
Oran Agra
c8c3281f06
add no_auth to COMMAND INFO
2020-02-06 14:53:54 +02:00
Salvatore Sanfilippo
9c00bdd86e
Merge pull request #6822 from guybe7/diskless_load_module_hook_fix
...
Diskless-load emptyDb-related fixes
2020-02-06 13:10:00 +01:00
Guy Benoish
92dc5e1fa4
Diskless-load emptyDb-related fixes
...
1. Call emptyDb even in case of diskless-load: We want modules
to get the same FLUSHDB event as disk-based replication.
2. Do not fire any module events when flushing the backups array.
3. Delete redundant call to signalFlushedDb (Called from emptyDb).
2020-02-06 16:48:02 +05:30
antirez
50d4326e3b
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2020-02-06 11:24:22 +01:00
antirez
d5c6a833c8
Merge branch 'acl-log' into unstable
2020-02-06 11:24:16 +01:00
Salvatore Sanfilippo
1012514e0f
Merge pull request #6826 from lifubang/opensslcli
...
fix ssl args check for redis-cli
2020-02-06 11:22:20 +01:00
Oran Agra
28ef18a894
RM_Scan disable dict rehashing
...
The callback approach we took is very efficient, the module can do any
filtering of keys without building any list and cloning strings, it can
also read data from the key's value. but if the user tries to re-open
the key, or any other key, this can cause dict re-hashing (dictFind does
that), and that's very bad to do from inside dictScan.
this commit protects the dict from doing any rehashing during scan, but
also warns the user not to attempt any writes or command calls from
within the callback, for fear of unexpected side effects and crashes.
2020-02-06 11:48:12 +02:00
Salvatore Sanfilippo
5bfba06a3b
Merge pull request #6821 from guybe7/key_miss_notify
...
Exclude "keymiss" notification from NOTIFY_ALL
2020-02-06 10:43:05 +01:00
Salvatore Sanfilippo
2e1dd00c80
Merge pull request #6837 from oranagra/signal_modified_key_doc
...
update RM_SignalModifiedKey doc comment
2020-02-06 10:38:36 +01:00
Salvatore Sanfilippo
730cacf672
Merge pull request #6840 from oranagra/short_read_moduleid
...
Add handling of short read of module id in rdb
2020-02-06 10:35:42 +01:00
Salvatore Sanfilippo
33f613bf87
Merge pull request #6843 from oranagra/command_flags
...
A few non-data commands that should be allowed while loading or stale
2020-02-06 10:34:26 +01:00
Salvatore Sanfilippo
4aafdb185a
Merge pull request #6844 from oranagra/bind_config_leak
...
Memory leak when bind config is provided twice
2020-02-06 10:33:40 +01:00
Salvatore Sanfilippo
be520829b8
Merge pull request #6845 from oranagra/maxmemory_warning
...
fix maxmemory config warning
2020-02-06 10:33:15 +01:00