antirez
ee273aa92c
This fixes issue #327 , is a very complex fix (unfortunately), details:
...
1) sendReplyToClient() now no longer stops transferring data to a single
client in the case we are out of memory (maxmemory-wise).
2) in processCommand() the idea of we being out of memory is no longer
the naive zmalloc_used_memory() > server.maxmemory. To say if we can
accept or not write queries is up to the return value of
freeMemoryIfNeeded(), that has full control about that.
3) freeMemoryIfNeeded() now does its math without considering output
buffers size. But at the same time it can't let the output buffers to
put us too much outside the max memory limit, so at the same time it
makes sure there is enough effort into delivering the output buffers to
the slaves, calling the write handler directly.
This three changes are the result of many tests, I found (partially
empirically) that is the best way to address the problem, but maybe
we'll find better solutions in the future.
2012-02-04 14:05:54 +01:00
antirez
ea71e06988
Use less memory when emitting the protocol, by using more shared objects for commonly emitted parts of the protocol.
2012-02-04 08:58:37 +01:00
antirez
67c4a45d53
Now Lua scripts dispatch Redis commands properly calling the call() function. In order to make this possible call() was improved with a new flags argument that controls how the Redis command is executed.
2012-02-02 16:30:52 +01:00
antirez
90754849a9
Set a 3.5 GB maxmemory limit with noeviction policy if a 32 bit instance without user-provided memory limits is detected.
2012-02-02 10:26:20 +01:00
antirez
0671914638
Added a server.arch_bits field instead of computing it at runtime for INFO.
2012-02-02 10:23:31 +01:00
antirez
c814e1baca
Only incremnet stats for key miss/hit when the key is semantically accessed in read-only.
2012-02-01 21:51:20 +01:00
antirez
d26bae3ce9
Make SORT BY <constant> STORE ... to always produce the same output by force sorting, so that we have deterministic replication of this command.
2012-02-01 17:05:45 +01:00
antirez
4a6e6ac8e6
SORT is now more deterministic: does not accept to compare by score items that have scores not representing a valid double. Also items with the same score are compared lexycographically. At the same time the scripting side introduced the ability to sort the output of SORT when sort uses the BY <constant> optimization, resulting in no specific ordering. Since in this case the user may use GET, and the result of GET can be null, converted into false as Lua data type, this commit also introduces the ability to sort Lua tables containining false, only if the first (faster) attempt at using just table.sort with a single argument fails.
2012-02-01 15:22:28 +01:00
antirez
1a786437db
Order output of commands returning random arrays using table.sort when called from Lua, partially fixing issue #165 . The issue is yet not completely fixed since we can't add the REDIS_CMD_SORT_FOR_SCRIPT flag in SORT currently, both because it may contain NULLs and because it is not cool to re-sort everything at every call when instead this should be sorted only if BY <constant> is used.
2012-01-31 16:09:21 +01:00
antirez
62072a2780
Fixed redis-benchmark --help output typo
2012-01-31 11:43:32 +01:00
antirez
884c2f0e68
64 bit instances are no longer limited to have at max 2^32-1 elements in lists.
2012-01-31 10:35:52 +01:00
antirez
35de9ef7f4
Merge remote-tracking branch 'origin/unstable' into unstable
2012-01-30 10:40:28 +01:00
Salvatore Sanfilippo
91323b63fe
Merge pull request #319 from fawek/lua-error-location
...
Lua reports line numbers off by one in error messages
2012-01-30 01:40:17 -08:00
antirez
e6369ae06e
setKey(): call the higher level wrapper setModifiedKey() instead of touchWatchedKey() even if currently they are exactly the same.
2012-01-30 10:27:50 +01:00
Michal Kwiatkowski
03bbd4468a
SORT with STORE removes key if result is empty. This fixes issue #227 .
2012-01-30 07:36:49 +01:00
Jakub Wieczorek
d64463bd05
Lua reports line numbers off by one in error messages
2012-01-29 14:53:49 +01:00
Pieter Noordhuis
a40390001d
Test that zipmap from RDB is correctly converted
2012-01-25 13:28:11 -08:00
antirez
f70afca5e5
Fixed typo in getClientLimitClassByName()
2012-01-25 18:07:56 +01:00
antirez
39ef0b8808
Fixed another possible bug in cluster.c found by clang --analyze.
2012-01-25 16:59:36 +01:00
antirez
c1450c6701
Merge branch 'unstable' into limits
2012-01-25 16:46:53 +01:00
antirez
9ba7d2974b
Fixed a non critical bug signaled by clang static analyzer thanks to Mukund Sivaraman for reporting it: there was a not initialized field populating the cluster message header, but it is always fixed at later time before sending the packet.
2012-01-25 16:46:35 +01:00
antirez
86408b3b8b
Merge branch 'unstable' into limits
2012-01-25 10:41:25 +01:00
antirez
e75a50b867
aeCreateEventLoop() cleanup on error unified in a single block (original
...
patch by Mukund Sivaraman, modified by me to make it simpler and to use
my coding style).
2012-01-25 10:37:32 +01:00
Mukund Sivaraman
32fb1d767e
If aeApiCreate() fails, there's probably not much one can do, but in the name of consistency...
2012-01-25 10:27:37 +01:00
antirez
dd46b715a9
lenght -> length
2012-01-24 15:33:15 +01:00
antirez
069139ce75
after all closing a client for output buffer limit overcoming is a WARNING level message.
2012-01-24 12:03:48 +01:00
antirez
1b76d045bb
client-output-buffer-limit documented in redis.conf
2012-01-24 11:23:23 +01:00
antirez
9844d172b9
Client output buffer limits: configuration of parameters for the different classes of clients implemented.
2012-01-24 10:43:30 +01:00
antirez
65654feac2
asyncCloseClientOnOutputBufferLimitReached() now ignores clients with REDIS_CLOSE_ASAP flag already set. Return value of the function changed from int to void since it is not used. Fixed logging of the client scheduled to be closed.
2012-01-24 09:32:39 +01:00
antirez
ddec8a8903
client buffer handling refactoring and optimization
2012-01-23 17:15:49 +01:00
antirez
b5b777fd54
actually call the function to async free clients in serverCron().
2012-01-23 16:17:22 +01:00
antirez
1caa425a7c
Implementation of the internals that make possible to terminate clients overcoming configured output buffer (soft and hard) limits.
2012-01-23 16:12:37 +01:00
antirez
aa567615f5
Merge branch 'unstable' into limits
2012-01-23 10:36:07 +01:00
antirez
36d5d67ed7
fixed typo in hahs function seed default value. It is no longer used but fixed to retain the old constant as default anyway.
2012-01-22 01:40:23 +01:00
antirez
58b6383898
typo in comment fixed
2012-01-21 23:34:06 +01:00
antirez
fff238e507
Fix for hash table collision attack. We simply randomize hash table initialization value at startup time.
2012-01-21 23:30:13 +01:00
antirez
95e3043515
Better looking registers/stack dump
2012-01-20 16:40:43 +01:00
antirez
ddf4019e3b
added support to dump registers on crash on Linux x32
2012-01-20 14:37:50 +01:00
antirez
113adf562c
added support to dump registers on crash on Linux x64
2012-01-20 12:54:15 +01:00
antirez
df25feb732
all the stack trace related functions are now in debug.c. Now Redis dumps registers and stack content on crash. Currently osx supported, adding Linux right now.
2012-01-20 12:20:45 +01:00
antirez
edfaedafb0
Introduced three client limit classes: normal, slave, pubsub
2012-01-17 12:43:01 +01:00
antirez
b7a33b7322
Track the length of the client pending output buffers (still to transfer) in a new field in the client structure.
2012-01-17 12:23:25 +01:00
antirez
52594e0fd8
It is now posible to flush all the previous saving points in redis.conf by using a save directive with a single empty string argument, like it happens for CONFIG SET save.
2012-01-16 16:50:24 +01:00
antirez
379502c014
Don't change the replication state if SLAVE OF is called with arguments specifying the same master we are already connected with. This fixes issues #290 .
2012-01-16 11:29:47 +01:00
antirez
80f84859da
Obsolete SDS_ABORT_ON_OOM removed from sds.c
2012-01-16 10:08:33 +01:00
antirez
7dbf620812
sds.c no longe pre-allocate more than 1MB of free space ahead. This fixes issue #252 .
2012-01-16 10:03:38 +01:00
antirez
90905c6b20
added a comment on top of the zslRandomLevel() function
2012-01-16 09:39:04 +01:00
antirez
a9ea3f0700
On crash print information about the current client (if any), command vector, and object associated to first argument assuming it is a key.
2012-01-12 16:02:57 +01:00
antirez
bb241b1996
error in comment fixed
2012-01-11 20:25:51 +01:00
antirez
d035bf1630
show GCC version in INFO output.
2012-01-10 18:37:16 +01:00
