gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
13,980 Commits 1 Branch 0 Tags
Commit Graph

13980 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
antirez
f15042dbf0 Explain why we allow transactions in -BUSY state. 
Related to #7022.
 2020-03-25 12:46:59 +01:00
Salvatore Sanfilippo
643bc48a00
Merge pull request #7022 from oranagra/multi-busy-script 
MULTI/EXEC during LUA script timeout are messed up
 2020-03-25 12:44:26 +01:00
John Sully
7b2b437539 Fix failure to load subkey expires 
Former-commit-id: 528a43bd6c80f073d928dd18c4f67f37cfd0977a
 2020-03-25 01:38:58 -04:00
John Sully
70faf2f375 Expire entry needs to be resorted after a subkey expires 
Former-commit-id: b357803362728c26a1169e3cec279c693b86205b
 2020-03-25 01:06:40 -04:00
Oran Agra
ec007559ff MULTI/EXEC during LUA script timeout are messed up 
Redis refusing to run MULTI or EXEC during script timeout may cause partial
transactions to run.

1) if the client sends MULTI+commands+EXEC in pipeline without waiting for
response, but these arrive to the shards partially while there's a busy script,
and partially after it eventually finishes: we'll end up running only part of
the transaction (since multi was ignored, and exec would fail).

2) similar to the above if EXEC arrives during busy script, it'll be ignored and
the client state remains in a transaction.

the 3rd test which i added for a case where MULTI and EXEC are ok, and
only the body arrives during busy script was already handled correctly
since processCommand calls flagTransaction
 2020-03-23 20:45:32 +02:00
antirez
c80d81c80a Improve comments of replicationCacheMasterUsingMyself(). 2020-03-23 16:17:35 +01:00
antirez
61de1c1146 Fix BITFIELD_RO test. 2020-03-23 12:02:12 +01:00
antirez
918086e253 Abort transactions after -READONLY error. Fix #7014. 2020-03-23 11:47:49 +01:00
antirez
38514e3c8d Minor changes to BITFIELD_RO PR #6951. 2020-03-23 11:28:09 +01:00
Salvatore Sanfilippo
493a7f9823
Merge pull request #6951 from yangbodong22011/feature-bitfield-ro 
Added BITFIELD_RO variants for read-only operations.
 2020-03-23 11:23:21 +01:00
antirez
19f5be231d Modules: updated function doc after #7003. 2020-03-23 11:17:50 +01:00
Salvatore Sanfilippo
7c5dc07016
Merge pull request #7003 from guybe7/rm_context_flags_handle_null 
Allow RM_GetContextFlags to work with ctx==NULL
 2020-03-23 11:15:42 +01:00
Salvatore Sanfilippo
b9e5be5f56
Merge pull request #7005 from hwware/memoryleakfix-redis-cli 
fix potential memory leak in redis-cli lua debug mode
 2020-03-23 11:14:46 +01:00
Salvatore Sanfilippo
89f46f0fa1
Merge pull request #7018 from yossigo/fix-accept-issues 
Fix issues with failed/rejected accepts.
 2020-03-23 11:10:59 +01:00
Salvatore Sanfilippo
d1788a5ddb
Merge pull request #7019 from hwware/cscfix 
Fix Bug for Client Side Caching: Unexpected Behaviour when Switching between OPTIN/OPTOUT Mode
 2020-03-23 11:09:55 +01:00
hwware
34d5982bd5 remove redundant Semicolon 2020-03-23 01:07:46 -04:00
hwware
a2732291cd clean CLIENT_TRACKING_CACHING flag when disabled caching 2020-03-23 01:04:49 -04:00
Yossi Gottlieb
2dab5015b7 Fix crashes related to failed/rejected accepts. 2020-03-22 14:47:44 +02:00
Yossi Gottlieb
4c08ae3ff6 Cluster: fix misleading accept errors. 2020-03-22 14:46:16 +02:00
Yossi Gottlieb
fa9aa90813 Conns: Fix connClose() / connAccept() behavior. 
We assume accept handlers may choose to reject a connection and close
it, but connAccept() callers can't distinguish between this state and
other error states requiring connClose().

This makes it safe (and mandatory!) to always call connClose() if
connAccept() fails, and safe for accept handlers to close connections
(which will defer).
 2020-03-22 14:42:03 +02:00
Salvatore Sanfilippo
5634ee973c
Merge pull request #7013 from hwware/clusterhelpfix 
add missing commands description in cluster help
 2020-03-20 16:33:10 +01:00
hwware
93bb42a0b5 add missing commands in cluster help 2020-03-20 09:01:12 -04:00
antirez
1e16b9384d Merge branch 'unstable' of github.com:/antirez/redis into unstable 2020-03-20 13:21:28 +01:00
antirez
5497a44037 Regression test for #7011. 2020-03-20 12:52:06 +01:00
antirez
f9c56dbb09 ACL: default user off should not allow automatic authentication. 
This fixes issue #7011.
 2020-03-20 12:45:48 +01:00
John Sully
b057a9cd7a Unstable branch should always be version 0.0.0 
Former-commit-id: 448808529ab9e9e4705c2e7cbda5b3e6523b7c6f
 2020-03-19 15:52:24 -04:00
John Sully
dada212214 Merge branch 'RELEASE_5' into unstable 
Former-commit-id: a0bc2084128f991697d3e1b7473d14c55afdd785
 2020-03-19 15:38:16 -04:00
John Sully
69806aaa7b Print stack traces of other threads in the deadlock detector 
Former-commit-id: 6b0172b9bf124372f4c8688c91c380c6c1b607c7
 2020-03-19 15:37:49 -04:00
John Sully
1bdccb3c42 Log which thread a message came from 
Former-commit-id: bc1eccb66d3302d6c99588fb4a5a879e1ef243b1
 2020-03-19 15:37:24 -04:00
John Sully
4d5d7ed59f Fix lock inversion in processEventsWhileBlocked 
Former-commit-id: a9249d4a82a0f0355ac8ffa40b34b9c14cabf66b
 2020-03-19 15:28:39 -04:00
John Sully
87626299a6 Prevent dangling lock when we can't free the client 
Former-commit-id: 3c373494d63b21744b264f0a47e6999bcdda6b2b
 2020-03-19 14:34:23 -04:00
hwware
262262fbb2 fix spelling in cluster.c 2020-03-18 09:48:03 -04:00
hwware
86691ccff5 fix potentical memory leak in redis-cli 2020-03-18 09:33:52 -04:00
Guy Benoish
f16eaadd4f Allow RM_GetContextFlags to work with ctx==NULL 2020-03-18 18:34:27 +05:30
Salvatore Sanfilippo
c1295bb9f1
Merge pull request #6996 from artix75/redis_cli_proxy_info 
Support Redis Cluster Proxy PROXY INFO command
 2020-03-18 11:06:49 +01:00
Salvatore Sanfilippo
c52415b219
Merge pull request #7000 from ppillip/patch-1 
Update redis.conf
 2020-03-18 11:06:22 +01:00
Salvatore Sanfilippo
82e1807769
Merge pull request #7001 from trevor211/fixDataInconsistency 
Fix data inconsistency
 2020-03-18 11:04:08 +01:00
WuYunlong
f6029fb925 Fix master replica inconsistency for upgrading scenario. 
Before this commit, when upgrading a replica, expired keys will not
be loaded, thus causing replica having less keys in db. To this point,
master and replica's keys is logically consistent. However, before
the keys in master and replica are physically consistent, that is,
they have the same dbsize, if master got a problem and the replica
got promoted and becomes new master of that partition, and master
updates a key which does not exist on master, but physically exists
on the old master(new replica), the old master would refuse to update
the key, thus causing master and replica data inconsistent.

How could this happen?
That's all because of the wrong judgement of roles while starting up
the server. We can not use server.masterhost to judge if the server
is master or replica, since it fails in cluster mode.

When we start the server, we load rdb and do want to load expired keys,
and do not want to have the ability to active expire keys, if it is
a replica.
 2020-03-18 16:22:07 +08:00
WuYunlong
af5167b7f3 Add 14-consistency-check.tcl to prove there is a data consistency issue. 2020-03-18 16:17:46 +08:00
박승현
d9de9d5478
Update redis.conf 2020-03-18 14:40:50 +09:00
John Sully
3df47fa3ab Merge branch 'unstable' into redis_6_merge 
Former-commit-id: 40761e403166bf3342fe388ab742498f99245b1a
 2020-03-17 00:09:48 -04:00
John Sully
42027c533a Fix issue #153: Config get replicaof returns a corrupt response 
Former-commit-id: 5aef606d3bc1d748ca8d2df1d36feccaa2e583c0
 2020-03-16 20:43:46 -04:00
antirez
b3a97004f4 Sentinel: document auth-user directive. 2020-03-16 17:11:43 +01:00
antirez
29b9d0a245 ACL: Make Redis 6 more backward compatible with requirepass. 
Note that this as a side effect fixes Sentinel "requirepass" mode.
 2020-03-16 16:57:12 +01:00
artix
771df8a436 Support Redis Cluster Proxy PROXY INFO command 2020-03-16 16:15:02 +01:00
antirez
9321c7871f Sentinel: implement auth-user directive for ACLs. 2020-03-16 15:59:34 +01:00
antirez
bce9a68b39 Merge branch 'unstable' of github.com:/antirez/redis into unstable 2020-03-16 13:48:35 +01:00
antirez
8609e68161 Example sentinel conf: document requirepass. 2020-03-16 13:48:29 +01:00
Salvatore Sanfilippo
15338ab694
Merge pull request #6991 from soloestoy/io-threads-bugfix 
Threaded IO: bugfix client kill may crash redis
 2020-03-16 10:53:54 +01:00
Salvatore Sanfilippo
f1e4af2c29
Merge pull request #6993 from soloestoy/optimize-threaded-io 
Threaded IO: handle pending reads clients ASAP after event loop
 2020-03-16 10:48:23 +01:00