gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
11,258 Commits 1 Branch 0 Tags
Commit Graph

11258 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
antirez
677e9dd036 Fix getKeysUsingCommandTable() in the case of nagative arity. 
This fixes a crash with Redis Cluster when OBJECT is mis-used, because
getKeysUsingCommandTable() will call serverPanic() detecting we are
accessing an invalid argument in the case "OBJECT foo" is called.

This bug was introduced when OBJECT HELP was introduced, because the key
argument is set fixed at index 2 in the command table, however now
OBJECT may be called with an insufficient number of arguments to extract
the key.

The "Right Thing" would be to have a specific function to extract keys
from the OBJECT command, however this is kinda of an overkill, so I
preferred to make getKeysUsingCommandTable() more robust and just return
no keys when it's not possible to honor the command table, because new
commands are often added and also there are a number with an HELP
subcommand violating the normal form, and crashing for this trivial
reason or having many command-specific key extraction functions is not
great.
 2018-01-12 11:26:29 +01:00
antirez
db7bd6fda9 Document new protocol options in #4568 into redis.conf. 2018-01-11 11:40:57 +01:00
antirez
6c2197080c Document new protocol options in #4568 into redis.conf. 2018-01-11 11:40:57 +01:00
antirez
13650446ac proto-max-querybuf-len -> client-query-buffer-limit. 
We already had client buffer limits exported as configuration options.
Stick with the naming scheme already used.

See #4568.
 2018-01-11 11:36:26 +01:00
antirez
9fc237736e proto-max-querybuf-len -> client-query-buffer-limit. 
We already had client buffer limits exported as configuration options.
Stick with the naming scheme already used.

See #4568.
 2018-01-11 11:36:26 +01:00
antirez
8075572207 New config options about protocol prefixed with "proto". 
Related to #4568.
 2018-01-11 11:27:41 +01:00
antirez
a3843bfe99 New config options about protocol prefixed with "proto". 
Related to #4568.
 2018-01-11 11:27:41 +01:00
Salvatore Sanfilippo
c2fa4b8a60
Merge pull request #4568 from oranagra/restore_size_limit 
fix RESTORE command size limits
 2018-01-11 11:20:02 +01:00
Salvatore Sanfilippo
a719121aa1 Merge pull request #4568 from oranagra/restore_size_limit 
fix RESTORE command size limits
 2018-01-11 11:20:02 +01:00
huijing.whj
f0e09bf803 fix int overflow problem in freeMemoryIfNeeded 2018-01-10 23:47:02 +08:00
huijing.whj
3b332f4c57 fix int overflow problem in freeMemoryIfNeeded 2018-01-10 23:47:02 +08:00
Salvatore Sanfilippo
e954742fbd
Merge pull request #3356 from yusaku/fix-module-firstkey 
Fix the firstkey, lastkey, and keystep of moduleCommand
 2018-01-09 18:58:31 +01:00
Salvatore Sanfilippo
e8dfc3f138 Merge pull request #3356 from yusaku/fix-module-firstkey 
Fix the firstkey, lastkey, and keystep of moduleCommand
 2018-01-09 18:58:31 +01:00
antirez
c17a0e134f Test: MIGRATE AUTH test added. 
Related to #2507.
 2018-01-09 18:49:19 +01:00
antirez
7eb5bdadcd Test: MIGRATE AUTH test added. 
Related to #2507.
 2018-01-09 18:49:19 +01:00
antirez
3ce1c28d47 Rewrite MIGRATE AUTH option. 
See PR #2507. This is a reimplementation of the fix that contained
different problems.
 2018-01-09 18:48:26 +01:00
antirez
0c65678e6c Rewrite MIGRATE AUTH option. 
See PR #2507. This is a reimplementation of the fix that contained
different problems.
 2018-01-09 18:48:26 +01:00
gnuhpc
36e71b88b5 Fix a typo(maybe instruction?) in crash log 2018-01-09 16:13:02 +08:00
gnuhpc
fc7fd14395 Fix a typo(maybe instruction?) in crash log 2018-01-09 16:13:02 +08:00
Dvir Volk
e76dfc90a7 Added RM_UnlinkKey - a low level analog to UNLINK command 2018-01-07 16:41:43 +02:00
Dvir Volk
f47914ea05 Added RM_UnlinkKey - a low level analog to UNLINK command 2018-01-07 16:41:43 +02:00
Salvatore Sanfilippo
e509fbb8d9
Merge pull request #4579 from gnuhpc/fix-memoryusage-list 
Fix memory usage list bug
 2018-01-05 11:53:11 +01:00
Salvatore Sanfilippo
475054f8bd Merge pull request #4579 from gnuhpc/fix-memoryusage-list 
Fix memory usage list bug
 2018-01-05 11:53:11 +01:00
gnuhpc
5113a53df6 Fix memory usage list bug 2018-01-05 12:16:24 +08:00
gnuhpc
ec24b8bc6e Fix memory usage list bug 2018-01-05 12:16:24 +08:00
zhaozhao.zz
c0f611f12a redis-benchmark: bugfix - handle zero liveclients in right way 2018-01-03 12:47:25 +08:00
zhaozhao.zz
84af8a13bb redis-benchmark: bugfix - handle zero liveclients in right way 2018-01-03 12:47:25 +08:00
Oran Agra
b509a14c3e Add config options for max-bulk-len and max-querybuf-len mainly to support RESTORE of large keys 2017-12-29 12:43:48 +02:00
Oran Agra
f15d20d9c7 Add config options for max-bulk-len and max-querybuf-len mainly to support RESTORE of large keys 2017-12-29 12:43:48 +02:00
Oran Agra
60a4f12f8b fix processing of large bulks (above 2GB) 
- protocol parsing (processMultibulkBuffer) was limitted to 32big positions in the buffer
  readQueryFromClient potential overflow
- rioWriteBulkCount used int, although rioWriteBulkString gave it size_t
- several places in sds.c that used int for string length or index.
- bugfix in RM_SaveAuxField (return was 1 or -1 and not length)
- RM_SaveStringBuffer was limitted to 32bit length
 2017-12-29 12:24:19 +02:00
Oran Agra
7fbdeedd6a fix processing of large bulks (above 2GB) 
- protocol parsing (processMultibulkBuffer) was limitted to 32big positions in the buffer
  readQueryFromClient potential overflow
- rioWriteBulkCount used int, although rioWriteBulkString gave it size_t
- several places in sds.c that used int for string length or index.
- bugfix in RM_SaveAuxField (return was 1 or -1 and not length)
- RM_SaveStringBuffer was limitted to 32bit length
 2017-12-29 12:24:19 +02:00
antirez
0b561883b4 Hyperloglog: refresh hdr variable correctly. 
This is a fix for the #3819 improvements. The o->ptr may change because
of hllSparseSet() calls, so 'hdr' must be correctly re-fetched.
 2017-12-22 11:26:31 +01:00
antirez
3e4795c48b Hyperloglog: refresh hdr variable correctly. 
This is a fix for the #3819 improvements. The o->ptr may change because
of hllSparseSet() calls, so 'hdr' must be correctly re-fetched.
 2017-12-22 11:26:31 +01:00
antirez
27b81f3fbc Hyperloglog: Support for PFMERGE sparse encoding as target. 
This is a fix for #3819.
 2017-12-22 11:01:27 +01:00
antirez
9da6cc96ed Hyperloglog: Support for PFMERGE sparse encoding as target. 
This is a fix for #3819.
 2017-12-22 11:01:27 +01:00
antirez
cbe9d725a7 Hyperloglog: refactoring of sparse/dense add function. 
The commit splits the add functions into a set() and add() set of
functions, so that it's possible to set registers in an independent way
just having the index and count.

Related to #3819, otherwise a fix is not possible.
 2017-12-22 11:00:22 +01:00
antirez
ec89f279f8 Hyperloglog: refactoring of sparse/dense add function. 
The commit splits the add functions into a set() and add() set of
functions, so that it's possible to set registers in an independent way
just having the index and count.

Related to #3819, otherwise a fix is not possible.
 2017-12-22 11:00:22 +01:00
heqin
365e6c45ea fixbug for #4545 dead loop aof rewrite 2017-12-18 17:59:03 +08:00
heqin
fda7b81f8d fixbug for #4545 dead loop aof rewrite 2017-12-18 17:59:03 +08:00
Itamar Haber
d49bfc4080 Uppercases subcommands in OBJECT HELP 2017-12-15 21:21:12 +02:00
Itamar Haber
43bf55b363 Uppercases subcommands in OBJECT HELP 2017-12-15 21:21:12 +02:00
Itamar Haber
7820377d00 Uppercases subcommands in MEMORY HELP 2017-12-15 21:19:41 +02:00
Itamar Haber
847313fa93 Uppercases subcommands in MEMORY HELP 2017-12-15 21:19:41 +02:00
Salvatore Sanfilippo
238c9bd086
Merge pull request #4540 from hqin6/unstable 
fixbug for #4538 Error opening /setting AOF rewrite IPC pipes: No suc…
 2017-12-15 12:41:02 +01:00
Salvatore Sanfilippo
026ced56b9 Merge pull request #4540 from hqin6/unstable 
fixbug for #4538 Error opening /setting AOF rewrite IPC pipes: No suc…
 2017-12-15 12:41:02 +01:00
heqin
ee724cac49 fixbug for #4538 Error opening /setting AOF rewrite IPC pipes: No such file or directory 2017-12-15 11:06:58 +08:00
heqin
0d47a71887 fixbug for #4538 Error opening /setting AOF rewrite IPC pipes: No such file or directory 2017-12-15 11:06:58 +08:00
Salvatore Sanfilippo
d745e8dfb3
Merge pull request #4536 from tporadowski/antirez_unstable-cli-history 
Always enable command history in redis-cli run on a TTY
 2017-12-14 22:14:45 +01:00
Salvatore Sanfilippo
16ad748b26 Merge pull request #4536 from tporadowski/antirez_unstable-cli-history 
Always enable command history in redis-cli run on a TTY
 2017-12-14 22:14:45 +01:00
Salvatore Sanfilippo
398b2084af
Merge pull request #4528 from nashe/patch-oob-read-4527 
Prevent off-by-one read in stringmatchlen()
 2017-12-14 12:21:32 +01:00