2713 Commits

Author SHA1 Message Date
antirez
71b0cfb773 bzero -> memset 2012-02-21 10:06:04 +01:00
antirez
80509bda87 Fix 32bit build of hiredis 2012-02-19 20:49:20 +01:00
antirez
d6e3216e2b Applied a few modifications to hiredis to tune it for speed (redis-benchmark) and ability to read more deeply nested replies (redis-cli). 2012-02-19 20:33:59 +01:00
antirez
c23e3efd71 The hiredis lib shipped with Redis was updated to latest version. 2012-02-19 20:26:50 +01:00
Pieter Noordhuis
cf230ceee6 Don't expire keys when loading an RDB after a SYNC
The cron is responsible for expiring keys. When keys are expired at
load time, it is possible that the snapshot of a master node gets
modified. This can in turn lead to inconsistencies in the data set.

A more concrete example of this behavior follows. A user reported a
slave that would show an monotonically increase input buffer length,
shortly after completing a SYNC. Also, `INFO` output showed a single
blocked client, which could only be the master link. Investigation
showed that indeed the `BRPOP` command was fed by the master. This
command can only end up in the stream of write operations when it did
NOT block, and effectively executed `RPOP`. However, when the key
involved in the `BRPOP` is expired BEFORE the command is executed, the
client executing it will block. The client in this case, is the master
link.
2012-02-16 17:21:13 +01:00
antirez
5c54ab0b7f Issue #330 regression test. 2012-02-16 16:13:40 +01:00
antirez
aac79685ac Now HINCRBY can detect overflows too. Fix for issue #330. 2012-02-16 16:09:08 +01:00
antirez
a82c3fcaf3 Return ASAP from checkClientOutputBufferLimits() if c->reply_bytes is zero. 2012-02-16 12:20:56 +01:00
antirez
3afa9ae83c Merge branch 'issue327' into unstable 2012-02-16 09:40:27 +01:00
antirez
fd1236fc2d Add stdint.h in endianconv.h to fix issue #336. 2012-02-15 12:21:04 +01:00
antirez
2a34b225c4 redis-check-aof is now large files safe also on 32 bit systems. 2012-02-14 19:57:51 +01:00
antirez
eb3d93fd27 add -f flag to cp when installing, otherwise stopping the server is
needed when installing a new Redis version. Thanks to Scott Kevill.
Fixes issue #335.
2012-02-14 16:15:24 +01:00
antirez
9a68f79cd5 endian.c/h -> endianconv.c/h to avoid issues with broken libraries search paths. 2012-02-14 16:11:46 +01:00
antirez
40bf784fbf Merge remote-tracking branch 'origin/unstable' into unstable 2012-02-14 16:02:04 +01:00
antirez
55e02e58fa intset.c endianess fixes. 2012-02-14 15:35:50 +01:00
Salvatore Sanfilippo
16a12bd1a7 Merge pull request #334 from lsbardel/quantredis
added lua struct c extension
2012-02-13 15:05:59 -08:00
lsbardel
35a943766b added lua struct c extension 2012-02-13 21:05:21 +00:00
antirez
f03979dbaf ziplist.c endianess fixes, chapter 5. 2012-02-09 17:09:01 +01:00
antirez
b87552bbb1 ziplist.c endianess fixes, chapter 4. 2012-02-09 16:36:25 +01:00
antirez
2b6f42d9de ziplist.c endianess fixes, chapter 3. 2012-02-09 16:28:35 +01:00
antirez
ab401f90d8 more ziplist.c endianess fixes 2012-02-08 23:20:39 +01:00
antirez
b10e6ebb86 ziplist.c fixes for bigendian 2012-02-08 22:59:35 +01:00
antirez
3fcae1cc78 A few small BSD related fixes. 2012-02-08 22:24:59 +01:00
antirez
6647d9f2a4 more practical maxmemory+slaves hint in redis.conf 2012-02-08 00:20:46 +01:00
antirez
4c8f3d3345 redis.conf updated with new maxmemory semantics 2012-02-08 00:17:27 +01:00
antirez
bd66a75484 debugging messages removed from freeMemoryIfNeeded() 2012-02-08 00:10:20 +01:00
antirez
97f45bad9b Fixes to c->reply_bytes computation, and debug messages to closely study the behavior of memory pressure + slaves + maxmemory + blocked slaves. 2012-02-07 17:41:31 +01:00
antirez
e91e56ebeb Fixes to 2.6 release notes file 2012-02-07 15:08:38 +01:00
antirez
f57707f408 Precision of getClientOutputBufferMemoryUsage() greatily improved, see issue #327 for more information. 2012-02-07 13:05:36 +01:00
antirez
0de0faf4a0 freeMemoryIfNeeded() minor refactoring 2012-02-06 16:56:42 +01:00
antirez
31ae67e8ce Also remove size of AOF buffers from used memory when doing the math for freeMemoryIfNeeded() 2012-02-06 16:35:43 +01:00
antirez
e2ca4d43e8 A first (work in progress) release notes for 2.6 2012-02-05 11:08:01 +01:00
antirez
820df7eac3 INSTALL now redirects the user to README 2012-02-05 09:38:41 +01:00
antirez
06909a2241 Redis Manifesto moved from src to root dir 2012-02-05 09:37:08 +01:00
antirez
ee273aa92c This fixes issue #327, is a very complex fix (unfortunately), details:
1) sendReplyToClient() now no longer stops transferring data to a single
client in the case we are out of memory (maxmemory-wise).

2) in processCommand() the idea of we being out of memory is no longer
the naive zmalloc_used_memory() > server.maxmemory. To say if we can
accept or not write queries is up to the return value of
freeMemoryIfNeeded(), that has full control about that.

3) freeMemoryIfNeeded() now does its math without considering output
buffers size. But at the same time it can't let the output buffers to
put us too much outside the max memory limit, so at the same time it
makes sure there is enough effort into delivering the output buffers to
the slaves, calling the write handler directly.

This three changes are the result of many tests, I found (partially
empirically) that is the best way to address the problem, but maybe
we'll find better solutions in the future.
2012-02-04 14:05:54 +01:00
antirez
ea71e06988 Use less memory when emitting the protocol, by using more shared objects for commonly emitted parts of the protocol. 2012-02-04 08:58:37 +01:00
antirez
67c4a45d53 Now Lua scripts dispatch Redis commands properly calling the call() function. In order to make this possible call() was improved with a new flags argument that controls how the Redis command is executed. 2012-02-02 16:30:52 +01:00
antirez
90754849a9 Set a 3.5 GB maxmemory limit with noeviction policy if a 32 bit instance without user-provided memory limits is detected. 2012-02-02 10:26:20 +01:00
antirez
0671914638 Added a server.arch_bits field instead of computing it at runtime for INFO. 2012-02-02 10:23:31 +01:00
antirez
c814e1baca Only incremnet stats for key miss/hit when the key is semantically accessed in read-only. 2012-02-01 21:51:20 +01:00
antirez
fdac48210c Added tests checking ability of the scripting engine to reorder the output of commands with a random output regarding signle elements position in the multi bulk reply. 2012-02-01 17:49:03 +01:00
antirez
61cf87d7e3 A few SORT tests made more resistant to false negatives resulitng from poor randomization of Redis hash function with one byte inputs. 2012-02-01 17:37:48 +01:00
antirez
2b9f125601 New SORT tests checking the new more deterministic behavior of SORT sorting algorithm. 2012-02-01 17:17:52 +01:00
antirez
d26bae3ce9 Make SORT BY <constant> STORE ... to always produce the same output by force sorting, so that we have deterministic replication of this command. 2012-02-01 17:05:45 +01:00
antirez
4a6e6ac8e6 SORT is now more deterministic: does not accept to compare by score items that have scores not representing a valid double. Also items with the same score are compared lexycographically. At the same time the scripting side introduced the ability to sort the output of SORT when sort uses the BY <constant> optimization, resulting in no specific ordering. Since in this case the user may use GET, and the result of GET can be null, converted into false as Lua data type, this commit also introduces the ability to sort Lua tables containining false, only if the first (faster) attempt at using just table.sort with a single argument fails. 2012-02-01 15:22:28 +01:00
antirez
1a786437db Order output of commands returning random arrays using table.sort when called from Lua, partially fixing issue #165. The issue is yet not completely fixed since we can't add the REDIS_CMD_SORT_FOR_SCRIPT flag in SORT currently, both because it may contain NULLs and because it is not cool to re-sort everything at every call when instead this should be sorted only if BY <constant> is used. 2012-01-31 16:09:21 +01:00
antirez
62072a2780 Fixed redis-benchmark --help output typo 2012-01-31 11:43:32 +01:00
antirez
884c2f0e68 64 bit instances are no longer limited to have at max 2^32-1 elements in lists. 2012-01-31 10:35:52 +01:00
antirez
eeb8c0a5f5 minimal change to obuf-limits.tcl test to make sure there are no false positives with 32bit instances as well. 2012-01-30 21:08:10 +01:00
antirez
35de9ef7f4 Merge remote-tracking branch 'origin/unstable' into unstable 2012-01-30 10:40:28 +01:00