12038 Commits

Author SHA1 Message Date
Yossi Gottlieb
f4c7f1ac27 TLS: Some redis.conf clarifications. 2020-02-05 18:30:12 +02:00
Oran Agra
13a7379024 update RM_SignalModifiedKey doc comment 2020-02-05 18:15:38 +02:00
Oran Agra
7d12ef55ca Optimize temporary memory allocations for getKeysFromCommand mechanism
now that we may use it more often (ACL), these excessive calls to malloc
and free can become an overhead.
2020-02-05 18:06:33 +02:00
Salvatore Sanfilippo
ec92713d1e Merge pull request #6831 from oranagra/config_c_refactor_3
config.c verbose error replies for CONFIG SET, like config file parsing
2020-02-05 13:41:15 +01:00
Salvatore Sanfilippo
823d8e6a8b Merge pull request #6829 from oranagra/memory_get_keys
memoryGetKeys helper function so that ACL can limit access to keys for MEMORY command
2020-02-05 13:33:18 +01:00
Oran Agra
097a0a52d6 config.c verbose error replies for CONFIG SET, like config file parsing
We noticed that the error replies for the generic mechanism for enums
are very verbose for config file parsing, but not for config set
command.

instead of replicating this code, i did a small refactoring to share
code between CONFIG SET and config file parsing.

and also renamed the enum group functions to be consistent with the
naming of other types.
2020-02-05 11:41:24 +02:00
Oran Agra
f7067d371b memoryGetKeys helper function so that ACL can limit access to keys for MEMORY command 2020-02-05 09:42:49 +02:00
Guy Benoish
a0d45826a3 Add RM_CreateStringFromDouble 2020-02-04 19:28:09 +05:30
antirez
f1518f63b1 ACL LOG: make max log entries configurable. 2020-02-04 13:19:40 +01:00
antirez
da054f14f0 ACL LOG: test for AUTH reason. 2020-02-04 12:58:48 +01:00
antirez
debc5d4ef9 ACL LOG: log failed auth attempts. 2020-02-04 12:55:26 +01:00
lifubang
54199c93be fix ssl flag check for redis-cli
Signed-off-by: lifubang <lifubang@acmcoder.com>
2020-02-04 17:32:30 +08:00
Guy Benoish
2ad427f862 ld2string should fail if string contains \0 in the middle
This bug affected RM_StringToLongDouble and HINCRBYFLOAT.
I added tests for both cases.

Main changes:
1. Fixed string2ld to fail if string contains \0 in the middle
2. Use string2ld in getLongDoubleFromObject - No point of
   having duplicated code here

The two changes above broke RM_SaveLongDouble/RM_LoadLongDouble
because the long double string was saved with length+1 (An innocent
mistake, but it's actually a bug - The length passed to
RM_SaveLongDouble should not include the last \0).
2020-02-04 10:23:48 +01:00
Leo Murillo
5b2c6c5efa Set ZSKIPLIST_MAXLEVEL to optimal value given 2^64 elements and p=0.25 2020-02-04 10:23:48 +01:00
antirez
229229eb55 Add more info in the unblockClientFromModule() function. 2020-02-04 10:23:48 +01:00
WuYunlong
294b194ad4 Fix lua related memory leak. 2020-02-04 10:23:48 +01:00
Guy Benoish
d9f508d527 Modules: Fix blocked-client-related memory leak
If a blocked module client times-out (or disconnects, unblocked
by CLIENT command, etc.) we need to call moduleUnblockClient
in order to free memory allocated by the module sub-system
and blocked-client private data

Other changes:
Made blockedonkeys.tcl tests a bit more aggressive in order
to smoke-out potential memory leaks
2020-02-04 10:23:48 +01:00
WuYunlong
7d63a7d128 Add tcl regression test in scripting.tcl to reproduce memory leak. 2020-02-04 10:23:48 +01:00
Yossi Gottlieb
a27a4b82f4 TLS: Fix missing initialization in redis-cli. 2020-02-04 10:23:48 +01:00
Oran Agra
2ffb9a3682 fix uninitialized info_cb var in module.c 2020-02-04 10:23:48 +01:00
Salvatore Sanfilippo
32e2e7770a Merge pull request #6818 from leomurillo/zskiplistLevels
Set ZSKIPLIST_MAXLEVEL to 32
2020-02-04 10:20:56 +01:00
Salvatore Sanfilippo
2659773a0b Merge pull request #6825 from trevor211/fixMemoryLeakAboutLuaScript
Fix memory leak about lua script
2020-02-04 10:19:16 +01:00
WuYunlong
85bc26f8da Fix lua related memory leak. 2020-02-04 16:38:46 +08:00
WuYunlong
c0c29adce9 Add tcl regression test in scripting.tcl to reproduce memory leak. 2020-02-04 16:34:11 +08:00
John Sully
6bb1429a46 module fixes
Former-commit-id: ef4e11ecb8a6f1a05bb21f014120b0ef9e771b60
2020-02-04 01:22:25 -05:00
John Sully
771787273a Fix cluster test failures from Redis 6 merge
Former-commit-id: fd702e43f19ac2b8097afef84a73c8e71172979b
2020-02-03 20:00:09 -05:00
Salvatore Sanfilippo
a0781a2ce8 Merge pull request #6808 from yossigo/fix/redis-cli-openssl-1.0.x
TLS: Fix missing initialization in redis-cli.
2020-02-03 16:43:56 +01:00
Salvatore Sanfilippo
bac311851e Merge pull request #6824 from oranagra/fix_module_c_uninit_var
fix uninitialized info_cb var in module.c
2020-02-03 15:46:13 +01:00
Oran Agra
f5d37082ca fix uninitialized info_cb var in module.c 2020-02-03 16:35:39 +02:00
Guy Benoish
2492bdc90b Exclude "keymiss" notification from NOTIFY_ALL
Because "keymiss" is "special" compared to the rest of
the notifications (Trying not to break existing apps
using the 'A' format for notifications)

Also updated redis.conf and module.c docs
2020-02-03 15:43:44 +05:30
Leo Murillo
0ab1604c0c Set ZSKIPLIST_MAXLEVEL to optimal value given 2^64 elements and p=0.25 2020-02-02 02:48:00 -06:00
John Sully
ae0a3e9f65 addRef memory model too restrictive
Former-commit-id: 249e0fdd363853ab7b489314002bdacd2438fa55
2020-02-01 21:52:17 -05:00
John Sully
8ea5d731ad RDB memory leaks
Former-commit-id: 6208118b133c7f4209fd0a55d2a75341407e3e2c
2020-01-30 17:57:10 -05:00
John Sully
24c9edd93b replication memory leaks
Former-commit-id: 73020b6a939f241ade7512d58a4ddf17f5a803c5
2020-01-30 17:56:24 -05:00
John Sully
1cfc7071f5 Fix memory leak in cron
Former-commit-id: a9667e84ad44a3f2c08df0d95caeb6364f3f3509
2020-01-30 17:55:48 -05:00
John Sully
8f9fc831a6 Merge branch 'redis_merge' into unstable
Former-commit-id: ab1524ff1a8290199bc5a88e2bd9623566866d6f
2020-01-30 16:05:40 -05:00
Salvatore Sanfilippo
541a667c77 Merge pull request #6812 from guybe7/str_convert_fix
ld2string should fail if string contains \0 in the middle
2020-01-30 17:51:04 +01:00
Guy Benoish
add0229c31 DEBUG OBJECT should pass keyname to module when loading 2020-01-30 19:15:12 +05:30
Guy Benoish
3fd717daee ld2string should fail if string contains \0 in the middle
This bug affected RM_StringToLongDouble and HINCRBYFLOAT.
I added tests for both cases.

Main changes:
1. Fixed string2ld to fail if string contains \0 in the middle
2. Use string2ld in getLongDoubleFromObject - No point of
   having duplicated code here

The two changes above broke RM_SaveLongDouble/RM_LoadLongDouble
because the long double string was saved with length+1 (An innocent
mistake, but it's actually a bug - The length passed to
RM_SaveLongDouble should not include the last \0).
2020-01-30 18:15:17 +05:30
antirez
8185f2b6ce ACL LOG: implement a few basic tests. 2020-01-30 11:14:13 +01:00
antirez
bc168c91ec ACL LOG: also log ACL errors in the scripting/MULTI ctx. 2020-01-30 10:50:32 +01:00
Yossi Gottlieb
a7420b2478 TLS: Fix missing initialization in redis-cli. 2020-01-29 21:40:02 +02:00
antirez
eef1489240 ACL LOG: implement LOG RESET. 2020-01-29 18:51:04 +01:00
antirez
5bcb4e6905 ACL LOG: group similar entries in a given time delta. 2020-01-29 18:40:32 +01:00
antirez
2ed300b786 Add more info in the unblockClientFromModule() function. 2020-01-29 12:47:50 +01:00
Salvatore Sanfilippo
d0bb1e572f Merge pull request #6699 from guybe7/module_blocked_on_key_timeout_memleak
Modules: Fix blocked-client-related memory leak
2020-01-29 12:06:14 +01:00
John Sully
ae344960f1 CRON jobs were running half as often as required
Former-commit-id: 1069d0b4bf39818cbd72d0bcbd168769244cf18f
2020-01-28 21:40:40 -05:00
John Sully
1adc5e9832 More threading fixes from merge
Former-commit-id: 4a980f4ddbebe3f62703aa3de67c93cdffb6b4b8
2020-01-28 17:54:00 -05:00
antirez
f550dfca47 ACL LOG: actually emit entries. 2020-01-28 18:04:20 +01:00
antirez
99a5b98bf0 ACL LOG: implement ACL LOG subcommadn skeleton. 2020-01-28 17:30:50 +01:00