antirez
feef1367c6
Streams: fix unblocking logic into a consumer group.
...
When a client blocks for a consumer group, we don't know the actual ID
we want to be served: other clients blocked in the same consumer group
may be served first, so the consumer group latest delivered ID changes.
This was not handled correctly, all the clients in the consumer group
were unblocked without data but the first.
2018-07-10 11:11:41 +02:00
dejun.xdj
4ba944c3eb
Streams: fix xreadgroup crash after xgroup SETID is sent.
...
For issue #5111 .
2018-07-10 16:26:13 +08:00
Salvatore Sanfilippo
e4d7cbfe2c
Merge pull request #5095 from 0xtonyxia/fix-indentation
...
Fix indentation.
2018-07-09 13:56:39 +02:00
dejun.xdj
10255ac477
Bugfix: PEL is incorrect when consumer is blocked using xreadgroup with NOACK option.
...
Save NOACK option into client.blockingState structure.
2018-07-09 13:40:29 +02:00
antirez
28d5d87741
redis-cli: fix #4990 additional argument in help.
2018-07-09 13:36:47 +02:00
antirez
e938b8a1dd
redis-cli: fix #5096 double error message.
2018-07-09 13:25:48 +02:00
antirez
375589d028
redis-cli: cliConnect() flags CC_FORCE and CC_QUIET.
...
We need CC_QUIET in order to fix #5096 by silently failing if needed.
2018-07-09 13:24:30 +02:00
Amit Dey
2a28f06a75
fixing broken link in CONTRIBUTING
...
http://help.github.com/send-pull-requests/
is no longer supported
this change modifies the link to the working one
https://help.github.com/articles/creating-a-pull-request/
2018-07-09 13:14:57 +02:00
dejun.xdj
5335463d44
CLIENT UNBLOCK: fix client unblock help message.
2018-07-09 13:03:57 +02:00
minkikim89
c37742de0e
fix whitespace in redis-cli.c
2018-07-09 12:59:13 +02:00
WuYunlong
ad57103fed
fix compile warning in addReplySubcommandSyntaxError
2018-07-09 12:57:12 +02:00
antirez
aefa752cf9
Use nolocks_localtime() for safer logging.
2018-07-04 16:50:22 +02:00
antirez
7604f6792f
Cache timezone and daylight active flag for safer logging.
...
With such information will be able to use a private localtime()
implementation serverLog(), which does not use any locking and is both
thread and fork() safe.
2018-07-04 16:45:00 +02:00
antirez
3a6894cdd2
Localtime: clarify is_leap_year() working with comments.
2018-07-04 15:50:41 +02:00
antirez
e522dd5788
Localtime: fix comment about leap year.
2018-07-04 15:16:54 +02:00
antirez
6d1b29d7c6
Localtime: fix daylight saving adjustment. Use * not +.
2018-07-04 15:16:20 +02:00
antirez
fbd7290478
Localtime: fix daylight time documentation and computation.
2018-07-04 14:09:07 +02:00
dejun.xdj
aa62b5ebe9
Fix indentation.
2018-07-04 20:04:06 +08:00
antirez
d21c58867e
Localtime: add a test main() function to check the output.
2018-07-04 13:46:31 +02:00
antirez
a72f9c1931
Localtime: day of month is 1 based. Convert from 0 based "days".
2018-07-04 13:35:40 +02:00
antirez
5caae0e6e9
Localtime: fix timezone adjustment.
2018-07-04 13:35:15 +02:00
antirez
ecba1a2fd4
Localtime: compute year, month and day of the month.
2018-07-04 13:25:55 +02:00
antirez
bb802969d7
Localtime: basics initial calculations. Year missing.
2018-07-04 13:16:53 +02:00
antirez
e8f72804f5
Localtime function skeleton and file added.
2018-07-04 12:56:12 +02:00
Jack Drogon
df7bafeb44
Fix typo
2018-07-03 18:19:46 +02:00
antirez
57dc5832a7
Clarify the pending_querybuf field of clients.
2018-07-03 13:25:41 +02:00
antirez
dc6c3bfe71
Improve style of PR #5084 .
2018-07-03 13:23:29 +02:00
Salvatore Sanfilippo
4bcdfb0c5d
Merge pull request #5084 from chendq8/pending-querybuf
...
limit the size of pending-querybuf in masterclient
2018-07-03 13:19:37 +02:00
antirez
32fc058177
Set repl_down_since to zero on state change.
...
PR #5081 fixes an "interesting" bug about Redis Cluster failover but in
general about the updating of repl_down_since, that is used in order to
count the time a slave was left disconnected from its master.
While the fix provided resolves the specific issue, in general the
validity of repl_down_since is limited to states that are different
than the state CONNECTED, and the disconnected time is set when the
state is DISCONNECTED. However from CONNECTED to other states, the state
machine must always go to DISCONNECTED first. So it makes sense to set
the field to zero (since it is meaningless in that context) when the
state is set to CONNECTED.
2018-07-03 12:42:14 +02:00
Salvatore Sanfilippo
c8110e814c
Merge pull request #5081 from trevor211/fixClusterFailover
...
cluster failover bug
2018-07-03 12:36:53 +02:00
chendianqiang
0a32c93dd5
Merge branch 'unstable' into pending-querybuf
2018-07-03 10:07:26 +08:00
antirez
9f30306d44
addReplySubSyntaxError() renamed to addReplySubcommandSyntaxError().
2018-07-02 18:49:34 +02:00
Salvatore Sanfilippo
e7b480369b
Merge pull request #4998 from itamarhaber/module_command_help
...
Module command help
2018-07-02 18:46:56 +02:00
Salvatore Sanfilippo
b077de1862
Merge pull request #5071 from akshaynagpal/patch-2
...
Added link to Google Group
2018-07-02 18:41:58 +02:00
Salvatore Sanfilippo
5c3a0414d0
Merge pull request #5068 from shenlongxing/fix-rename-command
...
fix empty string for sentinel rename-command
2018-07-02 18:40:35 +02:00
Salvatore Sanfilippo
dc30938cbc
Merge pull request #5090 from trevor211/test_helper_tcl
...
fix tests/test_helper.tcl with --wait-server option.
2018-07-02 17:51:04 +02:00
WuYunlong
a14da4dfe3
fix tests/test_helper.tcl with --wait-server option.
...
Issue #5063 added --wait-server option, but can not work.
2018-07-02 19:26:52 +08:00
chendianqiang
2dc66b6bcc
limit the size of pending-querybuf in masterclient
2018-07-01 14:43:53 +08:00
WuYunlong
cfa0f8850d
fix server.repl_down_since resetting, so that slaves could failover
...
automatically as expected.
2018-06-30 09:39:08 +08:00
WuYunlong
f50f714c92
cluster.tcl: Add master consecutively down test.
2018-06-30 09:29:35 +08:00
antirez
56750fbaed
Change CLIENT LIST TYPE help string.
...
Making it more similar to KILL.
2018-06-29 18:03:00 +02:00
Salvatore Sanfilippo
3314ac96e3
Merge pull request #5075 from soloestoy/client-list-types
...
FEATURE: implements client list type option
2018-06-29 18:00:32 +02:00
Salvatore Sanfilippo
7f0c97febf
Merge pull request #5074 from soloestoy/fix-compile-warning
...
fix some compile warnings
2018-06-29 17:56:47 +02:00
Salvatore Sanfilippo
81597e4e64
Merge pull request #5076 from 0xtonyxia/add-no-auth-warning-option
...
Add no auth warning option
2018-06-29 13:32:58 +02:00
dejun.xdj
4535fd3b8b
Check if password is used on command line interface.
2018-06-28 19:09:22 +08:00
dejun.xdj
2171b9622d
Fix trailing white space.
2018-06-28 18:47:28 +08:00
dejun.xdj
e9feeb822a
Fix code format issue.
2018-06-28 18:39:42 +08:00
dejun.xdj
47308e7a14
Don't output password warning message when --no-auth-warning is used.
2018-06-28 18:38:24 +08:00
dejun.xdj
a9ec9aa0ae
Avoid -Woverlength-strings compile warning.
...
Using another fprintf call to output the rest help message.
2018-06-28 18:22:06 +08:00
antirez
4ff8dc478f
Rax library updated (node callback).
2018-06-28 12:19:06 +02:00