John Sully
96c4f5ecfc
processEventsWhileBlocked not exception safe
...
Former-commit-id: 1ef187533c26bfa0c084a815b8b80de92ba1cf0b
2020-02-17 19:03:49 -05:00
John Sully
a086023407
Fix race condition with IStorage batches
...
Former-commit-id: a2eabd044c9048662a63ff0f980ed947dc145912
2020-02-17 19:00:31 -05:00
John Sully
0b315702c2
processEventsWhileBlocked not exception safe
...
Former-commit-id: 432543956c74351a12af2cb258a7a0ba5daa9b27
2020-02-17 18:57:13 -05:00
John Sully
447dccb083
Merge branch 'redis_6_merge' into keydbpro
...
Former-commit-id: b16090958d392a6de908562dee65a02c851f07ae
2020-02-16 20:07:03 -05:00
John Sully
79e945f5e5
Merge branch 'unstable' into redis_6_merge
...
Former-commit-id: 6a71de7835f427cebb23e4c2f0d19ed63a02f09e
2020-02-16 19:14:51 -05:00
John Sully
47f98259f9
Support C++14 and remove dependency on future standard 2a
...
Former-commit-id: 18496b62853738bf7bd48f65fe34aafcba8bbe0b
2020-02-16 19:04:56 -05:00
John Sully
4d01660331
Graceful shutdown of server threads when quit is requested
...
Former-commit-id: b9db899f6ccea62222170c6eec264d403a7a911d
2020-02-16 18:53:46 -05:00
John Sully
f176f0e131
Virtual dtor for DB base class
...
Former-commit-id: 953b1cb3a2fec808751d2e7507efe8896f671921
2020-02-16 18:43:36 -05:00
John Sully
3de971b10c
Fix memory leak in RDB load
...
Former-commit-id: 4e9d2f08b11cc76bb2716514fa6d55f76160fd13
2020-02-16 18:42:14 -05:00
John Sully
2f62f3fbcd
Fix memory leak in RDB load
...
Former-commit-id: 06ad1c15d719a34fed36244b12a593f749bbb8a6
2020-02-16 18:41:50 -05:00
John Sully
ed1b2ce2c8
Fix memory leak in RDB load
...
Former-commit-id: a424194f42e61a324489464a0fed14837b8191e4
2020-02-16 18:41:29 -05:00
John Sully
535925abea
Fix leak deserializing expire
...
Former-commit-id: 1a7e14d8ef96f7849ecdb120f3339b2423ca25d8
2020-02-16 18:40:00 -05:00
John Sully
6301f717e2
Merge branch 'keydbpro' of https://github.com/JohnSully/KeyDB-Pro into keydbpro
...
Former-commit-id: 770941923d183c0dfed8d5bf8f2299fc4fadf9c6
2020-02-16 18:38:15 -05:00
John Sully
4fe301adb7
Merge branch 'redis_6_merge' into keydbpro
...
Former-commit-id: 8456e92d6e446f1cc20d9cea2328998da0a4d7d5
2020-02-16 18:28:45 -05:00
John Sully
873d5537e8
Merge branch 'unstable' into redis_6_merge
...
Former-commit-id: 30a603ce05956195aa027a3400eafd48d2750ea7
2020-02-16 18:18:24 -05:00
John Sully
e5f23dbd07
Merge branch 'unstable' of https://github.com/JohnSully/KeyDB into unstable
...
Former-commit-id: 63ae679fe1104f7cde4c9b5efe4a72be6b3435db
2020-02-16 18:12:11 -05:00
John Sully
0b5a7f5482
Memory leak fix on config, and redisDb dtor
...
Former-commit-id: b92bbf4de8ffc3edc965e2f9da4dd82ed7071559
2020-02-16 17:08:00 -05:00
John Sully
faba0a99c3
Add GC shutdown command
...
Former-commit-id: 28e8f68016b554f3d410502c2af1641368c2bb92
2020-02-16 16:49:04 -05:00
John Sully
b7a60588c1
Merge branch 'unstable' into keydbpro
...
Former-commit-id: f3457e2a9a8464bac656b57256316bbddb65d9e9
2020-02-16 04:04:34 -05:00
John Sully
5780020388
Fix memory leak of ReplicaNestState on shutdown
...
Former-commit-id: 4781eda7225c2640e25387663c33ef74cd98b0c4
2020-02-16 03:43:29 -05:00
John Sully
e7760419e5
Fix leak when tombstone exists
...
Former-commit-id: 3d0ccdf6d2ddc523a3532c46cf905023d207b8cb
2020-02-16 03:36:47 -05:00
John Sully
5f2e509129
aeDeleteEventLoop use after free and leak fixes
...
Former-commit-id: 2fd93c5789a4e81455d51b2a4786f708e8d6a2d7
2020-02-16 03:34:25 -05:00
John Sully
f99b59ae96
aeDeleteEventLoop use after free and leak fixes
...
Former-commit-id: 77820e5d50e0426570285a2c740c47b05a7c6c2f
2020-02-16 03:33:45 -05:00
Khem Raj
5e762d847c
Mark extern definition of SDS_NOINIT in sds.h
...
This helps in avoiding multiple definition of this variable, its also
defined globally in sds.c
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2020-02-12 14:17:54 +01:00
lifubang
54f5499aee
correct help info for --user and --pass
...
Signed-off-by: lifubang <lifubang@acmcoder.com>
2020-02-12 14:17:54 +01:00
Seunghoon Woo
0c952b13d0
[FIX] revisit CVE-2015-8080 vulnerability
2020-02-12 14:17:54 +01:00
Guy Benoish
dd34f70368
Diskless-load emptyDb-related fixes
...
1. Call emptyDb even in case of diskless-load: We want modules
to get the same FLUSHDB event as disk-based replication.
2. Do not fire any module events when flushing the backups array.
3. Delete redundant call to signalFlushedDb (Called from emptyDb).
2020-02-12 14:17:54 +01:00
lifubang
5e042dbc05
fix ssl flag check for redis-cli
...
Signed-off-by: lifubang <lifubang@acmcoder.com>
2020-02-12 14:17:54 +01:00
Guy Benoish
dcbe8bfad1
Exclude "keymiss" notification from NOTIFY_ALL
...
Because "keymiss" is "special" compared to the rest of
the notifications (Trying not to break existing apps
using the 'A' format for notifications)
Also updated redis.conf and module.c docs
2020-02-12 14:17:54 +01:00
Oran Agra
36caf2e42b
update RM_SignalModifiedKey doc comment
2020-02-12 14:17:40 +01:00
Oran Agra
3067352a8d
Add handling of short read of module id in rdb
2020-02-12 14:17:40 +01:00
Yossi Gottlieb
9baaf858f9
TLS: Update documentation.
2020-02-12 14:17:40 +01:00
Oran Agra
4440133e9a
A few non-data commands that should be allowed while loading or stale
...
SELECT, and HELLO are commands that may be executed by the client
as soon as it connects, there's no reason to block them, preventing the
client from doing the rest of his sequence (which might just be INFO or
CONFIG, etc).
MONITOR, DEBUG, SLOWLOG, TIME, LASTSAVE are all non-data accessing
commands, which there's no reason to block.
2020-02-12 14:17:40 +01:00
Oran Agra
c957794144
Memory leak when bind config is provided twice
2020-02-12 14:17:40 +01:00
Oran Agra
1333a46b7e
fix maxmemory config warning
...
the warning condition was if usage > limit (saying it'll cause eviction
or oom), but in fact the eviction and oom depends on used minus slave
buffers.
other than fixing the condition, i add info about the current usage and
limit, which may be useful when looking at the log.
2020-02-12 14:17:40 +01:00
Oran Agra
8e7282eb3e
Fix client flags to be int64 in module.c
...
currently there's no bug since the flags these functions handle are
always lower than 32bit, but still better fix the type to prevent future
bugs.
2020-02-12 14:17:40 +01:00
Oran Agra
a678390e52
moduleRDBLoadError, add key name, and use panic rather than exit
...
using panic rather than exit means you get s stack trace of the code
path that experianced the error, and possibly other info.
2020-02-12 14:17:40 +01:00
Oran Agra
f42ce57d0f
stopAppendOnly resets aof_rewrite_scheduled
...
althouh in theory, users can do BGREWRITEAOF even if aof is disabled, i
suppose it is more common that the scheduled flag is set by either
startAppendOnly, of a failed initial AOFRW fork (AOF_WAIT_REWRITE)
2020-02-12 14:15:56 +01:00
Oran Agra
919fbf421d
reduce repeated calls to use_diskless_load
...
this function possibly iterates on the module list
2020-02-12 14:15:56 +01:00
Oran Agra
df096bc96b
add SAVE subcommand to ACL HELP and top comment
2020-02-12 14:15:56 +01:00
Oran Agra
22e45d46fe
freeClientAsync don't lock mutex if there's just one thread
2020-02-12 14:15:56 +01:00
Oran Agra
a55e584706
DEBUG HELP - add PROTOCOL
2020-02-12 14:15:56 +01:00
Oran Agra
ba28924418
move restartAOFAfterSYNC from replicaofCommand to replicationUnsetMaster
...
replicationUnsetMaster can be called from other places, not just
replicaofCOmmand, and all of these need to restart AOF
2020-02-12 14:15:56 +01:00
Guy Benoish
5a6cfbf4ca
Some refactroing using getClientType instead of CLIENT_SLAVE
2020-02-12 14:15:56 +01:00
Guy Benoish
fae306b374
Fix small bugs related to replica and monitor ambiguity
...
1. server.repl_no_slaves_since can be set when a MONITOR client disconnects
2. c->repl_ack_time can be set by a newline from a MONITOR client
3. Improved comments
2020-02-12 14:15:56 +01:00
Yossi Gottlieb
736309660f
TLS: Some redis.conf clarifications.
2020-02-12 14:15:56 +01:00
Oran Agra
488e194787
config.c verbose error replies for CONFIG SET, like config file parsing
...
We noticed that the error replies for the generic mechanism for enums
are very verbose for config file parsing, but not for config set
command.
instead of replicating this code, i did a small refactoring to share
code between CONFIG SET and config file parsing.
and also renamed the enum group functions to be consistent with the
naming of other types.
2020-02-12 14:15:56 +01:00
Oran Agra
c82ccf0670
memoryGetKeys helper function so that ACL can limit access to keys for MEMORY command
2020-02-12 14:15:56 +01:00
antirez
51c1a9f8fb
ACL LOG: make max log entries configurable.
2020-02-12 14:15:35 +01:00
antirez
ea1e1b12c9
ACL LOG: test for AUTH reason.
2020-02-12 14:15:35 +01:00