antirez
1c82be419f
RESP3: Aggregate deferred lengths functions.
2019-01-09 17:00:29 +01:00
antirez
da3d2db500
RESP3: Double replies and aggregate lengths initial functions.
2019-01-09 17:00:29 +01:00
Salvatore Sanfilippo
1eca7e34c7
Merge pull request #5729 from artix75/cluster_manager_fix_cmd
...
Cluster Manager del-node: use CLUSTER RESET in place of SHUTDOWN
2019-01-09 10:11:27 +01:00
chenyangyang
fa4e6ba00d
Update ae.c
...
Update comment
2019-01-06 15:01:25 +08:00
artix
39f4a23296
Cluster Manager del-node: use CLUSTER RESET in place of SHUTDOWN
...
See issue #5687
2018-12-27 17:20:42 +01:00
artix
853b97fd85
Cluster Manager: enable --cluster-replace also for 'fix' command.
2018-12-19 17:29:25 +01:00
artix
1055c6b484
Fixed memory leak in clusterManagerCompareKeysValues.
2018-12-18 18:45:10 +01:00
artix
4ec37c3bd3
Cluster Manager: compare key values after BUSYKEY error (migration).
...
If a key exists in the target node during a migration (BUSYKEY),
the value of the key on both nodes (source and target) will be compared.
If the key has the same value on both keys, the migration will be
automatically retried with the REPLACE argument in order to override
the target's key.
If the key has different values, the behaviour will depend on such
cases:
- In case of 'fix' command, the migration will stop and the user
will be warned to manually check the key(s).
- In other cases (ie. reshard), if the user launched the command
with the --cluster-replace option, the migration will be
retried with the REPLACE argument, elsewhere the migration will
stop and the user will be warned.
2018-12-18 17:45:35 +01:00
artix
cc21057890
Cluster Manager: avoid using reply error messages to check slot status.
...
Slot assignment status is now checked by using CLUSTER SLOTS.
Furthermore, one memory leak has been fixed.
2018-12-12 13:34:43 +01:00
antirez
b166aff1bf
freeMemoryIfNeeded() small refactoring.
...
Related to issue #5686 and PR #5689 .
2018-12-12 11:37:15 +01:00
Salvatore Sanfilippo
5daed99b5c
Merge pull request #5689 from soloestoy/donot-evict-when-AOF-loading
...
evict: don't care about mem if loading
2018-12-12 11:29:10 +01:00
antirez
76e5519516
Crashing is too much in addReplyErrorLength().
...
See #5663 .
2018-12-11 17:50:18 +01:00
zhaozhao.zz
19ef3890e9
evict: don't care about mem if loading
...
When loading data, we call processEventsWhileBlocked
to process events and execute commands.
But if we are loading AOF it's dangerous, because
processCommand would call freeMemoryIfNeeded to evict,
and that will break data consistency, see issue #5686 .
2018-12-12 00:25:58 +08:00
antirez
e16d2dfb5f
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-12-11 13:30:04 +01:00
antirez
7c25def9a0
stringmatchlen() fuzz test added.
...
Verified to be able to trigger at least #5632 . Does not report other
issues.
2018-12-11 13:29:30 +01:00
antirez
c30b9dc868
Fix stringmatchlen() read past buffer bug.
...
See #5632 .
2018-12-11 13:18:52 +01:00
Salvatore Sanfilippo
5106a32402
Merge pull request #5665 from louiszhw/unstable
...
fix comments fault discription
2018-12-11 13:03:09 +01:00
Salvatore Sanfilippo
0a0dbf6027
Merge pull request #4264 from lsytj0413/unstable
...
fix a typo: craeted -> created
2018-12-11 13:02:28 +01:00
zhaozhao.zz
3ab14c56f7
fix typo
2018-12-11 19:53:54 +08:00
zhaozhao.zz
e60a8ce2f2
multi: ignore multiState's cmd_flags when loading AOF
2018-12-11 19:47:36 +08:00
antirez
fc4b1319d0
Reject EXEC containing write commands against RO replica.
...
Thanks to @soloestoy for discovering this issue in #5667 .
This is an alternative fix in order to avoid both cycling the clients
and also disconnecting clients just having valid read-only transactions
pending.
2018-12-11 11:39:21 +01:00
artix
440e8164a1
Cluster Manager:
...
- Multiple owners checking in 'fix'/'check' commands is now
optional (using --cluster-search-multiple-owners).
- Updated help.
2018-12-10 18:01:18 +01:00
artix
17ff4e873f
Cluster Manager:
...
- FixOpenSlot now correctly updates in-memory cluster configuration.
- Improved output messages.
2018-12-10 17:43:58 +01:00
artix
c2ea297052
Cluster Manager: 'fix' command now handles open slots with migrating state
...
in one node and importing state in multiple nodes.
2018-12-10 17:43:58 +01:00
artix
b5d9d24d3b
Cluster Manager: setting new slot owner is now handled atomically
...
in 'fix' command.
2018-12-10 17:43:58 +01:00
artix
0c7a108dc9
Cluster Manager: code cleanup.
2018-12-10 17:43:58 +01:00
artix
8b7107fd32
Cluster Manager: check/fix commands now handle multiple owners even if
...
all slots are covered and not open.
2018-12-10 17:39:54 +01:00
Salvatore Sanfilippo
c70976ab30
Merge pull request #5626 from soloestoy/remove-useless-code
...
remove useless tryObjectEncoding in debug assert
2018-12-07 17:09:56 +01:00
Salvatore Sanfilippo
d21f7e44ea
Merge pull request #5633 from oranagra/frag_bytes_signed
...
fix #5580 , display fragmentation and rss overhead bytes as signed
2018-12-07 17:09:10 +01:00
antirez
04d2faf7f6
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-12-07 17:07:14 +01:00
antirez
50c8580a33
Remove no longer relevant comment in processCommand().
2018-12-07 17:06:55 +01:00
Salvatore Sanfilippo
2af190d9f8
Merge pull request #5673 from soloestoy/check-current-client-after-freememory
...
networking: current_client should not be NULL when trim qb_pos
2018-12-07 17:03:48 +01:00
antirez
fd4bea34b5
DEBUG DIGEST-VALUE implemented.
2018-12-07 16:41:54 +01:00
antirez
439e29a38a
DEBUG DIGEST refactoring: extract function to digest a value.
2018-12-07 16:30:33 +01:00
zhaozhao.zz
33b1020859
networking: current_client should not be NULL when trim qb_pos
2018-12-07 19:14:33 +08:00
yura
3cd5152007
redis-cli reshard/rebalance: ability to force replacement on existing keys
2018-12-07 14:14:11 +03:00
Salvatore Sanfilippo
8b67a78dfa
Merge pull request #5460 from krallin/env-password
...
cli: pass auth through REDISCLI_AUTH
2018-12-07 11:30:07 +01:00
Salvatore Sanfilippo
32ed397859
Merge pull request #5664 from yongman/fix-rediscli-output-format
...
Fix cluster call reply format readable
2018-12-07 11:28:18 +01:00
lsytj0413
c8443f9a9e
fix a typo: craeted -> created
2018-12-06 11:08:59 +08:00
hdmg
35c693ff33
fix comments fault discription
2018-12-05 17:15:02 +08:00
yongman
8696f09314
Fix cluster call reply format readable
2018-12-04 17:36:42 +08:00
Madelyn Olson
38120939d1
Fixed a serverPanic when sending an invalid command to a monitor client
2018-12-04 07:17:17 +00:00
Oran Agra
1dbdef57cd
fix #5580 , display fragmentation and rss overhead bytes as signed
...
these metrics become negative when RSS is smaller than the used_memory.
This can easily happen when the program allocated a lot of memory and haven't
written to it yet, in which case the kernel doesn't allocate any pages to the process
2018-12-02 15:29:20 +02:00
zhaozhao.zz
9a4161b048
remove useless tryObjectEncoding in debug assert
2018-11-30 12:05:46 +08:00
Salvatore Sanfilippo
120daf0a04
Merge pull request #5562 from soloestoy/memory-usage-more-accurate
...
MEMORY command: make USAGE more accurate
2018-11-28 18:16:04 +01:00
Salvatore Sanfilippo
2648ccacb6
Merge pull request #5594 from yongman/fix-rediscli-fixcoverage
...
Fix choose a random master node for slot assignment
2018-11-28 18:13:04 +01:00
zhaozhao.zz
cfb421fe3a
MEMORY command: make USAGE more accurate
...
In MEMORY USAGE command, we count the key argv[2] into usage,
but the argument in command may contains free spaces because of
sdsMakeRoomFor. But the key in db never contains free spaces
because we use sdsdup when dbAdd, so using the real key to
count the usage is more accurate.
2018-11-29 01:01:51 +08:00
Salvatore Sanfilippo
d4ac0287e3
Merge pull request #5572 from Weiliang-Li/patch3-util
...
fix comment typo in util.c
2018-11-28 17:14:21 +01:00
Salvatore Sanfilippo
307ef33b65
Merge pull request #5597 from lamby/clarify-socket-creation-error-message
...
Clarify the "Creating Server TCP listening socket" error message
2018-11-28 17:06:51 +01:00
Salvatore Sanfilippo
747a4a928e
Merge pull request #5598 from lamby/dont-treat-unsupported-protocols-as-fatal-errors
...
Don't treat unsupported protocols as fatal errors
2018-11-28 17:06:17 +01:00