Jeffrey Lovitz
bd01334da1
CLI Help text loop verifies arg count
2018-08-12 12:47:01 -04:00
Jeffrey Lovitz
ba7f792de1
CLI Help text loop verifies arg count
2018-08-12 12:47:01 -04:00
zhaozhao.zz
a3a1460525
Streams: update listpack with new pointer in XDEL
2018-08-04 01:06:53 +08:00
zhaozhao.zz
594d3b9023
Streams: update listpack with new pointer in XDEL
2018-08-04 01:06:53 +08:00
zhaozhao.zz
eb87da6127
AOF: discard if we lost EXEC when loading aof
2018-08-03 23:30:34 +08:00
zhaozhao.zz
d3dcee62b0
AOF: discard if we lost EXEC when loading aof
2018-08-03 23:30:34 +08:00
Salvatore Sanfilippo
39c70e728b
Merge pull request #5146 from 0xtonyxia/fix-xclaim-id-parse
...
Streams: ID of xclaim command should start from the sixth argument.
2018-08-03 13:45:27 +02:00
Salvatore Sanfilippo
4898e66aff
Merge pull request #5146 from 0xtonyxia/fix-xclaim-id-parse
...
Streams: ID of xclaim command should start from the sixth argument.
2018-08-03 13:45:27 +02:00
Salvatore Sanfilippo
7b5e7f3ed0
Merge pull request #5151 from shenlongxing/fix-stream
...
Fix stream command paras
2018-08-03 13:39:32 +02:00
Salvatore Sanfilippo
abd081d9a4
Merge pull request #5151 from shenlongxing/fix-stream
...
Fix stream command paras
2018-08-03 13:39:32 +02:00
shenlongxing
fe56c67405
Fix stream command paras
2018-08-03 19:01:15 +08:00
shenlongxing
82d4d8020f
Fix stream command paras
2018-08-03 19:01:15 +08:00
antirez
0ce8323c0d
Fix AOF comment to report the current behavior.
...
Realted to #5201 .
2018-08-03 12:46:06 +02:00
antirez
53abe14ecf
Fix AOF comment to report the current behavior.
...
Realted to #5201 .
2018-08-03 12:46:06 +02:00
antirez
2f282aee0b
Fix zslUpdateScore() edge case.
...
When the element new score is the same of prev/next node, the
lexicographical order kicks in, so we can safely update the node in
place only when the new score is strictly between the adjacent nodes
but never equal to one of them.
Technically speaking we could do extra checks to make sure that even if the
score is the same as one of the adjacent nodes, we can still update on
place, but this rarely happens, so probably not a good deal to make it
more complex.
Related to #5179 .
2018-08-01 19:04:53 +02:00
antirez
bd510b68e4
Fix zslUpdateScore() edge case.
...
When the element new score is the same of prev/next node, the
lexicographical order kicks in, so we can safely update the node in
place only when the new score is strictly between the adjacent nodes
but never equal to one of them.
Technically speaking we could do extra checks to make sure that even if the
score is the same as one of the adjacent nodes, we can still update on
place, but this rarely happens, so probably not a good deal to make it
more complex.
Related to #5179 .
2018-08-01 19:04:53 +02:00
antirez
29226a3919
More commenting of zslUpdateScore().
2018-08-01 18:54:15 +02:00
antirez
159f8b6628
More commenting of zslUpdateScore().
2018-08-01 18:54:15 +02:00
antirez
12ff0c0d79
Explain what's the point of zslUpdateScore() in top comment.
2018-08-01 18:53:09 +02:00
antirez
f8d849930f
Explain what's the point of zslUpdateScore() in top comment.
2018-08-01 18:53:09 +02:00
antirez
e3e94ec35c
Remove old commented zslUpdateScore() from source.
2018-08-01 18:50:49 +02:00
antirez
684d020fb9
Remove old commented zslUpdateScore() from source.
2018-08-01 18:50:49 +02:00
antirez
0b800c4332
Optimize zslUpdateScore() as asked in #5179 .
2018-08-01 18:50:31 +02:00
antirez
6435022be5
Optimize zslUpdateScore() as asked in #5179 .
2018-08-01 18:50:31 +02:00
antirez
6dd0d6f7dd
zsetAdd() refactored adding zslUpdateScore().
2018-08-01 18:27:56 +02:00
antirez
bc61916100
zsetAdd() refactored adding zslUpdateScore().
2018-08-01 18:27:56 +02:00
zhaozhao.zz
9042d1c249
Streams: propagate specified MAXLEN instead of approximated
...
Slaves and rebooting redis may have different radix tree struct,
by different stream* config options. So propagating approximated
MAXLEN to AOF/slaves may lead to date inconsistency.
2018-08-01 10:34:12 +08:00
zhaozhao.zz
7a6234405c
Streams: propagate specified MAXLEN instead of approximated
...
Slaves and rebooting redis may have different radix tree struct,
by different stream* config options. So propagating approximated
MAXLEN to AOF/slaves may lead to date inconsistency.
2018-08-01 10:34:12 +08:00
zhaozhao.zz
14d6318b32
Streams: reset approx_maxlen in every maxlen loop
2018-08-01 10:31:27 +08:00
zhaozhao.zz
faaf2dd356
Streams: reset approx_maxlen in every maxlen loop
2018-08-01 10:31:27 +08:00
zhaozhao.zz
da6b7516f1
Streams: XTRIM will return an error if MAXLEN with a count < 0
2018-08-01 10:31:27 +08:00
zhaozhao.zz
aa428375b8
Streams: XTRIM will return an error if MAXLEN with a count < 0
2018-08-01 10:31:27 +08:00
zhaozhao.zz
20c6a7fe2c
Streams: propagate original MAXLEN argument in XADD context
...
If we rewrite the MAXLEN argument as zero when no trimming
was performed, date between master and slave and aof will
be inconsistent, because `xtrim maxlen 0` means delete all
entries in stream.
2018-08-01 10:31:27 +08:00
zhaozhao.zz
97716ce543
Streams: propagate original MAXLEN argument in XADD context
...
If we rewrite the MAXLEN argument as zero when no trimming
was performed, date between master and slave and aof will
be inconsistent, because `xtrim maxlen 0` means delete all
entries in stream.
2018-08-01 10:31:27 +08:00
antirez
2f2987ffc5
Streams IDs parsing refactoring.
...
Related to #5184 .
2018-07-31 18:08:52 +02:00
antirez
ac0bab8498
Streams IDs parsing refactoring.
...
Related to #5184 .
2018-07-31 18:08:52 +02:00
Salvatore Sanfilippo
187fa78637
Merge pull request #5184 from 0xtonyxia/streams-id-opt
...
Streams: rearrange the usage of '-' and '+' IDs in stream commands.
2018-07-31 17:58:13 +02:00
Salvatore Sanfilippo
4a306f73a6
Merge pull request #5184 from 0xtonyxia/streams-id-opt
...
Streams: rearrange the usage of '-' and '+' IDs in stream commands.
2018-07-31 17:58:13 +02:00
Salvatore Sanfilippo
7b41701eb8
Merge pull request #5187 from oranagra/testsuite_improvements
...
Testsuite improvements
2018-07-31 17:20:09 +02:00
Salvatore Sanfilippo
26be45c0f8
Merge pull request #5187 from oranagra/testsuite_improvements
...
Testsuite improvements
2018-07-31 17:20:09 +02:00
antirez
e245ed9a44
Cluster cron announce IP minor refactoring.
2018-07-31 17:13:03 +02:00
antirez
3ee0e176bc
Cluster cron announce IP minor refactoring.
2018-07-31 17:13:03 +02:00
Salvatore Sanfilippo
093adb7ef9
Merge pull request #5191 from shenlongxing/fix-memory-leak
...
Fix cluster-announce-ip memory leak
2018-07-31 17:11:16 +02:00
Salvatore Sanfilippo
ff738d87d9
Merge pull request #5191 from shenlongxing/fix-memory-leak
...
Fix cluster-announce-ip memory leak
2018-07-31 17:11:16 +02:00
antirez
b0392e75ec
Tranfer -> transfer typo fixed.
2018-07-31 16:41:33 +02:00
antirez
7ab75dc72e
Tranfer -> transfer typo fixed.
2018-07-31 16:41:33 +02:00
Salvatore Sanfilippo
92b39a0abf
Merge pull request #5189 from soloestoy/refactor-dbOverwrite
...
refactor dbOverwrite to make lazyfree work
2018-07-31 16:40:35 +02:00
Salvatore Sanfilippo
c42b48d349
Merge pull request #5189 from soloestoy/refactor-dbOverwrite
...
refactor dbOverwrite to make lazyfree work
2018-07-31 16:40:35 +02:00
antirez
db693be00d
Refactoring: replace low-level checks with writeCommandsDeniedByDiskError().
2018-07-31 13:16:43 +02:00
antirez
2e67ea193d
Refactoring: replace low-level checks with writeCommandsDeniedByDiskError().
2018-07-31 13:16:43 +02:00