Salvatore Sanfilippo
cfffda83fb
Merge pull request #7371 from oranagra/fix_disconnectSlaves
...
fix disconnectSlaves, to try to free each slave.
2020-06-08 10:43:51 +02:00
Salvatore Sanfilippo
74a203a050
Merge pull request #7352 from soloestoy/donot-free-protected-client-when-blocking
...
donot free protected client in freeClientsInAsyncFreeQueue()
2020-06-08 10:43:17 +02:00
Oran Agra
12504105c4
fix disconnectSlaves, to try to free each slave.
...
the recent change in that loop (iteration rather than waiting for it to
be empty) was intended to avoid an endless loop in case some slave would
refuse to be freed.
but the lookup of the first client remained, which would have caused it
to try the first one again and again instead of moving on.
2020-06-08 09:50:06 +03:00
Oran Agra
2bb297b102
Don't queue commands in an already aborted MULTI state
2020-06-08 09:43:10 +03:00
Oran Agra
2fa077b0e9
Avoid rejecting WATCH / UNWATCH, like MULTI/EXEC/DISCARD
...
Much like MULTI/EXEC/DISCARD, the WATCH and UNWATCH are not actually
operating on the database or server state, but instead operate on the
client state. the client may send them all in one long pipeline and check
all the responses only at the end, so failing them may lead to a
mismatch between the client state on the server and the one on the
client end, and execute the wrong commands (ones that were meant to be
discarded)
the watched keys are not actually stored in the client struct, but they
are in fact part of the client state. for instance, they're not cleared
or moved in SWAPDB or FLUSHDB.
2020-06-08 09:16:32 +03:00
John Sully
66e9afe49c
Some valgrind fixes
...
Former-commit-id: ba974c9810dc30b6b5bd21c4bcc6cc5b219f7ea4
2020-06-07 23:20:10 -04:00
John Sully
a41672672b
fix valgrind false error
...
Former-commit-id: 9817db7eddf06becd151e5fef7cc6808777c49cb
2020-06-07 20:17:47 -04:00
John Sully
052a707097
Endurance mode for tests ignore flaky ones
...
Former-commit-id: 515bb0e6bda8abcab4f8b4cd693084594c734007
2020-06-07 16:59:59 -04:00
John Sully
0a17bbe748
Solo tests should work with loopn
...
Former-commit-id: bc7ea8fb20c71ace6c35559791e2e8dc6bf4097b
2020-06-07 15:06:50 -04:00
John Sully
c31b96339a
Stream tests rely on deferring clients, mitigate races caused by them
...
Former-commit-id: 2caf8e4c8095215b189942b7eaec3bf5023f7fcf
2020-06-07 13:59:41 -04:00
xhe
7eba5c308a
return the correct proto version
...
HELLO should return the current proto version, while the code hardcoded
3
2020-06-07 13:34:55 +08:00
John Sully
2c560f27b8
replication test race
...
Former-commit-id: e1f3cd6ec3bf2319484de04c3796dcfa75e0479c
2020-06-07 01:14:57 -04:00
John Sully
b006a06924
fix race in test
...
Former-commit-id: 02e821530a402796697e63c68e768b563de0a3cb
2020-06-07 00:44:11 -04:00
John Sully
f7a7d16524
Make lazyfree more reliable
...
Former-commit-id: b6c3d80edbdc4348c071b4108b039f4da5c88ce5
2020-06-07 00:40:58 -04:00
Oran Agra
f33de403ed
fix pingoff test race
2020-06-06 11:44:21 +02:00
Kevin Fwu
49af4d07e4
Fix TLS certificate loading for chained certificates.
...
This impacts client verification for chained certificates (such as Lets
Encrypt certificates). Client Verify requires the full chain in order to
properly verify the certificate.
2020-06-06 11:44:21 +02:00
antirez
44b76a75d2
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2020-06-06 11:44:05 +02:00
antirez
329fddbda1
Revert "Implements sendfile for redis."
...
This reverts commit 9cf500a3f67e4e2ce51414c354e3472faf095d5b.
2020-06-06 11:43:29 +02:00
antirez
925a2cd5aa
Revert "avoid using sendfile if tls-replication is enabled"
...
This reverts commit b9abecfc4c97db01fa6f09180c68a92ea5974ac1.
2020-06-06 11:43:29 +02:00
Liu Zhen
84a7a90586
fix clusters mixing accidentally by gossip
...
`clusterStartHandshake` will start hand handshake
and eventually send CLUSTER MEET message, which is strictly prohibited
in the REDIS CLUSTER SPEC.
Only system administrator can initiate CLUSTER MEET message.
Futher, according to the SPEC, rather than IP/PORT pairs, only nodeid
can be trusted.
2020-06-06 11:43:29 +02:00
antirez
cd63359a17
Fix handling of special chars in ACL LOAD.
...
Now it is also possible for ACL SETUSER to accept empty strings
as valid operations (doing nothing), so for instance
ACL SETUSER myuser ""
Will have just the effect of creating a user in the default state.
This should fix #7329 .
2020-06-06 11:43:29 +02:00
antirez
61074b43a6
Revert "Implements sendfile for redis."
...
This reverts commit 9cf500a3f67e4e2ce51414c354e3472faf095d5b.
2020-06-06 11:42:45 +02:00
antirez
d1e23e04aa
Revert "avoid using sendfile if tls-replication is enabled"
...
This reverts commit b9abecfc4c97db01fa6f09180c68a92ea5974ac1.
2020-06-06 11:42:41 +02:00
John Sully
3403a1f648
Detect issues like #189
...
Former-commit-id: 0042586190a3e5b212a015aeb3577695cd3623c5
2020-06-05 22:18:28 -04:00
John Sully
18f6579ec7
Ensure CRON jobs run in a clean environment
...
Former-commit-id: c6dce838b7cc94e115fd73a64dda663f0a2c28c5
2020-06-05 21:35:47 -04:00
zhaozhao.zz
5d0774d62f
AOF: append origin SET if no expire option
2020-06-03 17:55:18 +08:00
zhaozhao.zz
ad6b71352d
donot free protected client in freeClientsInAsyncFreeQueue
...
related #7234
2020-06-02 11:48:14 +08:00
John Sully
096f38ab39
Undecorated new is OK to use
...
Former-commit-id: 5b885bb1649805f6a2edb8d28edd1447bb6c4843
2020-06-01 23:36:01 -04:00
John Sully
7b70d8c7d0
maxmem tests should be run solo for higher reliability
...
Former-commit-id: 95f46e60779fca715244745ced7b2ab04bbf9e3a
2020-06-01 16:50:30 -04:00
John Sully
0241311e69
Remove debug logs that shouldn't have been checked in
...
Former-commit-id: 31f58311e3de7441d81dd37bd4396be3b64efec5
2020-06-01 16:34:05 -04:00
John Sully
9fb7552b63
PSYNC test shouldn't wait forever
...
Former-commit-id: 130613e16636923296a8d5b2c4bc623e62fef2f5
2020-06-01 16:13:58 -04:00
John Sully
2b08505fed
PSYNC test reliability improvements (test only issue)
...
Former-commit-id: 50fd4fa7e62f3996f15f6a8c4dcd892022f111ec
2020-06-01 16:01:26 -04:00
John Sully
4f7102f46c
Fix for issue #187 we need to properly handle the case where a key with a subkey expirey itself expires during load
...
Former-commit-id: e6a9a6b428b91b6108df24ae6285ea9b582b7b23
2020-06-01 15:33:19 -04:00
John Sully
bd4f1e2a16
Update endurance.yml
...
Former-commit-id: d6be93537ebd31f1c6c1dc63c5d3c299b49efec9
2020-06-01 00:25:31 -04:00
John Sully
4038288c4e
Fix module multithreaded test failures
...
Former-commit-id: 1ef35cf466ea944c56974b3795d7d6b5e89f5a3d
2020-05-31 23:46:12 -04:00
John Sully
df5b0f0be5
sendfile has high latency in some scenarios, don't use it
...
Former-commit-id: 1eb0e3c1c604e71c54423f1d11b8c709c847a516
2020-05-31 23:22:25 -04:00
John Sully
dfe42b8485
we must always respect the output of sdscat, also change the string so its not a substring of other config params
...
Former-commit-id: e50313b20718bc8df0a53c11b0960e4bcb2177d4
2020-05-31 23:22:10 -04:00
John Sully
80078c93cb
Do another iteration for endurance
...
Former-commit-id: ac3f8d1ac7af62b01816156b8578f4cbc48709e1
2020-05-31 22:51:02 -04:00
John Sully
eddc1ad46a
Don't start multimaster tests until all nodes are connected
...
Former-commit-id: 202b97eff76501e736a2f0969607e3297e9703a4
2020-05-31 22:50:30 -04:00
John Sully
4b08ccd0b1
Fix client race in test (test only issue)
...
Former-commit-id: f25aebf2698509a132ebf599374b245efb51e365
2020-05-31 21:39:50 -04:00
John Sully
e71c44b506
--loop should run forever
...
Former-commit-id: 9b1e636a6654a4ba3b629b5ad1097caf513ca000
2020-05-31 21:27:15 -04:00
John Sully
eb8a183583
PUBSUB test reliability: A client race was erroneously failing tests (test only issue)
...
Former-commit-id: 5147f0153ad1efb827a1709c10cd0f58e6ae65d8
2020-05-31 21:27:15 -04:00
John Sully
500c4f39ef
Update endurance.yml
...
Former-commit-id: 88f7739ae00d5eefb34bce741bb78f2b9aca84b6
2020-05-31 17:50:02 -04:00
John Sully
da309f7045
Active replicas referencing eachother should connect one at a time
...
Former-commit-id: c0c033a0c175eebdf2173e6e4e59e792d2fe4285
2020-05-31 16:03:50 -04:00
John Sully
8740fb79af
Fix race in futex_sleep
...
Former-commit-id: 73300c57005a49bafbfc44db9c40ba7d1d4eedce
2020-05-31 16:03:50 -04:00
John Sully
628ce68b49
Update endurance.yml
...
Former-commit-id: 37033179feb9d92d6124b08e662353959eb4f19e
2020-05-31 14:18:12 -04:00
Salvatore Sanfilippo
52e56bf70d
Merge pull request #7349 from oranagra/pingoff-test-race
...
fix pingoff test race
2020-05-31 16:00:04 +02:00
Oran Agra
c480af9007
fix pingoff test race
2020-05-31 15:51:52 +03:00
Salvatore Sanfilippo
f644b112ad
Merge pull request #7334 from kevin-fwu/tls_load_chained_certs
...
Fix TLS certificate loading for chained certificates.
2020-05-31 14:32:56 +02:00
John Sully
d96ea0f8e3
Update endurance.yml
...
Former-commit-id: 3e6a5ac9cfb108c9d1da4b97b0aaffb9ed92ce88
2020-05-31 03:43:06 -04:00