John Sully
4352a26a5b
Fix memory leak in cron
...
Former-commit-id: a9667e84ad44a3f2c08df0d95caeb6364f3f3509
2020-01-30 17:55:48 -05:00
John Sully
0f459fca2e
Merge branch 'redis_merge' into unstable
...
Former-commit-id: ab1524ff1a8290199bc5a88e2bd9623566866d6f
2020-01-30 16:05:40 -05:00
Salvatore Sanfilippo
53ac8c7df2
Merge pull request #6812 from guybe7/str_convert_fix
...
ld2string should fail if string contains \0 in the middle
2020-01-30 17:51:04 +01:00
Guy Benoish
d72b7ed4fb
DEBUG OBJECT should pass keyname to module when loading
2020-01-30 19:15:12 +05:30
Guy Benoish
2deb55512f
ld2string should fail if string contains \0 in the middle
...
This bug affected RM_StringToLongDouble and HINCRBYFLOAT.
I added tests for both cases.
Main changes:
1. Fixed string2ld to fail if string contains \0 in the middle
2. Use string2ld in getLongDoubleFromObject - No point of
having duplicated code here
The two changes above broke RM_SaveLongDouble/RM_LoadLongDouble
because the long double string was saved with length+1 (An innocent
mistake, but it's actually a bug - The length passed to
RM_SaveLongDouble should not include the last \0).
2020-01-30 18:15:17 +05:30
antirez
b189a21974
ACL LOG: implement a few basic tests.
2020-01-30 11:14:13 +01:00
antirez
396161765b
ACL LOG: also log ACL errors in the scripting/MULTI ctx.
2020-01-30 10:50:32 +01:00
John Sully
e945cf0b1f
Merge branch 'redis_merge' into keydb_pro_merge
...
Former-commit-id: 2a760ac3b2cf12e45a9db9d0c2efe6efc4dc2aed
2020-01-29 21:30:20 -05:00
John Sully
5c1a0410b9
TLS Thread Safety fixes
...
Former-commit-id: e98a5fc108c5448307a8cc38182c79263f01102a
2020-01-29 21:21:47 -05:00
John Sully
96c5ffdc86
fix leak in cron
...
Former-commit-id: c1f4e344bdaf21bc74fae6e1b0cb7fc1ce687e62
2020-01-29 19:03:18 -05:00
John Sully
074dda1d27
Merge branch 'redis_merge' into keydb_pro_merge
...
Former-commit-id: e4f455a991b468a7abea169e5672d3039a8645f9
2020-01-29 15:57:43 -05:00
John Sully
36f497a1a5
TLS compile fixes
...
Former-commit-id: 0516809832cf22557592d15f39d64162fcd5083d
2020-01-29 15:57:25 -05:00
Yossi Gottlieb
93edb3ff3a
TLS: Fix missing initialization in redis-cli.
2020-01-29 21:40:02 +02:00
John Sully
81b616bfbb
Merge branch 'redis_merge' into keydb_pro_merge
...
Former-commit-id: e10d9de29059f42193560712991df0950eeef679
2020-01-29 13:43:45 -05:00
John Sully
9cd315e511
Fix active rep not merging on sync and add tests
...
Former-commit-id: fcb77d0431b195553eb1cd563286e5441f0c94cd
2020-01-29 13:26:04 -05:00
John Sully
14cf73deaa
Merge KeyDB 6
...
Former-commit-id: 9129b98c12b0da856bbda3eb68b4ddc7530693c9
2020-01-29 12:55:23 -05:00
antirez
30a466ba38
ACL LOG: implement LOG RESET.
2020-01-29 18:51:04 +01:00
antirez
6671032faf
ACL LOG: group similar entries in a given time delta.
2020-01-29 18:40:32 +01:00
antirez
17ff3173d6
Add more info in the unblockClientFromModule() function.
2020-01-29 12:47:50 +01:00
Salvatore Sanfilippo
bf53f9280a
Merge pull request #6699 from guybe7/module_blocked_on_key_timeout_memleak
...
Modules: Fix blocked-client-related memory leak
2020-01-29 12:06:14 +01:00
John Sully
9440c60954
Yet more multithreading fixes
...
Former-commit-id: 9f23062ebdf389f0c95e1f4ab22c36ca96060e1f
2020-01-28 21:42:55 -05:00
John Sully
5da19e0206
failure to post a function is not fatal unless we wrote part of a command (should be impossible)
...
Former-commit-id: e1c642a033ab0157a66571189e81817cb84fd421
2020-01-28 21:41:56 -05:00
John Sully
f31af3bacf
CRON jobs were running half as often as required
...
Former-commit-id: 1069d0b4bf39818cbd72d0bcbd168769244cf18f
2020-01-28 21:40:40 -05:00
John Sully
e54be2c065
CRON jobs were running half as often as required
...
Former-commit-id: a8f758144b8d79f9816ede3ae86c5c2d5d7d10dd
2020-01-28 21:39:56 -05:00
John Sully
e9a66f6dcd
Support C++14 and remove dependency on future standard 2a
...
Former-commit-id: 7ba1920069821bf369cae40926e0ac82923ad784
2020-01-28 19:06:33 -05:00
John Sully
8e7f3304b2
More threading fixes from merge
...
Former-commit-id: 4a980f4ddbebe3f62703aa3de67c93cdffb6b4b8
2020-01-28 17:54:00 -05:00
antirez
61dffd8669
ACL LOG: actually emit entries.
2020-01-28 18:04:20 +01:00
antirez
e8d0057710
ACL LOG: implement ACL LOG subcommadn skeleton.
2020-01-28 17:30:50 +01:00
John Sully
e3b2ef962b
reenable multithreading after merge
...
Former-commit-id: 9fbb9a551e83ddfc66894fba688dae7c9c3c7ae1
2020-01-27 19:59:04 -05:00
John Sully
8a86276a86
cron reliability
...
Former-commit-id: c24a7c03c207d5e6ad95ef8958c0cfb118c1b593
2020-01-27 18:31:02 -05:00
John Sully
7b9fe2217a
fix expire test failures during overwrite
...
Former-commit-id: 5a8280d5772e5d185b8e4010b86f01752be5c9b5
2020-01-27 18:26:23 -05:00
John Sully
39378f982e
Fix most tests (still some failures)
...
Former-commit-id: da83e841255487efe0e4b13d42b2dcc55a369838
2020-01-27 18:16:19 -05:00
antirez
3e9e27e98f
ACL LOG: data structures and initial functions.
2020-01-27 18:37:52 +01:00
John Sully
8e5fe97525
Merge remote-tracking branch 'redis/6.0' into redis_merge
...
Former-commit-id: ef9a3cadcf94326bf2f163db7698aad9a3c01690
2020-01-27 02:55:48 -05:00
qetu3790
6f2240aefd
Merge pull request #1 from qetu3790/qetu3790-patch-1
...
Fix not used constant in lru_test_mode.
2020-01-23 17:30:35 +08:00
qetu3790
bd60c11bd8
Fix not used constant in lru_test_mode.
...
LRU_CYCLE_PERIOD is defined,but not used.
2020-01-23 17:18:07 +08:00
John Sully
b7b8eb2ecb
Missing cron files
...
Former-commit-id: c983d57f739cc9b4b8271a6d069fad1b5a9d3dad
2020-01-21 19:51:16 -05:00
John Sully
262b9a5d92
Initial implementation of the CRON command
...
Former-commit-id: 3204a39ada15ec33ac7926dc8b8f0e1875b99acb
2020-01-21 19:50:28 -05:00
John Sully
7f8cb3600b
Bump version
...
Former-commit-id: f4319c12803f27a93150178f8b61f10aea09ce01
2020-01-20 19:20:50 -05:00
srzhao
38f6207f88
Check OOM at script start to get stable lua OOM state.
...
Checking OOM by `getMaxMemoryState` inside script might get different result
with `freeMemoryIfNeededAndSafe` at script start, because lua stack and
arguments also consume memory.
This leads to memory `borderline` when memory grows near server.maxmemory:
- `freeMemoryIfNeededAndSafe` at script start detects no OOM, no memory freed
- `getMaxMemoryState` inside script detects OOM, script aborted
We solve this 'borderline' issue by saving OOM state at script start to get
stable lua OOM state.
related to issue #6565 and #5250 .
2020-01-20 21:34:05 +08:00
antirez
721a39ddff
Document I/O threads in redis.conf.
2020-01-17 10:47:38 +01:00
antirez
cbabf779c2
Simplify #6379 changes.
2020-01-17 10:47:38 +01:00
antirez
ecd17e819c
Jump to right label on AOF parsing error.
...
Related to #6054 .
2020-01-17 10:47:38 +01:00
antirez
8e9d19bc65
Change error message for #6775 .
2020-01-17 10:47:38 +01:00
antirez
5be3a15a82
Setting N I/O threads should mean N-1 additional + 1 main thread.
2020-01-17 10:47:38 +01:00
WuYunlong
658749cc54
Free allocated sds in pfdebugCommand() to avoid memory leak.
2020-01-17 10:47:38 +01:00
antirez
1927932b43
Port PR #6110 to new connection object code.
2020-01-17 10:47:38 +01:00
Vasyl Melnychuk
ba146d4c09
Make error when submitting command in incorrect context more explicit
...
So error message `ERR only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context` will become
`ERR 'get' command submitted, but only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context`
2020-01-17 10:47:38 +01:00
WuYunlong
47988c9666
Fix potential memory leak of clusterLoadConfig().
2020-01-17 10:47:38 +01:00
antirez
f2df5773b1
A few comments about main thread serving I/O as well.
...
Related to #6110 .
2020-01-17 10:47:38 +01:00