Salvatore Sanfilippo
265a7e7ec7
Merge pull request #7357 from soloestoy/bugfix-aof-keepttl
...
AOF: append origin SET if no expire option
2020-06-08 11:02:00 +02:00
Salvatore Sanfilippo
cfffda83fb
Merge pull request #7371 from oranagra/fix_disconnectSlaves
...
fix disconnectSlaves, to try to free each slave.
2020-06-08 10:43:51 +02:00
Salvatore Sanfilippo
74a203a050
Merge pull request #7352 from soloestoy/donot-free-protected-client-when-blocking
...
donot free protected client in freeClientsInAsyncFreeQueue()
2020-06-08 10:43:17 +02:00
Oran Agra
12504105c4
fix disconnectSlaves, to try to free each slave.
...
the recent change in that loop (iteration rather than waiting for it to
be empty) was intended to avoid an endless loop in case some slave would
refuse to be freed.
but the lookup of the first client remained, which would have caused it
to try the first one again and again instead of moving on.
2020-06-08 09:50:06 +03:00
Oran Agra
2bb297b102
Don't queue commands in an already aborted MULTI state
2020-06-08 09:43:10 +03:00
Oran Agra
2fa077b0e9
Avoid rejecting WATCH / UNWATCH, like MULTI/EXEC/DISCARD
...
Much like MULTI/EXEC/DISCARD, the WATCH and UNWATCH are not actually
operating on the database or server state, but instead operate on the
client state. the client may send them all in one long pipeline and check
all the responses only at the end, so failing them may lead to a
mismatch between the client state on the server and the one on the
client end, and execute the wrong commands (ones that were meant to be
discarded)
the watched keys are not actually stored in the client struct, but they
are in fact part of the client state. for instance, they're not cleared
or moved in SWAPDB or FLUSHDB.
2020-06-08 09:16:32 +03:00
John Sully
66e9afe49c
Some valgrind fixes
...
Former-commit-id: ba974c9810dc30b6b5bd21c4bcc6cc5b219f7ea4
2020-06-07 23:20:10 -04:00
John Sully
a41672672b
fix valgrind false error
...
Former-commit-id: 9817db7eddf06becd151e5fef7cc6808777c49cb
2020-06-07 20:17:47 -04:00
John Sully
cc16e74f8b
fix valgrind false error
...
Former-commit-id: 887d8bdd110e04b30ffb215726e8aade39f0387a
2020-06-07 20:17:32 -04:00
John Sully
2faa1f5771
Merge branch 'keydbpro' into PRO_RELEASE_6
...
Former-commit-id: 3106f60e0ebdba5db944e704d4b148ea81c806f6
2020-06-07 17:05:00 -04:00
John Sully
a6195bbd43
Fix merge bug
...
Former-commit-id: cc03c32271997d26ce7f07f96588f126c5939e69
2020-06-07 17:04:46 -04:00
John Sully
052a707097
Endurance mode for tests ignore flaky ones
...
Former-commit-id: 515bb0e6bda8abcab4f8b4cd693084594c734007
2020-06-07 16:59:59 -04:00
John Sully
eda1bd2082
Bump version
...
Former-commit-id: 4a3e1f3b9b164ec0f19ca2a67c8003792a5ccc5c
2020-06-07 16:43:07 -04:00
John Sully
1392ba433b
Solo tests should work with loopn
...
Former-commit-id: 575fc9801094985e24671101e68549787b536782
2020-06-07 16:43:07 -04:00
John Sully
244d5d2243
Stream tests rely on deferring clients, mitigate races caused by them
...
Former-commit-id: eb18345a6113296b98fc59599aa670d58166081a
2020-06-07 16:43:07 -04:00
John Sully
b04c4f40bd
replication test race
...
Former-commit-id: d528c5c2c2ff8497563b5dc012f9ad458e93ecd4
2020-06-07 16:43:07 -04:00
John Sully
c83f094d3a
fix race in test
...
Former-commit-id: fa03a539f391e53bcd8237625dc0b52f3f25c9bd
2020-06-07 16:43:07 -04:00
John Sully
2a77cff00f
Make lazyfree more reliable
...
Former-commit-id: 9646b1d94475e39066887062f96f493c7529e440
2020-06-07 16:43:07 -04:00
John Sully
ebc4990f37
Detect issues like #189
...
Former-commit-id: cc5e906ebd3b09367f0a0daf861923e55182f1fd
2020-06-07 16:43:07 -04:00
John Sully
9427b52a48
Ensure CRON jobs run in a clean environment
...
Former-commit-id: b0e14683b2e655dc3aeb2f19b9227fc7fa24cc73
2020-06-07 16:43:07 -04:00
John Sully
5eab79c4bf
Undecorated new is OK to use
...
Former-commit-id: 8d5cc4cf0c9d05f0d68cffec2b87b5c3dcb562ba
2020-06-07 16:43:07 -04:00
John Sully
d6c972a55f
Bump version
...
Former-commit-id: 52a0556ba15b26d84ca9b5c804eb8fe438c9c888
2020-06-07 16:41:59 -04:00
John Sully
9a22fb489a
Merge branch 'keydbpro' into PRO_RELEASE_6
...
Former-commit-id: 6495fe1c7878f96dffa25a2879cb2b825c9e10b2
2020-06-07 16:41:36 -04:00
John Sully
067382bb8c
Merge branch 'unstable' into keydbpro
...
Former-commit-id: 461eea07260a31cd75753d5b7be691f5793a6f1b
2020-06-07 16:41:21 -04:00
John Sully
3b483cb82d
Report flash disk usage
...
Former-commit-id: 8e4a71ccd31e3c643a6f7b5154d8f2a65d2de76f
2020-06-07 16:40:03 -04:00
John Sully
0a17bbe748
Solo tests should work with loopn
...
Former-commit-id: bc7ea8fb20c71ace6c35559791e2e8dc6bf4097b
2020-06-07 15:06:50 -04:00
John Sully
c31b96339a
Stream tests rely on deferring clients, mitigate races caused by them
...
Former-commit-id: 2caf8e4c8095215b189942b7eaec3bf5023f7fcf
2020-06-07 13:59:41 -04:00
xhe
7eba5c308a
return the correct proto version
...
HELLO should return the current proto version, while the code hardcoded
3
2020-06-07 13:34:55 +08:00
John Sully
2c560f27b8
replication test race
...
Former-commit-id: e1f3cd6ec3bf2319484de04c3796dcfa75e0479c
2020-06-07 01:14:57 -04:00
John Sully
b006a06924
fix race in test
...
Former-commit-id: 02e821530a402796697e63c68e768b563de0a3cb
2020-06-07 00:44:11 -04:00
John Sully
f7a7d16524
Make lazyfree more reliable
...
Former-commit-id: b6c3d80edbdc4348c071b4108b039f4da5c88ce5
2020-06-07 00:40:58 -04:00
Oran Agra
f33de403ed
fix pingoff test race
2020-06-06 11:44:21 +02:00
Kevin Fwu
49af4d07e4
Fix TLS certificate loading for chained certificates.
...
This impacts client verification for chained certificates (such as Lets
Encrypt certificates). Client Verify requires the full chain in order to
properly verify the certificate.
2020-06-06 11:44:21 +02:00
antirez
44b76a75d2
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2020-06-06 11:44:05 +02:00
antirez
329fddbda1
Revert "Implements sendfile for redis."
...
This reverts commit 9cf500a3f67e4e2ce51414c354e3472faf095d5b.
2020-06-06 11:43:29 +02:00
antirez
925a2cd5aa
Revert "avoid using sendfile if tls-replication is enabled"
...
This reverts commit b9abecfc4c97db01fa6f09180c68a92ea5974ac1.
2020-06-06 11:43:29 +02:00
Liu Zhen
84a7a90586
fix clusters mixing accidentally by gossip
...
`clusterStartHandshake` will start hand handshake
and eventually send CLUSTER MEET message, which is strictly prohibited
in the REDIS CLUSTER SPEC.
Only system administrator can initiate CLUSTER MEET message.
Futher, according to the SPEC, rather than IP/PORT pairs, only nodeid
can be trusted.
2020-06-06 11:43:29 +02:00
antirez
cd63359a17
Fix handling of special chars in ACL LOAD.
...
Now it is also possible for ACL SETUSER to accept empty strings
as valid operations (doing nothing), so for instance
ACL SETUSER myuser ""
Will have just the effect of creating a user in the default state.
This should fix #7329 .
2020-06-06 11:43:29 +02:00
antirez
61074b43a6
Revert "Implements sendfile for redis."
...
This reverts commit 9cf500a3f67e4e2ce51414c354e3472faf095d5b.
2020-06-06 11:42:45 +02:00
antirez
d1e23e04aa
Revert "avoid using sendfile if tls-replication is enabled"
...
This reverts commit b9abecfc4c97db01fa6f09180c68a92ea5974ac1.
2020-06-06 11:42:41 +02:00
John Sully
3403a1f648
Detect issues like #189
...
Former-commit-id: 0042586190a3e5b212a015aeb3577695cd3623c5
2020-06-05 22:18:28 -04:00
John Sully
18f6579ec7
Ensure CRON jobs run in a clean environment
...
Former-commit-id: c6dce838b7cc94e115fd73a64dda663f0a2c28c5
2020-06-05 21:35:47 -04:00
John Sully
327f922e04
We need to search snapshots before deciding to not save a key
...
Former-commit-id: 357b09c500eecfe61970e121644a7200ac2387b9
2020-06-05 00:39:58 -04:00
John Sully
0606662009
Fix dangling lock
...
Former-commit-id: 212e56984edfa3221c73b1d3c083efcd28f0dd25
2020-06-04 22:59:24 -04:00
John Sully
d2a29bf343
Fix race when we free an item before we finish writing to disk making it temporarily unavailable
...
Former-commit-id: 6139cfee295261d0210f2af6217c2a23eeaf52b8
2020-06-04 22:18:03 -04:00
John Sully
9851fde2fa
Add latency marker for process changes phase for FLASH
...
Former-commit-id: 61e20b025d45b0af8ed60aab96246b30e4d0ed3d
2020-06-04 01:29:17 -04:00
John Sully
bc846d047d
Latency doctor updated for KeyDB Pro
...
Former-commit-id: a2690fca4a74e92eb44d5e38f886b08363a6d7b0
2020-06-04 01:28:52 -04:00
John Sully
8517297100
maxmem samples way too high
...
Former-commit-id: 599cac856d4ec77d59c5f5b4fae5b9f194c202ef
2020-06-04 01:28:34 -04:00
John Sully
54cc984d86
Make snapshot completion faster and add latency monitor
...
Former-commit-id: 8063be6ee70a652c22c3263dccf318366e208891
2020-06-04 01:07:14 -04:00
John Sully
f184eb6c3a
Consolidate snapshots should not consider keys in bulk storage
...
Former-commit-id: e02a8f503d45daf63150c60a8a8c3751b9b8581e
2020-06-04 00:26:51 -04:00