Guy Benoish
43329c9b64
Add the stream tag to XSETID tests
2020-04-27 15:52:49 +02:00
Dave-in-lafayette
1e17d3de79
fix for crash during panic before all threads are up
...
If there's a panic before all threads have been started (say, if file descriptor 0 is closed at exec), the panic response will crash here again.
2020-04-27 15:52:49 +02:00
antirez
3722f89f49
LCS -> STRALGO LCS.
...
STRALGO should be a container for mostly read-only string
algorithms in Redis. The algorithms should have two main
characteristics:
1. They should be non trivial to compute, and often not part of
programming language standard libraries.
2. They should be fast enough that it is a good idea to have optimized C
implementations.
Next thing I would love to see? A small strings compression algorithm.
2020-04-24 16:49:27 +02:00
antirez
373ae6061a
Also use propagate() in streamPropagateGroupID().
2020-04-24 10:15:04 +02:00
yanhui13
f03f1fad67
add tcl test for cluster slots
2020-04-24 10:15:04 +02:00
yanhui13
374ffdf1c1
optimize the output of cluster slots
2020-04-24 10:15:04 +02:00
antirez
4db38d2efd
Minor aesthetic changes to #7135 .
2020-04-24 10:15:04 +02:00
Valentino Geron
f0a261448c
XREADGROUP with NOACK should propagate only one XGROUP SETID command
2020-04-24 10:15:04 +02:00
antirez
fbdef6a9bd
ACL: re-enable command execution of disabled users.
...
After all I changed idea again: enabled/disabled should have a more
clear meaning, and it only means: you can't authenticate with such user
with new connections, however old connections continue to work as
expected.
2020-04-24 10:15:04 +02:00
antirez
05a41da75b
getRandomBytes(): use HMAC-SHA256.
...
Now that we have an interface to use this API directly, via ACL GENPASS,
we are no longer sure what people could do with it. So why don't make it
a strong primitive exported by Redis in order to create unique IDs and
so forth?
The implementation was tested against the test vectors that can
be found in RFC4231.
2020-04-24 10:14:48 +02:00
antirez
345c3768de
ACL GENPASS: take number of bits as argument.
2020-04-24 10:14:48 +02:00
antirez
639c8a1d91
ACL GENPASS: emit 256 bits instead of 128.
2020-04-24 10:14:48 +02:00
antirez
321acea038
ACL: deny commands execution of disabled users.
2020-04-24 10:14:48 +02:00
Theo Buehler
b0920e6e86
TLS: Fix build with SSL_OP_NO_CLIENT_RENEGOTIATION
...
There is no ssl in this scope, so the build breaks.
All the other options are set directly on the ctx.
2020-04-24 10:14:48 +02:00
Yossi Gottlieb
149b658b56
TLS: Fix build on older verisons of OpenSSL.
2020-04-24 10:14:48 +02:00
antirez
06917e581c
Tracking: test expired keys notifications.
2020-04-24 10:14:48 +02:00
antirez
e434b2ce4f
Tracking: NOLOOP tests.
2020-04-24 10:14:48 +02:00
antirez
f3a1728873
Tracking: signal key as modified when evicting.
2020-04-24 10:14:48 +02:00
antirez
e63bb7ec8c
Tracking: NOLOOP further implementation and fixes.
2020-04-24 10:14:48 +02:00
antirez
6791ff0525
Tracking: NOLOOP internals implementation.
2020-04-24 10:14:48 +02:00
antirez
725b8cc680
Implement redis_set_thread_title for MacOS.
...
Strange enough, pthread_setname_np() produces a warning for not defined
function even if pthread is included. Moreover the MacOS documentation
claims the return value for the function is void, but actually is int.
Related to #7089 .
2020-04-24 10:14:48 +02:00
zhenwei pi
3575b8706d
Threaded IO: set thread name for redis-server
...
Set thread name for each thread of redis-server, this helps us to
monitor the utilization and optimise the performance.
And suggested-by Salvatore, implement this feature for multi
platforms. Currently support linux and bsd, ignore other OS.
An exmaple on Linux:
# top -d 5 -p `pidof redis-server ` -H
PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND
3682671 root 20 0 227744 8248 3836 R 99.2 0.0 0:19.53 redis-server
3682677 root 20 0 227744 8248 3836 S 26.4 0.0 0:04.15 io_thd_3
3682675 root 20 0 227744 8248 3836 S 23.6 0.0 0:03.98 io_thd_1
3682676 root 20 0 227744 8248 3836 S 23.6 0.0 0:03.97 io_thd_2
3682672 root 20 0 227744 8248 3836 S 0.2 0.0 0:00.02 bio_close_file
3682673 root 20 0 227744 8248 3836 S 0.2 0.0 0:00.02 bio_aof_fsync
3682674 root 20 0 227744 8248 3836 S 0.0 0.0 0:00.00 bio_lazy_free
3682678 root 20 0 227744 8248 3836 S 0.0 0.0 0:00.00 jemalloc_bg_thd
3682682 root 20 0 227744 8248 3836 S 0.0 0.0 0:00.00 jemalloc_bg_thd
3682683 root 20 0 227744 8248 3836 S 0.0 0.0 0:00.00 jemalloc_bg_thd
3682684 root 20 0 227744 8248 3836 S 0.0 0.0 0:00.00 jemalloc_bg_thd
3682685 root 20 0 227744 8248 3836 S 0.0 0.0 0:00.00 jemalloc_bg_thd
3682687 root 20 0 227744 8248 3836 S 0.0 0.0 0:00.00 jemalloc_bg_thd
Another exmaple on FreeBSD-12.1:
PID USERNAME PRI NICE SIZE RES STATE C TIME WCPU COMMAND
5212 root 100 0 48M 7280K CPU2 2 0:26 99.52% redis-server{redis-server}
5212 root 38 0 48M 7280K umtxn 4 0:06 26.94% redis-server{io_thd_3}
5212 root 36 0 48M 7280K umtxn 6 0:06 26.84% redis-server{io_thd_1}
5212 root 39 0 48M 7280K umtxn 1 0:06 25.30% redis-server{io_thd_2}
5212 root 20 0 48M 7280K uwait 3 0:00 0.00% redis-server{redis-server}
5212 root 21 0 48M 7280K uwait 2 0:00 0.00% redis-server{bio_close_file}
5212 root 21 0 48M 7280K uwait 3 0:00 0.00% redis-server{bio_aof_fsync}
5212 root 21 0 48M 7280K uwait 0 0:00 0.00% redis-server{bio_lazy_free}
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
2020-04-24 10:14:48 +02:00
antirez
a76c67578c
Sentinel: small refactoring of sentinelCollectTerminatedScripts().
...
Related to #7113 .
2020-04-24 10:14:48 +02:00
omg-by
3a27064c41
fix(sentinel): sentinel.running_scripts will always increase more times and not reset
...
when trigger a always fail scripts, sentinel.running_scripts will increase ten times, however it
only decrease one times onretry the maximum. and it will't reset, when it become
SENTINEL_SCRIPT_MAX_RUNNING, sentinel don't trigger scripts.
2020-04-24 10:14:48 +02:00
antirez
5c4c73e2c2
A few comments and name changes for #7103 .
2020-04-17 13:02:40 +02:00
Oran Agra
6148f94939
testsuite run the defrag latency test solo
...
this test is time sensitive and it sometimes fail to pass below the
latency threshold, even on strong machines.
this test was the reson we're running just 2 parallel tests in the
github actions CI, revering this.
2020-04-17 13:02:40 +02:00
Jamie Scott
51d3012d48
Adding acllog-max-len to Redis.conf
...
While playing with ACLs I noticed that acllog-max-len wasn't in the redis.conf, but was a supported config.
This PR documents and adds the directive to the redis.conf file.
2020-04-17 13:02:40 +02:00
antirez
c39f16c422
Fix XCLAIM propagation in AOF/replicas for blocking XREADGROUP.
...
See issue #7105 .
2020-04-17 12:40:54 +02:00
antirez
7cf0a77d59
Redis 6.0-RC4.
2020-04-16 16:18:02 +02:00
antirez
9f594e2432
Update SDS to latest version.
2020-04-16 16:09:06 +02:00
antirez
48781dd95c
RESP3: fix HELLO map len in Sentinel mode.
...
See #6160 .
2020-04-16 11:22:18 +02:00
antirez
371ab0cff8
Don't allow empty spaces in ACL usernames.
...
Fixes issue #6418 .
2020-04-15 18:40:11 +02:00
antirez
b86140ac5f
Don't allow empty spaces in ACL key patterns.
...
Fixes issue #6418 .
2020-04-15 18:40:11 +02:00
liumiuyong
a7ee3c3e77
FIX: truncate max/min longitude,latitude related geo_point (ex: {180, 85.05112878} )
2020-04-15 16:03:16 +02:00
Guy Benoish
e5b9eb8171
Typo in getTimeoutFromObjectOrReply's error reply
2020-04-15 16:03:16 +02:00
antirez
0f31bb5c1a
Fix HELLO reply in Sentinel mode, see #6160 .
2020-04-15 16:03:16 +02:00
hwware
b92d9a895f
fix spelling in acl.c
2020-04-15 16:03:16 +02:00
antirez
8f896e57ae
Fix zsetAdd() top comment spelling.
2020-04-15 16:03:16 +02:00
hayleeliu
8f5157058b
fix spelling mistake in bitops.c
2020-04-15 16:03:16 +02:00
antirez
ddeda9ceb7
Fix function names in zslDeleteNode() top comment.
2020-04-15 16:03:16 +02:00
antirez
bde1f0a8e2
RESP3: change streams items from maps to arrays.
...
Streams items are similar to dictionaries, however they preserve both
the order, and allow for duplicated field names. So a map is not a
semantically sounding way to deal with this.
https://twitter.com/antirez/status/1248261087553880069
2020-04-15 16:03:16 +02:00
antirez
bec68bff29
Use the special static refcount for stack objects.
2020-04-15 16:03:16 +02:00
antirez
0f239e51b0
RDB: refactor some RDB loading code into dbAddRDBLoad().
2020-04-15 16:03:16 +02:00
antirez
f855db61b0
incrRefCount(): abort on statically allocated object.
2020-04-15 16:03:16 +02:00
antirez
23094ba015
More powerful DEBUG RELOAD.
...
Related to #3243 .
2020-04-15 16:03:16 +02:00
antirez
8161a7a3ef
RDB: clarify a condition in rdbLoadRio().
2020-04-15 16:03:16 +02:00
antirez
61b153073f
RDB: load files faster avoiding useless free+realloc.
...
Reloading of the RDB generated by
DEBUG POPULATE 5000000
SAVE
is now 25% faster.
This commit also prepares the ability to have more flexibility when
loading stuff from the RDB, since we no longer use dbAdd() but can
control exactly how things are added in the database.
2020-04-15 16:03:16 +02:00
antirez
414debfd04
Speedup: unblock clients on keys in O(1).
...
See #7071 .
2020-04-15 16:03:16 +02:00
antirez
cbcd07777d
Fix ACL HELP table missing comma.
2020-04-08 10:56:31 +02:00
mymilkbottles
2437455f27
Judge the log level in advance
2020-04-07 16:53:13 +02:00