zhaozhao.zz
660f01011c
LFU: do some changes about LFU to find hotkeys
...
Firstly, use access time to replace the decreas time of LFU.
For function LFUDecrAndReturn,
it should only try to get decremented counter,
not update LFU fields, we will update it in an explicit way.
And we will times halve the counter according to the times of
elapsed time than server.lfu_decay_time.
Everytime a key is accessed, we should update the LFU
including update access time, and increment the counter after
call function LFUDecrAndReturn.
If a key is overwritten, the LFU should be also updated.
Then we can use `OBJECT freq` command to get a key's frequence,
and LFUDecrAndReturn should be called in `OBJECT freq` command
in case of the key has not been accessed for a long time,
because we update the access time only when the key is read or
overwritten.
2017-11-27 18:39:22 +01:00
zhaozhao.zz
53cea97204
LFU: change lfu* parameters to int
2017-11-27 18:38:55 +01:00
zhaozhao.zz
aef50770ba
LFU: change lfu* parameters to int
2017-11-27 18:38:55 +01:00
zhaozhao.zz
dfc42ec447
LFU: fix the missing of config get and rewrite
2017-11-27 18:38:33 +01:00
zhaozhao.zz
44c2e4cdbf
LFU: fix the missing of config get and rewrite
2017-11-27 18:38:33 +01:00
antirez
75fa7879e6
Improve OBJECT HELP descriptions.
...
See #4472 .
2017-11-27 18:09:08 +01:00
antirez
d0a716f709
Improve OBJECT HELP descriptions.
...
See #4472 .
2017-11-27 18:09:08 +01:00
antirez
b412c544fd
Fix entry command table entry for OBJECT for HELP option.
...
After #4472 the command may have just 2 arguments.
2017-11-27 13:16:07 +01:00
antirez
af514a1155
Fix entry command table entry for OBJECT for HELP option.
...
After #4472 the command may have just 2 arguments.
2017-11-27 13:16:07 +01:00
Salvatore Sanfilippo
29252391c4
Merge pull request #4472 from itamarhaber/object_patch
...
A minor fix and `help` subcommand for `OBJECT`
2017-11-27 12:41:02 +01:00
Salvatore Sanfilippo
922fc6bf1d
Merge pull request #4472 from itamarhaber/object_patch
...
A minor fix and `help` subcommand for `OBJECT`
2017-11-27 12:41:02 +01:00
Itamar Haber
1c08220022
Adds -u <uri> option to redis-cli.
2017-11-27 11:34:11 +01:00
Itamar Haber
241526af3d
Adds -u <uri> option to redis-cli.
2017-11-27 11:34:11 +01:00
Itamar Haber
02d38f6b51
Adds OBJECT help
2017-11-24 19:59:05 +02:00
Itamar Haber
4a9fb02aca
Adds OBJECT help
2017-11-24 19:59:05 +02:00
Itamar Haber
b28fb3d753
Prevents OBJECT freq
with noeviction
...
When maxmemory is set to noeviction, idletime is implicitly kept. This renders access frequency nonsensical.
2017-11-24 19:58:37 +02:00
Itamar Haber
21479f9ebc
Prevents OBJECT freq
with noeviction
...
When maxmemory is set to noeviction, idletime is implicitly kept. This renders access frequency nonsensical.
2017-11-24 19:58:37 +02:00
antirez
dc2df135b3
Test: regression test for latency expire events logging bug.
...
Regression for #4452 .
2017-11-24 18:33:31 +01:00
antirez
f56b7aaef2
Test: regression test for latency expire events logging bug.
...
Regression for #4452 .
2017-11-24 18:33:31 +01:00
Salvatore Sanfilippo
c508cb6793
Merge pull request #4452 from soloestoy/expire-latency
...
expire & latency: fix the missing latency records generated by expire
2017-11-24 18:21:35 +01:00
Salvatore Sanfilippo
555a6ce980
Merge pull request #4452 from soloestoy/expire-latency
...
expire & latency: fix the missing latency records generated by expire
2017-11-24 18:21:35 +01:00
antirez
7229fa8d6d
Modules: fix memory leak in RM_IsModuleNameBusy().
2017-11-24 13:29:54 +01:00
antirez
63f2530a04
Modules: fix memory leak in RM_IsModuleNameBusy().
2017-11-24 13:29:54 +01:00
antirez
4d063bb6ba
PSYNC2: reorganize comments related to recent fixes.
...
Related to PR #4412 and issue #4407 .
2017-11-24 11:08:29 +01:00
antirez
97ca53e8ab
PSYNC2: reorganize comments related to recent fixes.
...
Related to PR #4412 and issue #4407 .
2017-11-24 11:08:29 +01:00
Salvatore Sanfilippo
9d86ae4597
Merge pull request #4412 from soloestoy/bugfix-psync2
...
PSYNC2: safe free backlog when reach the time limit and others
2017-11-24 10:56:18 +01:00
Salvatore Sanfilippo
0cd51d21b3
Merge pull request #4412 from soloestoy/bugfix-psync2
...
PSYNC2: safe free backlog when reach the time limit and others
2017-11-24 10:56:18 +01:00
Salvatore Sanfilippo
f739c27229
Merge pull request #4344 from soloestoy/fix-module-name-conflict
...
Fix module name conflict
2017-11-24 09:37:06 +01:00
Salvatore Sanfilippo
4394eedf5e
Merge pull request #4344 from soloestoy/fix-module-name-conflict
...
Fix module name conflict
2017-11-24 09:37:06 +01:00
Salvatore Sanfilippo
58ac57f665
Merge pull request #4470 from oranagra/fix_string_to_double
...
fix string to double conversion, stopped parsing on \0 …
2017-11-24 08:59:23 +01:00
Salvatore Sanfilippo
b6b3811914
Merge pull request #4470 from oranagra/fix_string_to_double
...
fix string to double conversion, stopped parsing on \0 …
2017-11-24 08:59:23 +01:00
Oran Agra
adf2701cc9
fix string to double conversion, stopped parsing on \0 even if the string has more data.
...
getLongLongFromObject calls string2ll which has this line:
/* Return if not all bytes were used. */
so if you pass an sds with 3 characters "1\01" it will fail.
but getLongDoubleFromObject calls strtold, and considers it ok if eptr[0]==`\0`
i.e. if the end of the string found by strtold ends with null terminator
127.0.0.1:6379> set a 1
OK
127.0.0.1:6379> setrange a 2 2
(integer) 3
127.0.0.1:6379> get a
"1\x002"
127.0.0.1:6379> incrbyfloat a 2
"3"
127.0.0.1:6379> get a
"3"
2017-11-23 17:15:27 +02:00
Oran Agra
07e0f0f72f
fix string to double conversion, stopped parsing on \0 even if the string has more data.
...
getLongLongFromObject calls string2ll which has this line:
/* Return if not all bytes were used. */
so if you pass an sds with 3 characters "1\01" it will fail.
but getLongDoubleFromObject calls strtold, and considers it ok if eptr[0]==`\0`
i.e. if the end of the string found by strtold ends with null terminator
127.0.0.1:6379> set a 1
OK
127.0.0.1:6379> setrange a 2 2
(integer) 3
127.0.0.1:6379> get a
"1\x002"
127.0.0.1:6379> incrbyfloat a 2
"3"
127.0.0.1:6379> get a
"3"
2017-11-23 17:15:27 +02:00
antirez
de914ede93
Modules: fix for scripting replication of modules commands.
...
See issue #4466 / #4467 .
2017-11-23 15:14:17 +01:00
antirez
cff7b04fdc
Modules: fix for scripting replication of modules commands.
...
See issue #4466 / #4467 .
2017-11-23 15:14:17 +01:00
Salvatore Sanfilippo
ada206559d
Merge pull request #4467 from yossigo/fix-nested-multi
...
Nested MULTI/EXEC may replicate in different cases.
2017-11-23 13:38:43 +01:00
Salvatore Sanfilippo
bf2b03202f
Merge pull request #4467 from yossigo/fix-nested-multi
...
Nested MULTI/EXEC may replicate in different cases.
2017-11-23 13:38:43 +01:00
Yossi Gottlieb
2c70d28295
Nested MULTI/EXEC may replicate in different cases.
...
For example:
1. A module command called within a MULTI section.
2. A Lua script with replicate_commands() called within a MULTI section.
3. A module command called from a Lua script in the above context.
2017-11-22 22:02:51 +02:00
Yossi Gottlieb
3246b95129
Nested MULTI/EXEC may replicate in different cases.
...
For example:
1. A module command called within a MULTI section.
2. A Lua script with replicate_commands() called within a MULTI section.
3. A module command called from a Lua script in the above context.
2017-11-22 22:02:51 +02:00
zhaozhao.zz
ea2e51c630
PSYNC2: persist cached_master's dbid inside the RDB
2017-11-22 12:11:26 +08:00
zhaozhao.zz
308fa486ed
PSYNC2: persist cached_master's dbid inside the RDB
2017-11-22 12:11:26 +08:00
zhaozhao.zz
93037f7642
PSYNC2: make repl_stream_db never be -1
...
it means that after this change all the replication
info in RDB is valid, and it can distinguish us from
the older version.
2017-11-22 12:05:34 +08:00
zhaozhao.zz
7f0a2494ca
PSYNC2: make repl_stream_db never be -1
...
it means that after this change all the replication
info in RDB is valid, and it can distinguish us from
the older version.
2017-11-22 12:05:34 +08:00
zhaozhao.zz
7a808fd8a7
expire & latency: fix the missing latency records generated by expire
2017-11-21 23:35:30 +08:00
zhaozhao.zz
91922131ce
expire & latency: fix the missing latency records generated by expire
2017-11-21 23:35:30 +08:00
zhaozhao.zz
57bd8feb8d
rehash: handle one db until finished
2017-11-21 09:49:42 +01:00
zhaozhao.zz
32a1a4da1e
rehash: handle one db until finished
2017-11-21 09:49:42 +01:00
David Carlier
62689ef0cf
Fix undefined behavior constant defined.
2017-11-19 16:23:42 +00:00
David Carlier
7d9209e38b
Fix undefined behavior constant defined.
2017-11-19 16:23:42 +00:00
Salvatore Sanfilippo
cf9a3f7048
Merge pull request #2741 from kmiku7/unstable
...
fix boundary case for _dictNextPower
2017-11-08 17:06:09 +01:00