gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
9,193 Commits 1 Branch 0 Tags
Commit Graph

9193 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Salvatore Sanfilippo
086f25d1a8 Merge pull request #6849 from oranagra/free_client_mutex 
freeClientAsync don't lock mutex if there's just one thread
 2020-02-06 10:29:46 +01:00
Salvatore Sanfilippo
965cc6b607 Merge pull request #6850 from oranagra/restart_aof_unset_master 
move restartAOFAfterSYNC from replicaofCommand to replicationUnsetMaster
 2020-02-06 10:27:05 +01:00
Salvatore Sanfilippo
6a677cc2fa Merge pull request #6851 from oranagra/aof_rewrite_scheduled 
stopAppendOnly resets aof_rewrite_scheduled
 2020-02-06 10:23:11 +01:00
Salvatore Sanfilippo
b8a57dc76e Merge pull request #6852 from oranagra/acl_help 
add SAVE subcommand to ACL HELP and top comment
 2020-02-06 10:22:16 +01:00
Salvatore Sanfilippo
fd94ed0819 Merge pull request #6853 from oranagra/debug_help 
DEBUG HELP - add PROTOCOL
 2020-02-06 10:21:55 +01:00
Salvatore Sanfilippo
df9ca7d05a Merge pull request #6854 from guybe7/mem_overhead_miscalc 
Fix small bugs related to replica and monitor ambiguity
 2020-02-06 10:21:30 +01:00
Guy Benoish
2b10c2ce47 Some refactroing using getClientType instead of CLIENT_SLAVE 2020-02-06 14:12:08 +05:30
Oran Agra
bc705b1b26 DEBUG HELP - add PROTOCOL 2020-02-06 10:40:29 +02:00
Guy Benoish
818b77193b Fix small bugs related to replica and monitor ambiguity 
1. server.repl_no_slaves_since can be set when a MONITOR client disconnects
2. c->repl_ack_time can be set by a newline from a MONITOR client
3. Improved comments
 2020-02-06 14:10:02 +05:30
Oran Agra
7e53f26984 add SAVE subcommand to ACL HELP and top comment 2020-02-06 10:31:43 +02:00
Oran Agra
a772eb89cc stopAppendOnly resets aof_rewrite_scheduled 
althouh in theory, users can do BGREWRITEAOF even if aof is disabled, i
suppose it is more common that the scheduled flag is set by either
startAppendOnly, of a failed initial AOFRW fork (AOF_WAIT_REWRITE)
 2020-02-06 10:17:34 +02:00
Oran Agra
3a74aa3ebe move restartAOFAfterSYNC from replicaofCommand to replicationUnsetMaster 
replicationUnsetMaster can be called from other places, not just
replicaofCOmmand, and all of these need to restart AOF
 2020-02-06 10:14:32 +02:00
Oran Agra
df866ad322 freeClientAsync don't lock mutex if there's just one thread 2020-02-06 10:07:17 +02:00
Oran Agra
3ea0716cad reduce repeated calls to use_diskless_load 
this function possibly iterates on the module list
 2020-02-06 09:41:45 +02:00
Oran Agra
01eadbd6e1 moduleRDBLoadError, add key name, and use panic rather than exit 
using panic rather than exit means you get s stack trace of the code
path that experianced the error, and possibly other info.
 2020-02-06 09:37:04 +02:00
Oran Agra
4050c57139 Fix client flags to be int64 in module.c 
currently there's no bug since the flags these functions handle are
always lower than 32bit, but still better fix the type to prevent future
bugs.
 2020-02-06 09:33:20 +02:00
Oran Agra
e41c1824d6 fix maxmemory config warning 
the warning condition was if usage > limit (saying it'll cause eviction
or oom), but in fact the eviction and oom depends on used minus slave
buffers.

other than fixing the condition, i add info about the current usage and
limit, which may be useful when looking at the log.
 2020-02-06 09:23:22 +02:00
Oran Agra
f7bb301644 Memory leak when bind config is provided twice 2020-02-06 09:17:39 +02:00
Oran Agra
ddc1845286 A few non-data commands that should be allowed while loading or stale 
SELECT, and HELLO are commands that may be executed by the client
as soon as it connects, there's no reason to block them, preventing the
client from doing the rest of his sequence (which might just be INFO or
CONFIG, etc).

MONITOR, DEBUG, SLOWLOG, TIME, LASTSAVE are all non-data accessing
commands, which there's no reason to block.
 2020-02-06 08:53:23 +02:00
Yossi Gottlieb
bc5e0a456b TLS: Update documentation. 2020-02-05 21:19:03 +02:00
Oran Agra
467090e45f Add handling of short read of module id in rdb 2020-02-05 19:47:09 +02:00
Salvatore Sanfilippo
9d016c0084 Merge pull request #6839 from yossigo/fix/redis-conf-tls-clarifications 
TLS: Some redis.conf clarifications.
 2020-02-05 17:33:21 +01:00
Yossi Gottlieb
f4c7f1ac27 TLS: Some redis.conf clarifications. 2020-02-05 18:30:12 +02:00
Oran Agra
13a7379024 update RM_SignalModifiedKey doc comment 2020-02-05 18:15:38 +02:00
Oran Agra
7d12ef55ca Optimize temporary memory allocations for getKeysFromCommand mechanism 
now that we may use it more often (ACL), these excessive calls to malloc
and free can become an overhead.
 2020-02-05 18:06:33 +02:00
Salvatore Sanfilippo
ec92713d1e Merge pull request #6831 from oranagra/config_c_refactor_3 
config.c verbose error replies for CONFIG SET, like config file parsing
 2020-02-05 13:41:15 +01:00
Salvatore Sanfilippo
823d8e6a8b Merge pull request #6829 from oranagra/memory_get_keys 
memoryGetKeys helper function so that ACL can limit access to keys for MEMORY command
 2020-02-05 13:33:18 +01:00
Oran Agra
097a0a52d6 config.c verbose error replies for CONFIG SET, like config file parsing 
We noticed that the error replies for the generic mechanism for enums
are very verbose for config file parsing, but not for config set
command.

instead of replicating this code, i did a small refactoring to share
code between CONFIG SET and config file parsing.

and also renamed the enum group functions to be consistent with the
naming of other types.
 2020-02-05 11:41:24 +02:00
Oran Agra
f7067d371b memoryGetKeys helper function so that ACL can limit access to keys for MEMORY command 2020-02-05 09:42:49 +02:00
Guy Benoish
a0d45826a3 Add RM_CreateStringFromDouble 2020-02-04 19:28:09 +05:30
antirez
f1518f63b1 ACL LOG: make max log entries configurable. 2020-02-04 13:19:40 +01:00
antirez
da054f14f0 ACL LOG: test for AUTH reason. 2020-02-04 12:58:48 +01:00
antirez
debc5d4ef9 ACL LOG: log failed auth attempts. 2020-02-04 12:55:26 +01:00
lifubang
54199c93be fix ssl flag check for redis-cli 
Signed-off-by: lifubang <lifubang@acmcoder.com>
 2020-02-04 17:32:30 +08:00
Salvatore Sanfilippo
32e2e7770a Merge pull request #6818 from leomurillo/zskiplistLevels 
Set ZSKIPLIST_MAXLEVEL to 32
 2020-02-04 10:20:56 +01:00
Salvatore Sanfilippo
2659773a0b Merge pull request #6825 from trevor211/fixMemoryLeakAboutLuaScript 
Fix memory leak about lua script
 2020-02-04 10:19:16 +01:00
WuYunlong
85bc26f8da Fix lua related memory leak. 2020-02-04 16:38:46 +08:00
WuYunlong
c0c29adce9 Add tcl regression test in scripting.tcl to reproduce memory leak. 2020-02-04 16:34:11 +08:00
Salvatore Sanfilippo
a0781a2ce8 Merge pull request #6808 from yossigo/fix/redis-cli-openssl-1.0.x 
TLS: Fix missing initialization in redis-cli.
 2020-02-03 16:43:56 +01:00
Salvatore Sanfilippo
bac311851e Merge pull request #6824 from oranagra/fix_module_c_uninit_var 
fix uninitialized info_cb var in module.c
 2020-02-03 15:46:13 +01:00
Oran Agra
f5d37082ca fix uninitialized info_cb var in module.c 2020-02-03 16:35:39 +02:00
Guy Benoish
2492bdc90b Exclude "keymiss" notification from NOTIFY_ALL 
Because "keymiss" is "special" compared to the rest of
the notifications (Trying not to break existing apps
using the 'A' format for notifications)

Also updated redis.conf and module.c docs
 2020-02-03 15:43:44 +05:30
Leo Murillo
0ab1604c0c Set ZSKIPLIST_MAXLEVEL to optimal value given 2^64 elements and p=0.25 2020-02-02 02:48:00 -06:00
Salvatore Sanfilippo
541a667c77 Merge pull request #6812 from guybe7/str_convert_fix 
ld2string should fail if string contains \0 in the middle
 2020-01-30 17:51:04 +01:00
Guy Benoish
add0229c31 DEBUG OBJECT should pass keyname to module when loading 2020-01-30 19:15:12 +05:30
Guy Benoish
3fd717daee ld2string should fail if string contains \0 in the middle 
This bug affected RM_StringToLongDouble and HINCRBYFLOAT.
I added tests for both cases.

Main changes:
1. Fixed string2ld to fail if string contains \0 in the middle
2. Use string2ld in getLongDoubleFromObject - No point of
   having duplicated code here

The two changes above broke RM_SaveLongDouble/RM_LoadLongDouble
because the long double string was saved with length+1 (An innocent
mistake, but it's actually a bug - The length passed to
RM_SaveLongDouble should not include the last \0).
 2020-01-30 18:15:17 +05:30
antirez
8185f2b6ce ACL LOG: implement a few basic tests. 2020-01-30 11:14:13 +01:00
antirez
bc168c91ec ACL LOG: also log ACL errors in the scripting/MULTI ctx. 2020-01-30 10:50:32 +01:00
Yossi Gottlieb
a7420b2478 TLS: Fix missing initialization in redis-cli. 2020-01-29 21:40:02 +02:00
antirez
eef1489240 ACL LOG: implement LOG RESET. 2020-01-29 18:51:04 +01:00