sundb
1f12be3072
Fix random probability check in ziplistRandomPairsUnique ( #8467 )
...
When (remaining == (total_size - index)), element will definitely be random to.
But when rand() == RAND_MAX, the element will miss, this will trigger assert
in serverAssert(ziplistRandomPairsUnique(zsetobj->ptr, count, keys, vals) == count).
2021-02-08 12:41:16 +02:00
Andy Pan
be48f04807
Fix typos in comments ( #8466 )
2021-02-08 12:09:39 +02:00
Andy Pan
88272cf7ac
Fix typos in comments ( #8466 )
2021-02-08 12:09:39 +02:00
John Sully
4efab08466
Fix bug in fastlock stack metadata
...
Former-commit-id: 241d1bd7e1ed64885adbb07653a5c7e8ef882607
2021-02-07 19:11:05 -05:00
John Sully
bb733b0aab
Fix bug in fastlock stack metadata
...
Former-commit-id: 241d1bd7e1ed64885adbb07653a5c7e8ef882607
2021-02-07 19:11:05 -05:00
John Sully
662fc28fdc
Disable multithreaded rehash when active defrag is enabled. The two are not compatible
...
Former-commit-id: 56addcd17262ffbaefea26c0097cde53c616ece2
2021-02-07 19:11:05 -05:00
John Sully
7d588e637a
Disable multithreaded rehash when active defrag is enabled. The two are not compatible
...
Former-commit-id: 56addcd17262ffbaefea26c0097cde53c616ece2
2021-02-07 19:11:05 -05:00
John Sully
1b3dc3d422
The server should recalibrate periodically. Also reduce log noise
...
Former-commit-id: 8d8e1810d49da6aa921d2327cb4ea250c2b5b234
2021-02-07 19:11:05 -05:00
John Sully
3970f4a5a7
The server should recalibrate periodically. Also reduce log noise
...
Former-commit-id: 8d8e1810d49da6aa921d2327cb4ea250c2b5b234
2021-02-07 19:11:05 -05:00
John Sully
27552cb307
Ensure the C lock implementation behaves the same as the ASM
...
Former-commit-id: b5ddc11c46d2eabd28fae4c69927c356dd18bf6e
2021-02-07 19:11:05 -05:00
John Sully
8ce03686ed
Ensure the C lock implementation behaves the same as the ASM
...
Former-commit-id: b5ddc11c46d2eabd28fae4c69927c356dd18bf6e
2021-02-07 19:11:05 -05:00
John Sully
ba006abe02
Ensure rehash completes even when we're in a long running task
...
Former-commit-id: f107746e90f7a8ff3c7094145ee1ad438911e8c2
2021-02-07 19:11:05 -05:00
John Sully
7c700f1987
Ensure rehash completes even when we're in a long running task
...
Former-commit-id: f107746e90f7a8ff3c7094145ee1ad438911e8c2
2021-02-07 19:11:05 -05:00
John Sully
495dff1e8c
Implement rehash during spinlock
...
Former-commit-id: f68a26381a35b27948046d46c2c7bcfbdc21143d
2021-02-07 19:11:05 -05:00
John Sully
bef72e5f6a
Implement rehash during spinlock
...
Former-commit-id: f68a26381a35b27948046d46c2c7bcfbdc21143d
2021-02-07 19:11:05 -05:00
John Sully
071ecb801a
Allow multiple threads to rehash simultaneously
...
Former-commit-id: 5a2cc90786dfd1bfd341dbf5713bcde01f0cfff3
2021-02-07 19:11:05 -05:00
John Sully
5ab1095022
Allow multiple threads to rehash simultaneously
...
Former-commit-id: 5a2cc90786dfd1bfd341dbf5713bcde01f0cfff3
2021-02-07 19:11:05 -05:00
John Sully
6379ae6c7f
Fix races in free
...
Former-commit-id: 3881d5c1f22f022855c0abcf7b0c2070e204c0a3
2021-02-07 19:11:05 -05:00
John Sully
5d161ca2f2
Fix races in free
...
Former-commit-id: 3881d5c1f22f022855c0abcf7b0c2070e204c0a3
2021-02-07 19:11:05 -05:00
John Sully
1c0b603def
Initial implementation
...
Former-commit-id: 958f2c00c8efc15dc91fdeec2ff2e2ae2016c124
2021-02-07 19:11:05 -05:00
John Sully
c6c1084dd8
Initial implementation
...
Former-commit-id: 958f2c00c8efc15dc91fdeec2ff2e2ae2016c124
2021-02-07 19:11:05 -05:00
John Sully
5c884b6fd8
Merge branch 'keydbpro' into PRO_RELEASE_6
...
Former-commit-id: 4a269c3382083f6ad7f697ef07eebc552e0de9d8
2021-02-08 00:02:54 +00:00
John Sully
a997b2d5ad
Merge branch 'keydbpro' into PRO_RELEASE_6
...
Former-commit-id: 4a269c3382083f6ad7f697ef07eebc552e0de9d8
2021-02-08 00:02:54 +00:00
John Sully
f4c7da7284
Merge branch 'unstable' into RELEASE_6
...
Former-commit-id: 0b7b5332f2a3bb5a6f4310643c343f53f546bd81
2021-02-07 23:55:58 +00:00
John Sully
2da3216228
Merge branch 'unstable' into RELEASE_6
...
Former-commit-id: 0b7b5332f2a3bb5a6f4310643c343f53f546bd81
2021-02-07 23:55:58 +00:00
John Sully
aa47e643b0
Fix memory leak in mvccRestore
...
Former-commit-id: 165333b0fc648c79e66f04d9c8c4a1d0059fe57a
2021-02-07 23:38:49 +00:00
John Sully
e55ca3603c
Fix memory leak in mvccRestore
...
Former-commit-id: 165333b0fc648c79e66f04d9c8c4a1d0059fe57a
2021-02-07 23:38:49 +00:00
John Sully
e2f634aef5
Fix cluster test failure
...
Former-commit-id: 230fde39882766426d892fd30d0c8349f5cca912
2021-02-07 23:38:25 +00:00
John Sully
4c9f912c3b
Fix cluster test failure
...
Former-commit-id: 230fde39882766426d892fd30d0c8349f5cca912
2021-02-07 23:38:25 +00:00
John Sully
6a7b193fc1
Fix memory leak in mvccRestore
...
Former-commit-id: 92da1cbd0a08b66264f170a9b57ef7270f270157
2021-02-07 23:38:09 +00:00
John Sully
ea74c705a6
Fix memory leak in mvccRestore
...
Former-commit-id: 92da1cbd0a08b66264f170a9b57ef7270f270157
2021-02-07 23:38:09 +00:00
John Sully
52c1d17127
Update test to handle forkless bgsave
...
Former-commit-id: fc8c6de8252e6b802688413050f1a823093d0a1d
2021-02-07 21:41:19 +00:00
John Sully
483b43156e
Update test to handle forkless bgsave
...
Former-commit-id: fc8c6de8252e6b802688413050f1a823093d0a1d
2021-02-07 21:41:19 +00:00
John Sully
b20ab1fd21
Merge branch 'keydbpro' of https://gitlab.eqalpha.com/keydb-dev/KeyDB-Pro into keydbpro
...
Former-commit-id: 8bad923169b2a73f249fd8b3153236d6a74100c9
2021-02-07 20:53:07 +00:00
John Sully
886fcf6387
Merge branch 'keydbpro' of https://gitlab.eqalpha.com/keydb-dev/KeyDB-Pro into keydbpro
...
Former-commit-id: 8bad923169b2a73f249fd8b3153236d6a74100c9
2021-02-07 20:53:07 +00:00
jsully
1c0c0ebd3f
Merge branch 'opensourcemerge_2021-02-01' into 'keydbpro'
...
Merge from open source Feb 5 2021
See merge request keydb-dev/KeyDB-Pro!9
Former-commit-id: 1a2e2b99cc0123b1b03b78b5f28107df395decdb
2021-02-07 20:49:08 +00:00
jsully
ab45347ed6
Merge branch 'opensourcemerge_2021-02-01' into 'keydbpro'
...
Merge from open source Feb 5 2021
See merge request keydb-dev/KeyDB-Pro!9
Former-commit-id: 1a2e2b99cc0123b1b03b78b5f28107df395decdb
2021-02-07 20:49:08 +00:00
Oran Agra
11fe272c1a
Optimize HRANDFIELD and ZRANDMEMBER case 4 when ziplist encoded ( #8444 )
...
It is inefficient to repeatedly pick a single random element from a
ziplist.
For CASE4, which is when the user requested a low number of unique
random picks from the collectoin, we used thta pattern.
Now we use a different algorithm that picks unique elements from a
ziplist, and guarentee no duplicate but doesn't provide random order
(which is only needed in the non-unique random picks case)
Unrelated changes:
* change ziplist count and indexes variables to unsigned
* solve compilation warnings about uninitialized vars in gcc 10.2
Co-authored-by: xinluton <xinluton@qq.com>
2021-02-07 16:55:11 +02:00
Oran Agra
62b1f32062
Optimize HRANDFIELD and ZRANDMEMBER case 4 when ziplist encoded ( #8444 )
...
It is inefficient to repeatedly pick a single random element from a
ziplist.
For CASE4, which is when the user requested a low number of unique
random picks from the collectoin, we used thta pattern.
Now we use a different algorithm that picks unique elements from a
ziplist, and guarentee no duplicate but doesn't provide random order
(which is only needed in the non-unique random picks case)
Unrelated changes:
* change ziplist count and indexes variables to unsigned
* solve compilation warnings about uninitialized vars in gcc 10.2
Co-authored-by: xinluton <xinluton@qq.com>
2021-02-07 16:55:11 +02:00
Oran Agra
8bfac022f8
solve race in replication-2 test ( #8461 )
...
use SIGSTOP instead of DEBUG SLEEP, reduces the test
time by some 2 seconds and avoids failures on slow machines
2021-02-07 16:22:30 +02:00
Oran Agra
02ab14cc2e
solve race in replication-2 test ( #8461 )
...
use SIGSTOP instead of DEBUG SLEEP, reduces the test
time by some 2 seconds and avoids failures on slow machines
2021-02-07 16:22:30 +02:00
Oran Agra
cd99db31f1
Update CI on Ubuntu to tcl8.6 (since 20.04 is now used) ( #8460 )
...
Github started shifting some repositoreis to use ubuntu 20.04 by default
tcl8.5 is missing in these, but 8.6 exists in both 20.04 and 18.04
2021-02-07 15:41:49 +02:00
Oran Agra
018f7b7378
Update CI on Ubuntu to tcl8.6 (since 20.04 is now used) ( #8460 )
...
Github started shifting some repositoreis to use ubuntu 20.04 by default
tcl8.5 is missing in these, but 8.6 exists in both 20.04 and 18.04
2021-02-07 15:41:49 +02:00
Yossi Gottlieb
b07ddb2c04
Add --dump-logs tests option. ( #8459 )
...
Dump the entire server log if a test failed, to easy troubleshooting
with no access to log files.
2021-02-07 12:37:24 +02:00
Yossi Gottlieb
5b8350aaaa
Add --dump-logs tests option. ( #8459 )
...
Dump the entire server log if a test failed, to easy troubleshooting
with no access to log files.
2021-02-07 12:37:24 +02:00
Yossi Gottlieb
830c207254
Add --insecure option to command line tools. ( #8416 )
...
Disable certificate validation, making it possible to connect to servers
without configuring full trust chain.
The use of this option is insecure and makes the connection vulnerable
to man in the middle attacks.
2021-02-07 12:36:56 +02:00
Yossi Gottlieb
be83bb13a8
Add --insecure option to command line tools. ( #8416 )
...
Disable certificate validation, making it possible to connect to servers
without configuring full trust chain.
The use of this option is insecure and makes the connection vulnerable
to man in the middle attacks.
2021-02-07 12:36:56 +02:00
Viktor Söderqvist
64737ea8f1
RM_ZsetRem: Delete key if empty ( #8453 )
...
Without this fix, RM_ZsetRem can leave empty sorted sets which are
not allowed to exist.
Removing from a sorted set while iterating seems to work (while
inserting causes failed assetions). RM_ZsetRangeEndReached is
modified to return 1 if the key doesn't exist, to terminate
iteration when the last element has been removed.
2021-02-05 19:54:01 +02:00
Viktor Söderqvist
aea6e71ef8
RM_ZsetRem: Delete key if empty ( #8453 )
...
Without this fix, RM_ZsetRem can leave empty sorted sets which are
not allowed to exist.
Removing from a sorted set while iterating seems to work (while
inserting causes failed assetions). RM_ZsetRangeEndReached is
modified to return 1 if the key doesn't exist, to terminate
iteration when the last element has been removed.
2021-02-05 19:54:01 +02:00
filipe oliveira
d627014049
Fix compiler warning on implicit declaration of ‘nanosleep’ . Removed unused variable ( #8454 )
2021-02-05 19:51:31 +02:00