Merge pull request #6864 from guybe7/fix_memleak_in_test_ld_conv

Fix memory leak in test_ld_conv
This commit is contained in:
Salvatore Sanfilippo 2020-02-20 13:08:31 +01:00 committed by GitHub
commit fd922f4c28

View File

@ -74,6 +74,7 @@ int test_ld_conv(RedisModuleCtx *ctx, RedisModuleString **argv, int argc) {
RedisModule_ReplyWithError(ctx, err); RedisModule_ReplyWithError(ctx, err);
goto final; goto final;
} }
/* Make sure we can't convert a string that has \0 in it */ /* Make sure we can't convert a string that has \0 in it */
char buf[4] = "123"; char buf[4] = "123";
buf[1] = '\0'; buf[1] = '\0';
@ -81,8 +82,11 @@ int test_ld_conv(RedisModuleCtx *ctx, RedisModuleString **argv, int argc) {
long double ld3; long double ld3;
if (RedisModule_StringToLongDouble(s3, &ld3) == REDISMODULE_OK) { if (RedisModule_StringToLongDouble(s3, &ld3) == REDISMODULE_OK) {
RedisModule_ReplyWithError(ctx, "Invalid string successfully converted to long double"); RedisModule_ReplyWithError(ctx, "Invalid string successfully converted to long double");
RedisModule_FreeString(ctx, s3);
goto final; goto final;
} }
RedisModule_FreeString(ctx, s3);
RedisModule_ReplyWithLongDouble(ctx, ld2); RedisModule_ReplyWithLongDouble(ctx, ld2);
final: final:
RedisModule_FreeString(ctx, s1); RedisModule_FreeString(ctx, s1);