gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

solve valgrind warning in child_info (#8505)

Browse Source 
Valgrind warns about `write` accessing uninitialized memory, which was the struct padding.
This commit is contained in:
Oran Agra 2021-02-17 12:30:29 +02:00 committed by GitHub
parent ae4d2fe1b3
commit f6d1af1c07
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/childinfo.c
View File

@ -69,10 +69,11 @@ void closeChildInfoPipe(void) {
void sendChildInfoGeneric(childInfoType info_type, size_t keys, double progress, char *pname) { void sendChildInfoGeneric(childInfoType info_type, size_t keys, double progress, char *pname) {
if (server.child_info_pipe[1] == -1) return; if (server.child_info_pipe[1] == -1) return;
child_info_data data = {.information_type=info_type, child_info_data data = {0}; /* zero everything, including padding to sattisfy valgrind */
.keys=keys, data.information_type = info_type;
.cow=zmalloc_get_private_dirty(-1), data.keys = keys;
.progress=progress}; data.cow = zmalloc_get_private_dirty(-1);
data.progress = progress;
if (data.cow) { if (data.cow) {
serverLog((info_type == CHILD_INFO_TYPE_CURRENT_INFO) ? LL_VERBOSE : LL_NOTICE, serverLog((info_type == CHILD_INFO_TYPE_CURRENT_INFO) ? LL_VERBOSE : LL_NOTICE,