gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Tests: fix the problem that Darwin memory leak detection may fail (#8213)

Browse Source 
Apparently the "leaks" took reports a different error string about process
that's not found in each version of MacOS.
This cause the test suite to fail on some OS versions, since some tests terminate
the process before looking for leaks.
Instead of looking at the error string, we now look at the (documented) exit code.
This commit is contained in:
Yang Bodong 2020-12-23 22:28:17 +08:00 committed by GitHub
parent 266949c7fc
commit ee59dc1b5c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tests/support/server.tcl
View File

@ -50,11 +50,17 @@ proc kill_server config {
tags {"leaks"} { tags {"leaks"} {
test "Check for memory leaks (pid $pid)" { test "Check for memory leaks (pid $pid)" {
set output {0 leaks} set output {0 leaks}
catch {exec leaks $pid} output catch {exec leaks $pid} output option
if {[string match {*process does not exist*} $output] || # In a few tests we kill the server process, so leaks will not find it.
[string match {*cannot examine*} $output]} { # It'll exits with exit code >1 on error, so we ignore these.
# In a few tests we kill the server process. if {[dict exists $option -errorcode]} {
set output "0 leaks" set details [dict get $option -errorcode]
if {[lindex $details 0] eq "CHILDSTATUS"} {
set status [lindex $details 2]
if {$status > 1} {
set output "0 leaks"
}
}
} }
set output set output
} {*0 leaks*} } {*0 leaks*}