gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

remove min field

Browse Source 
Signed-off-by: Binbin <binloveplay1314@qq.com>
This commit is contained in:
Binbin 2025-02-01 21:54:02 +08:00
parent 2df98bebcc
commit eac30eb301
3 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/latency.c
View File

@ -86,7 +86,6 @@ void latencyAddSample(const char *event, mstime_t latency) {
ts = zmalloc(sizeof(*ts));
ts->idx = 0;
ts->max = 0;
ts->min = 0;
ts->sum = 0;
ts->cnt = 0;
memset(ts->samples, 0, sizeof(ts->samples));
@ -94,7 +93,6 @@ void latencyAddSample(const char *event, mstime_t latency) {
}
if (latency > ts->max) ts->max = latency;
if (latency < ts->min || ts->min == 0) ts->min = latency;
ts->sum += latency;
ts->cnt++;
@ -618,12 +616,11 @@ void latencyCommandReplyWithLatestEvents(client *c) {
struct latencyTimeSeries *ts = dictGetVal(de);
int last = (ts->idx + LATENCY_TS_LEN - 1) % LATENCY_TS_LEN;
addReplyArrayLen(c, 7);
addReplyArrayLen(c, 6);
addReplyBulkCString(c, event);
addReplyLongLong(c, ts->samples[last].time);
addReplyLongLong(c, ts->samples[last].latency);
addReplyLongLong(c, ts->max);
addReplyLongLong(c, ts->min);
addReplyLongLong(c, ts->sum);
addReplyLongLong(c, ts->cnt);
}

1
src/latency.h
View File

@ -47,7 +47,6 @@ struct latencySample {
struct latencyTimeSeries {
int idx; /* Index of the next sample to store. */
uint32_t max; /* Max latency observed for this event. */
uint32_t min; /* Min latency observed for this event. */
uint32_t sum; /* Sum latency observed for this event. */
uint32_t cnt; /* Count observed for this event. */
struct latencySample samples[LATENCY_TS_LEN]; /* Latest history. */

3
tests/unit/latency-monitor.tcl
View File

@ -115,14 +115,13 @@ tags {"needs:debug"} {
# See the previous "Test latency events logging" test for each call.
foreach event $res {
lassign $event eventname time latency max min sum cnt
lassign $event eventname time latency max sum cnt
assert {$eventname eq "command"}
if {!$::no_latency} {
# To avoid timing issues, each event decreases by 50 and
# increases by 150 to increase the range.
assert_equal $time $last_time
assert_range $max 450 650 ;# debug sleep 0.5
assert_range $min 250 450 ;# debug sleep 0.3
assert_range $sum 1050 1650 ;# debug sleep 0.3 + 0.4 + 0.5
assert_equal $cnt 3
}