gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Streams: generate a few additional events.

Browse Source 
Currently it does not look it's sensible to generate events for streams
consumer groups modification, being them metadata, however at least for
key-level events, like the creation or removal of a consumer group, I
added a few events here and there. Later we can evaluate if it makes
sense to add more. From the POV instead of WAIT (in Redis transaciton)
and signaling the key as modified, it looks like that the transaction
should not fail when a stream is modified, so no calls are made in
consumer groups related functions to signalModifiedKey().
This commit is contained in:
antirez 2018-06-12 18:10:41 +02:00
parent 49ede33ee8
commit e9685766d7
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/t_stream.c
View File

@ -1379,7 +1379,7 @@ void xreadCommand(client *c) {
/* Emit the two elements sub-array consisting of the name /* Emit the two elements sub-array consisting of the name
* of the stream and the data we extracted from it. */ * of the stream and the data we extracted from it. */
addReplyMultiBulkLen(c,2); addReplyMultiBulkLen(c,2);
addReplyBulk(c,c->argv[i+streams_arg]); addReplyBulk(c,c->argv[streams_arg+i]);
streamConsumer *consumer = NULL; streamConsumer *consumer = NULL;
if (groups) consumer = streamLookupConsumer(groups[i], if (groups) consumer = streamLookupConsumer(groups[i],
consumername->ptr,1); consumername->ptr,1);
@ -1606,6 +1606,8 @@ NULL
if (cg) { if (cg) {
addReply(c,shared.ok); addReply(c,shared.ok);
server.dirty++; server.dirty++;
notifyKeyspaceEvent(NOTIFY_STREAM,"xgroup-create",
c->argv[2],c->db->id);
} else { } else {
addReplySds(c, addReplySds(c,
sdsnew("-BUSYGROUP Consumer Group name already exists\r\n")); sdsnew("-BUSYGROUP Consumer Group name already exists\r\n"));
@ -1620,12 +1622,15 @@ NULL
cg->last_id = id; cg->last_id = id;
addReply(c,shared.ok); addReply(c,shared.ok);
server.dirty++; server.dirty++;
notifyKeyspaceEvent(NOTIFY_STREAM,"xgroup-setid",c->argv[2],c->db->id);
} else if (!strcasecmp(opt,"DESTROY") && c->argc == 4) { } else if (!strcasecmp(opt,"DESTROY") && c->argc == 4) {
if (cg) { if (cg) {
raxRemove(s->cgroups,(unsigned char*)grpname,sdslen(grpname),NULL); raxRemove(s->cgroups,(unsigned char*)grpname,sdslen(grpname),NULL);
streamFreeCG(cg); streamFreeCG(cg);
addReply(c,shared.cone); addReply(c,shared.cone);
server.dirty++; server.dirty++;
notifyKeyspaceEvent(NOTIFY_STREAM,"xgroup-destroy",
c->argv[2],c->db->id);
} else { } else {
addReply(c,shared.czero); addReply(c,shared.czero);
} }
@ -1635,6 +1640,8 @@ NULL
long long pending = streamDelConsumer(cg,c->argv[4]->ptr); long long pending = streamDelConsumer(cg,c->argv[4]->ptr);
addReplyLongLong(c,pending); addReplyLongLong(c,pending);
server.dirty++; server.dirty++;
notifyKeyspaceEvent(NOTIFY_STREAM,"xgroup-delconsumer",
c->argv[2],c->db->id);
} else if (!strcasecmp(opt,"HELP")) { } else if (!strcasecmp(opt,"HELP")) {
addReplyHelp(c, help); addReplyHelp(c, help);
} else { } else {