gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

In addReplyErrorLength() only panic when replying to slave.

Browse Source 
See #5135 for more context.
This commit is contained in:
antirez 2018-07-18 17:41:06 +02:00
parent 2693b42ee4
commit d7631eeb68
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/networking.c
View File

@ -360,10 +360,11 @@ void addReplyErrorLength(client *c, const char *s, size_t len) {
serverLog(LL_WARNING,"== CRITICAL == This %s is sending an error " serverLog(LL_WARNING,"== CRITICAL == This %s is sending an error "
"to its %s: '%s' after processing the command " "to its %s: '%s' after processing the command "
"'%s'", from, to, s, cmdname); "'%s'", from, to, s, cmdname);
/* Here we want to panic because when an instance is sending an /* Here we want to panic because when a master is sending an
* error to another instance in the context of replication, this can * error to some slave in the context of replication, this can
* only create some kind of offset or data desynchronization. Better * only create some kind of offset or data desynchronization. Better
* to catch it ASAP and crash instead of continuing. */ * to catch it ASAP and crash instead of continuing. */
if (c->flags & CLIENT_SLAVE)
serverPanic("Continuing is unsafe: replication protocol violation."); serverPanic("Continuing is unsafe: replication protocol violation.");
} }
} }