From d2405b9b6bf1d4e6b84d3974a52fabcbeac533f1 Mon Sep 17 00:00:00 2001 From: judeng Date: Thu, 23 Jun 2022 23:19:36 +0800 Subject: [PATCH] fix benchmark failure in daily test with TLS (#10896) The new test added in #10891 can fail with a different error. see comment in networking.c saying ```c /* That's a best effort error message, don't check write errors. * Note that for TLS connections, no handshake was done yet so nothing * is written and the connection will just drop. */ ``` --- tests/integration/redis-benchmark.tcl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/integration/redis-benchmark.tcl b/tests/integration/redis-benchmark.tcl index ac894aed0..5e8555b1b 100644 --- a/tests/integration/redis-benchmark.tcl +++ b/tests/integration/redis-benchmark.tcl @@ -118,11 +118,11 @@ start_server {tags {"benchmark network external:skip"}} { } test {benchmark: clients idle mode should return error when reached maxclients limit} { - set cmd [redisbenchmark $master_host $master_port "-c 2 -I"] + set cmd [redisbenchmark $master_host $master_port "-c 10 -I"] set original_maxclients [lindex [r config get maxclients] 1] - r config set maxclients 1 + r config set maxclients 5 catch { exec {*}$cmd } error - assert_match "*ERR max number of clients reached*" $error + assert_match "*Error*" $error r config set maxclients $original_maxclients }