From cde22bf6235eeabaead98978fc6de0b8fa09a76d Mon Sep 17 00:00:00 2001 From: Matt Stancliff Date: Wed, 19 Feb 2014 17:26:33 -0500 Subject: [PATCH] Fix "can't bind to address" error reporting. Report the actual port used for the listening attempt instead of server.port. Originally, Redis would just listen on server.port. But, with clustering, Redis uses a Cluster Port too, so we can't say server.port is always where we are listening. If you tried to launch Redis with a too-high port number (any port where Port+10000 > 65535), Redis would refuse to start, but only print an error saying it can't connect to the Redis port. This patch fixes much confusions. --- src/redis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/redis.c b/src/redis.c index 0d1686a02..817943e30 100644 --- a/src/redis.c +++ b/src/redis.c @@ -1581,7 +1581,7 @@ int listenToPort(int port, int *fds, int *count) { redisLog(REDIS_WARNING, "Creating Server TCP listening socket %s:%d: %s", server.bindaddr[j] ? server.bindaddr[j] : "*", - server.port, server.neterr); + port, server.neterr); return REDIS_ERR; } (*count)++;