gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

Fix the secrete for test bucket. (#1447)

Browse Source 
We have set the secret as `AWS_S3_TEST_BUCKET` for test bucket and I
missed it in the initial review.

Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
This commit is contained in:
Roshan Khatri 2024-12-16 13:01:34 -08:00 committed by Madelyn Olson
parent db15d7f148
commit cc2f675ce6
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.github/workflows/build-release-packages.yml vendored
View File

@ -59,8 +59,10 @@ jobs:
id: check-if-testing id: check-if-testing
run: | run: |
if [[ "${{ github.event_name }}" == "push" ]]; then if [[ "${{ github.event_name }}" == "push" ]]; then
echo "This is a test workflow -> We will upload to the Test S3 Bucket"
echo "IS_TEST=true" >> $GITHUB_OUTPUT echo "IS_TEST=true" >> $GITHUB_OUTPUT
else else
echo "This is a Release workflow -> We will upload to the Release S3 Bucket"
echo "IS_TEST=false" >> $GITHUB_OUTPUT echo "IS_TEST=false" >> $GITHUB_OUTPUT
fi fi
shell: bash shell: bash
@ -92,7 +94,7 @@ jobs:
build_matrix: ${{ needs.generate-build-matrix.outputs.x86_64-build-matrix }} build_matrix: ${{ needs.generate-build-matrix.outputs.x86_64-build-matrix }}
region: us-west-2 region: us-west-2
secrets: secrets:
bucket_name: ${{ needs.release-build-get-meta.outputs.is_test == 'true' && secrets.AWS_TEST_BUCKET || secrets.AWS_S3_BUCKET }} bucket_name: ${{ needs.release-build-get-meta.outputs.is_test == 'true' && secrets.AWS_S3_TEST_BUCKET || secrets.AWS_S3_BUCKET }}
role_to_assume: ${{ secrets.AWS_ROLE_TO_ASSUME }} role_to_assume: ${{ secrets.AWS_ROLE_TO_ASSUME }}
release-build-linux-arm-packages: release-build-linux-arm-packages:
@ -106,5 +108,5 @@ jobs:
build_matrix: ${{ needs.generate-build-matrix.outputs.arm64-build-matrix }} build_matrix: ${{ needs.generate-build-matrix.outputs.arm64-build-matrix }}
region: us-west-2 region: us-west-2
secrets: secrets:
bucket_name: ${{ needs.release-build-get-meta.outputs.is_test == 'true' && secrets.AWS_TEST_BUCKET || secrets.AWS_S3_BUCKET }} bucket_name: ${{ needs.release-build-get-meta.outputs.is_test == 'true' && secrets.AWS_S3_TEST_BUCKET || secrets.AWS_S3_BUCKET }}
role_to_assume: ${{ secrets.AWS_ROLE_TO_ASSUME }} role_to_assume: ${{ secrets.AWS_ROLE_TO_ASSUME }}