gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix undefined behavior in ll2string().

Browse Source 
The bug was found by @CAFxX, thanks!
See issue #1940.
This commit is contained in:
antirez 2014-08-15 15:48:15 +02:00
parent 636ef842de
commit ca7d9f42b3
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/util.c
View File

@ -261,7 +261,11 @@ int ll2string(char* dst, size_t dstlen, long long svalue) {
/* The main loop works with 64bit unsigned integers for simplicity, so /* The main loop works with 64bit unsigned integers for simplicity, so
* we convert the number here and remember if it is negative. */ * we convert the number here and remember if it is negative. */
if (svalue < 0) { if (svalue < 0) {
if (svalue != LLONG_MIN) {
value = -svalue; value = -svalue;
} else {
value = ((unsigned long long) LLONG_MAX)+1;
}
negative = 1; negative = 1;
} else { } else {
value = svalue; value = svalue;