From bf56948fd0c9dfd3bf7ac63e8dc50b47a4f6e98c Mon Sep 17 00:00:00 2001 From: antirez Date: Sun, 28 Jul 2013 11:00:09 +0200 Subject: [PATCH] Remove dead variable bothsds from object.c. Thanks to @run and @badboy for spotting this. Triva: clang was not able to provide me a warning about that when compiling. This closes #1024 and #1207, committing the change myself as the pull requests no longer apply cleanly after other changes to the same function. --- src/object.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/object.c b/src/object.c index 9efb590f8..159e92ada 100644 --- a/src/object.c +++ b/src/object.c @@ -418,7 +418,6 @@ int compareStringObjectsWithFlags(robj *a, robj *b, int flags) { redisAssertWithInfo(NULL,a,a->type == REDIS_STRING && b->type == REDIS_STRING); char bufa[128], bufb[128], *astr, *bstr; size_t alen, blen, minlen; - int bothsds = 1; if (a == b) return 0; if (sdsEncodedObject(a)) { @@ -427,7 +426,6 @@ int compareStringObjectsWithFlags(robj *a, robj *b, int flags) { } else { alen = ll2string(bufa,sizeof(bufa),(long) a->ptr); astr = bufa; - bothsds = 0; } if (sdsEncodedObject(b)) { bstr = b->ptr; @@ -435,7 +433,6 @@ int compareStringObjectsWithFlags(robj *a, robj *b, int flags) { } else { blen = ll2string(bufb,sizeof(bufb),(long) b->ptr); bstr = bufb; - bothsds = 0; } if (flags & REDIS_COMPARE_COLL) { return strcoll(astr,bstr);