gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added assertion in hllSparseAdd() when promotion to dense occurs.

Browse Source 
If we converted to dense, a register must be updated in the dense
representation.
This commit is contained in:
antirez 2014-04-14 15:55:21 +02:00
parent e9cd51c7eb
commit ba0afb4566
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/hyperloglog.c
View File

@ -865,7 +865,17 @@ updated:
promote: /* Promote to dense representation. */ promote: /* Promote to dense representation. */
if (hllSparseToDense(o) == REDIS_ERR) return -1; /* Corrupted HLL. */ if (hllSparseToDense(o) == REDIS_ERR) return -1; /* Corrupted HLL. */
hdr = o->ptr; hdr = o->ptr;
return hllDenseAdd(hdr->registers, ele, elesize);
/* We need to call hllDenseAdd() to perform the operation after the
* conversion. However the result must be 1, since if we need to
* convert from sparse to dense a register requires to be updated.
*
* Note that this in turn means that PFADD will make sure the command
* is propagated to slaves / AOF, so if there is a sparse -> dense
* convertion, it will be performed in all the slaves as well. */
int dense_retval = hllDenseAdd(hdr->registers, ele, elesize);
redisAssert(dense_retval == 1);
return dense_retval;
} }
/* Compute SUM(2^-reg) in the sparse representation. /* Compute SUM(2^-reg) in the sparse representation.