redis-check-aof.c: Avoid leaking file handle if file is zero bytes (#12797)

If fopen() is successful, but redis_fstat() determines the file is zero
bytes, the file handle stored in fp will leak. This change closes the
filehandle stored in fp if the file is zero bytes.

An FD leak on a tool like redis-check-aof isn't an issue (it'll exit soon anyway).
This is just a cleanup.
This commit is contained in:
Moshe Kaplan 2023-11-23 03:08:49 -05:00 committed by GitHub
parent 1c48d3dab2
commit ae09d4d3ef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -238,6 +238,7 @@ int checkSingleAof(char *aof_filename, char *aof_filepath, int last_file, int fi
off_t size = sb.st_size;
if (size == 0) {
fclose(fp);
return AOF_CHECK_EMPTY;
}