From a6ab09cf7b7e6b7e966dbc41cd3f79cfffe9e253 Mon Sep 17 00:00:00 2001 From: John Sully Date: Wed, 4 May 2022 16:51:48 +0000 Subject: [PATCH] Ensure we force moves not copies when ingesting bulk insert files --- src/storage/rocksdb.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/storage/rocksdb.cpp b/src/storage/rocksdb.cpp index 7d77cce53..d8acf9f51 100644 --- a/src/storage/rocksdb.cpp +++ b/src/storage/rocksdb.cpp @@ -74,8 +74,8 @@ void RocksDBStorageProvider::bulkInsert(char **rgkeys, size_t *rgcbkeys, char ** auto ingestOptions = rocksdb::IngestExternalFileOptions(); ingestOptions.move_files = true; - //ingestOptions.verify_file_checksum = false; ingestOptions.write_global_seqno = false; + ingestOptions.failed_move_fall_back_to_copy = false; // Ingest the external SST file into the DB s = m_spdb->IngestExternalFile(m_spcolfamily.get(), {file_path}, ingestOptions); @@ -83,8 +83,6 @@ void RocksDBStorageProvider::bulkInsert(char **rgkeys, size_t *rgcbkeys, char ** unlink(file_path.c_str()); goto LFallback; } - - unlink(file_path.c_str()); } else { LFallback: auto spbatch = std::make_unique();